)]}'
{"id":"openstack%2Fpython-cinderclient~180533","triplet_id":"openstack%2Fpython-cinderclient~master~Ide334d7535c73cbdff72c30319eb539d8f5304d6","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1449444","hashtags":[],"change_id":"Ide334d7535c73cbdff72c30319eb539d8f5304d6","subject":"Find resource refactoring","status":"MERGED","created":"2015-05-06 13:12:18.000000000","updated":"2015-05-17 20:57:30.000000000","submitted":"2015-05-17 20:57:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d086817f1b3a0f82a750c523a2ea873e3dd83d85","_number":180533,"virtual_id_number":180533,"owner":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-05-17 20:57:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":2,"date":"2015-05-14 13:06:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":2,"date":"2015-05-17 20:16:03.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":1,"date":"2015-05-12 12:45:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":1,"date":"2015-05-17 20:16:03.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-12 12:45:45.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2015-05-14 13:06:33.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-05-17 20:16:03.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2015-05-17 20:57:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b88e9bf412b2a79d0a07290f1002859e97fb4aa0","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-05-06 13:12:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5d5a5ac1336803c68ee870012431f32d6314f43e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-06 14:09:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/33/180533/1/check/gate-python-cinderclient-python26/478a1c7/ : SUCCESS in 1m 09s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/33/180533/1/check/gate-python-cinderclient-pep8/4c87c19/ : SUCCESS in 1m 07s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/33/180533/1/check/gate-python-cinderclient-docs/1383871//doc/build/html/ : SUCCESS in 49s\n- gate-python-cinderclient-python27 http://logs.openstack.org/33/180533/1/check/gate-python-cinderclient-python27/1f04794/ : SUCCESS in 57s\n- gate-python-cinderclient-python34 http://logs.openstack.org/33/180533/1/check/gate-python-cinderclient-python34/8ddee15/ : SUCCESS in 2m 45s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/33/180533/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/3b338b9/ : SUCCESS in 48m 25s\n- gate-python-cinderclient-pypy http://logs.openstack.org/33/180533/1/check/gate-python-cinderclient-pypy/1e09de9/ : SUCCESS in 1m 33s","accounts_in_message":[],"_revision_number":1},{"id":"c65e06aeecc2ed10fff620e6adc02495483f0859","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-11 16:51:05.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI really like this solution together with your other patch!!\n\nShouldn\u0027t we also specify NAME_ATTR for Cgsnapshot?","accounts_in_message":[],"_revision_number":1},{"id":"4ea8379a6bdbb2f4d8981661244c0baa1c39164e","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-05-12 11:48:30.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nGorka, as I see cgsnapshots uses \u0027name\u0027 attr, wich is default in resource class","accounts_in_message":[],"_revision_number":1},{"id":"c2bb4c7d60baa919bd66059895d8cfb95a94d266","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-05-12 11:53:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"788cd2dcef6b1823f74f4858f281b2b4c4941a21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-12 12:39:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/33/180533/2/check/gate-python-cinderclient-python26/9f9de6a/ : SUCCESS in 1m 06s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/33/180533/2/check/gate-python-cinderclient-pep8/3207e4f/ : SUCCESS in 1m 01s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/33/180533/2/check/gate-python-cinderclient-docs/9044ed5//doc/build/html/ : SUCCESS in 55s\n- gate-python-cinderclient-python27 http://logs.openstack.org/33/180533/2/check/gate-python-cinderclient-python27/ab40b04/ : SUCCESS in 2m 08s\n- gate-python-cinderclient-python34 http://logs.openstack.org/33/180533/2/check/gate-python-cinderclient-python34/bd992a6/ : SUCCESS in 1m 39s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/33/180533/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/0bfd81c/ : SUCCESS in 46m 39s\n- gate-python-cinderclient-pypy http://logs.openstack.org/33/180533/2/check/gate-python-cinderclient-pypy/1053adc/ : FAILURE in 2m 17s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"646d04bbd48318bab49e8d85a85cfc2a8ed303bc","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-12 12:45:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"248b52629e920d5bd85cc1452bced66951e91f78","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-12 12:45:45.000000000","message":"Patch Set 2: Code-Review+1\n\nYup, you are right, cgsnapshots use name, not display_name.","accounts_in_message":[],"_revision_number":2},{"id":"a7338f183cca6cc45896f863a1395f69144f22aa","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-05-14 13:06:33.000000000","message":"Patch Set 2: Code-Review+2\n\nTested with Juno, Kilo and master","accounts_in_message":[],"_revision_number":2},{"id":"54fa5d675d0881cad06c2e054db474f77ec4d6e6","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2015-05-17 20:16:03.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"450fe72a9a663b4c46b2ffce612075ae0d7b144f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-17 20:16:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"3edf57625c092e9cea5fe911f63a87f1951df5a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-17 20:57:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/33/180533/2/gate/gate-python-cinderclient-python26/4061414/ : SUCCESS in 1m 09s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/33/180533/2/gate/gate-python-cinderclient-docs/8608a01//doc/build/html/ : SUCCESS in 58s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/33/180533/2/gate/gate-python-cinderclient-pep8/1ebf186/ : SUCCESS in 53s\n- gate-python-cinderclient-python27 http://logs.openstack.org/33/180533/2/gate/gate-python-cinderclient-python27/7c729cf/ : SUCCESS in 53s\n- gate-python-cinderclient-python34 http://logs.openstack.org/33/180533/2/gate/gate-python-cinderclient-python34/5200c87/ : SUCCESS in 1m 13s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/33/180533/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/9d4c74a/ : SUCCESS in 41m 20s\n- gate-python-cinderclient-pypy http://logs.openstack.org/33/180533/2/gate/gate-python-cinderclient-pypy/c182aa5/ : SUCCESS in 1m 44s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"90b33c5c489bd3a5a009ddcd1a3cc71ac7f5d5b2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-17 20:57:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c5c2d67b7f683ea1f4e8acfb54930bfc2954b342","revisions":{"a13264b81252fb8c26e3a898e707a2b9a73bb7e9":{"kind":"REWORK","_number":1,"created":"2015-05-06 13:12:18.000000000","uploader":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"ref":"refs/changes/33/180533/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/33/180533/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/33/180533/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/33/180533/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/33/180533/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/33/180533/1"}}},"commit":{"parents":[{"commit":"d936ebaaf661bf3d64b4b62872d3e203a2ca06b8","subject":"Merge \"Remove \"OPTIONAL:\" from optional argument help text (v2)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d936ebaaf661bf3d64b4b62872d3e203a2ca06b8"}]}],"author":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-04-28 10:12:48.000000000","tz":180},"committer":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-05-06 11:55:28.000000000","tz":180},"subject":"Find resource refactoring","message":"Find resource refactoring\n\nThe \u0027name\u0027 field for some resources is called something different,\nfor example \u0027display_name\u0027 for volumes, \u0027name\u0027 for  volumes type.\nSo class \u0027resource\u0027 has attribute \u0027NAME_ATTR\u0027 wich contains\nattribute name for different resources.\n\nThis change removes reduntant call find in resource manager, instead\nof it checks NAME_ATTR value.\n\nRelated-Bug: #1449444\nChange-Id: Ide334d7535c73cbdff72c30319eb539d8f5304d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a13264b81252fb8c26e3a898e707a2b9a73bb7e9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a13264b81252fb8c26e3a898e707a2b9a73bb7e9"}]},"branch":"refs/heads/master"},"c5c2d67b7f683ea1f4e8acfb54930bfc2954b342":{"kind":"REWORK","_number":2,"created":"2015-05-12 11:53:05.000000000","uploader":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"ref":"refs/changes/33/180533/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/33/180533/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/33/180533/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/33/180533/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/33/180533/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/33/180533/2"}}},"commit":{"parents":[{"commit":"d936ebaaf661bf3d64b4b62872d3e203a2ca06b8","subject":"Merge \"Remove \"OPTIONAL:\" from optional argument help text (v2)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d936ebaaf661bf3d64b4b62872d3e203a2ca06b8"}]}],"author":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-04-28 10:12:48.000000000","tz":180},"committer":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-05-12 11:52:46.000000000","tz":180},"subject":"Find resource refactoring","message":"Find resource refactoring\n\nThe \u0027name\u0027 field for some resources is called something different,\nfor example \u0027display_name\u0027 for volumes, \u0027name\u0027 for  volumes type.\nSo class \u0027resource\u0027 has attribute \u0027NAME_ATTR\u0027 wich contains\nattribute name for different resources.\n\nThis change removes reduntant call find in resource manager, instead\nof it checks NAME_ATTR value.\n\nRelated-Bug: #1449444\nChange-Id: Ide334d7535c73cbdff72c30319eb539d8f5304d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c5c2d67b7f683ea1f4e8acfb54930bfc2954b342"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c5c2d67b7f683ea1f4e8acfb54930bfc2954b342"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}