)]}'
{"cinderclient/base.py":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"816d7d409c9af8e658c3fcbf27b113e452a46834","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        Find all items with attributes matching ``**kwargs``."},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        This isn\u0027t very efficient: it loads the entire list then filters on"},{"line_number":231,"context_line":"        the Python side."},{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        # Want to search for all tenants here so that when attempting to delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_63cb9c54","line":231,"updated":"2015-05-07 03:59:13.000000000","message":"You changed the code, please, update a method description.","commit_id":"8ebd9f79174f3629e2c241c47f92606bd6bb18b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2351ed724c8b8dd30de1ef90fe9a4b0fc8f373cf","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        # Pass \u0027name\u0027 or \u0027display_name\u0027 search_opts to server filtering to"},{"line_number":240,"context_line":"        # increase search performance."},{"line_number":241,"context_line":"        if \"name\" in kwargs:"},{"line_number":242,"context_line":"            search_opts.update({\u0027name\u0027: kwargs[\"name\"]})"},{"line_number":243,"context_line":"        elif \"display_name\" in kwargs:"},{"line_number":244,"context_line":"            search_opts.update({\u0027display_name\u0027: kwargs[\"display_name\"]})"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad8896b_746840bb","line":242,"updated":"2015-05-11 17:24:31.000000000","message":"Why not `search_opts[\u0027name\u0027] \u003d kwargs[\u0027name\u0027]`?\n\nIt would be nice consistency in string delimiters, either \u0027 or \" but both on the same line...","commit_id":"af69b48b43f064a841ade0d9d933b0bf3c9f7339"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"65a7b44e4ded05f05db513781b96994e124c6c6b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        # Pass \u0027name\u0027 or \u0027display_name\u0027 search_opts to server filtering to"},{"line_number":240,"context_line":"        # increase search performance."},{"line_number":241,"context_line":"        if \"name\" in kwargs:"},{"line_number":242,"context_line":"            search_opts.update({\u0027name\u0027: kwargs[\"name\"]})"},{"line_number":243,"context_line":"        elif \"display_name\" in kwargs:"},{"line_number":244,"context_line":"            search_opts.update({\u0027display_name\u0027: kwargs[\"display_name\"]})"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_5b88b622","line":242,"in_reply_to":"7ad8896b_746840bb","updated":"2015-05-14 14:35:04.000000000","message":"Done","commit_id":"af69b48b43f064a841ade0d9d933b0bf3c9f7339"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2351ed724c8b8dd30de1ef90fe9a4b0fc8f373cf","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        if \"name\" in kwargs:"},{"line_number":242,"context_line":"            search_opts.update({\u0027name\u0027: kwargs[\"name\"]})"},{"line_number":243,"context_line":"        elif \"display_name\" in kwargs:"},{"line_number":244,"context_line":"            search_opts.update({\u0027display_name\u0027: kwargs[\"display_name\"]})"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        found \u003d []"},{"line_number":247,"context_line":"        searches \u003d list(kwargs.items())"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad8896b_3462b8d9","line":244,"updated":"2015-05-11 17:24:31.000000000","message":"Same as above","commit_id":"af69b48b43f064a841ade0d9d933b0bf3c9f7339"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"65a7b44e4ded05f05db513781b96994e124c6c6b","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        if \"name\" in kwargs:"},{"line_number":242,"context_line":"            search_opts.update({\u0027name\u0027: kwargs[\"name\"]})"},{"line_number":243,"context_line":"        elif \"display_name\" in kwargs:"},{"line_number":244,"context_line":"            search_opts.update({\u0027display_name\u0027: kwargs[\"display_name\"]})"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        found \u003d []"},{"line_number":247,"context_line":"        searches \u003d list(kwargs.items())"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_bb51ea64","line":244,"in_reply_to":"7ad8896b_3462b8d9","updated":"2015-05-14 14:35:04.000000000","message":"Done","commit_id":"af69b48b43f064a841ade0d9d933b0bf3c9f7339"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2351ed724c8b8dd30de1ef90fe9a4b0fc8f373cf","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            search_opts.update({\u0027display_name\u0027: kwargs[\"display_name\"]})"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        found \u003d []"},{"line_number":247,"context_line":"        searches \u003d list(kwargs.items())"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Not all resources support filters on server side, so when doing"},{"line_number":250,"context_line":"        # findall some client side filtering is still needed."}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad8896b_f70432c7","line":247,"updated":"2015-05-11 17:24:31.000000000","message":"items method already returns a list, no need to instantiate another list object here.","commit_id":"af69b48b43f064a841ade0d9d933b0bf3c9f7339"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"65a7b44e4ded05f05db513781b96994e124c6c6b","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            search_opts.update({\u0027display_name\u0027: kwargs[\"display_name\"]})"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        found \u003d []"},{"line_number":247,"context_line":"        searches \u003d list(kwargs.items())"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Not all resources support filters on server side, so when doing"},{"line_number":250,"context_line":"        # findall some client side filtering is still needed."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_5e88a422","line":247,"in_reply_to":"7ad8896b_f70432c7","updated":"2015-05-14 14:35:04.000000000","message":"Done","commit_id":"af69b48b43f064a841ade0d9d933b0bf3c9f7339"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2351ed724c8b8dd30de1ef90fe9a4b0fc8f373cf","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        found \u003d []"},{"line_number":247,"context_line":"        searches \u003d list(kwargs.items())"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Not all resources support filters on server side, so when doing"},{"line_number":250,"context_line":"        # findall some client side filtering is still needed."},{"line_number":251,"context_line":"        for obj in self.list(search_opts\u003dsearch_opts):"},{"line_number":252,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad8896b_f7b9d2ed","line":249,"updated":"2015-05-11 17:24:31.000000000","message":"I think it\u0027s worth mentioning in the comment that we could also have filters on fields that are not supported remotely so we need to run them locally.","commit_id":"af69b48b43f064a841ade0d9d933b0bf3c9f7339"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"65a7b44e4ded05f05db513781b96994e124c6c6b","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        found \u003d []"},{"line_number":247,"context_line":"        searches \u003d list(kwargs.items())"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Not all resources support filters on server side, so when doing"},{"line_number":250,"context_line":"        # findall some client side filtering is still needed."},{"line_number":251,"context_line":"        for obj in self.list(search_opts\u003dsearch_opts):"},{"line_number":252,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_be6af818","line":249,"in_reply_to":"7ad8896b_f7b9d2ed","updated":"2015-05-14 14:35:04.000000000","message":"Done","commit_id":"af69b48b43f064a841ade0d9d933b0bf3c9f7339"}]}