)]}'
{"cinderclient/shell.py":[{"author":{"_account_id":1706,"name":"Tom Hancock","email":"tom.hancock@hp.com","username":"tom-hancock"},"change_message_id":"5fac57dc5cdebea96d032d5a22d37aa198e6cf20","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                            help\u003dargparse.SUPPRESS)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        parser.add_argument(\u0027--endpoint-type\u0027,"},{"line_number":166,"context_line":"                            metavar\u003d\u0027\u003cendpoint-type\u003e\u0027,"},{"line_number":167,"context_line":"                            default\u003dutils.env(\u0027CINDER_ENDPOINT_TYPE\u0027,"},{"line_number":168,"context_line":"                            default\u003dDEFAULT_CINDER_ENDPOINT_TYPE),"},{"line_number":169,"context_line":"                            help\u003d\u0027DEPRECATED! Use --os-endpoint-type.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_62bce96c","line":166,"updated":"2015-05-12 14:07:32.000000000","message":"dest\u003dos_endpoint_type to tie it together with the new variable?","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8f4df09619874667e46b0243c0cb49dc355eb5b2","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                            help\u003dargparse.SUPPRESS)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        parser.add_argument(\u0027--endpoint-type\u0027,"},{"line_number":166,"context_line":"                            metavar\u003d\u0027\u003cendpoint-type\u003e\u0027,"},{"line_number":167,"context_line":"                            default\u003dutils.env(\u0027CINDER_ENDPOINT_TYPE\u0027,"},{"line_number":168,"context_line":"                            default\u003dDEFAULT_CINDER_ENDPOINT_TYPE),"},{"line_number":169,"context_line":"                            help\u003d\u0027DEPRECATED! Use --os-endpoint-type.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_3b04d813","line":166,"in_reply_to":"9a0c5dc1_62bce96c","updated":"2015-05-12 14:35:46.000000000","message":"Yes, I think that saves code later.","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":1706,"name":"Tom Hancock","email":"tom.hancock@hp.com","username":"tom-hancock"},"change_message_id":"5fac57dc5cdebea96d032d5a22d37aa198e6cf20","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                            metavar\u003d\u0027\u003cos-endpoint-type\u003e\u0027,"},{"line_number":176,"context_line":"                            default\u003dutils.env(\u0027OS_ENDPOINT_TYPE\u0027,"},{"line_number":177,"context_line":"                            default\u003dutils.env(\u0027CINDER_ENDPOINT_TYPE\u0027,"},{"line_number":178,"context_line":"                            default\u003dDEFAULT_CINDER_ENDPOINT_TYPE)),"},{"line_number":179,"context_line":"                            help\u003d\u0027Endpoint type, which is publicURL or \u0027"},{"line_number":180,"context_line":"                            \u0027internalURL. \u0027"},{"line_number":181,"context_line":"                            \u0027Default\u003denv[OS_ENDPOINT_TYPE] or \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_659bd3ca","line":178,"updated":"2015-05-12 14:07:32.000000000","message":"would some indentation help here to distinguish the \u0027default\u0027s to utils.env()\nfrom parser.add_argument()...or maybe it will cause pep8 issues?","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8f4df09619874667e46b0243c0cb49dc355eb5b2","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                            metavar\u003d\u0027\u003cos-endpoint-type\u003e\u0027,"},{"line_number":176,"context_line":"                            default\u003dutils.env(\u0027OS_ENDPOINT_TYPE\u0027,"},{"line_number":177,"context_line":"                            default\u003dutils.env(\u0027CINDER_ENDPOINT_TYPE\u0027,"},{"line_number":178,"context_line":"                            default\u003dDEFAULT_CINDER_ENDPOINT_TYPE)),"},{"line_number":179,"context_line":"                            help\u003d\u0027Endpoint type, which is publicURL or \u0027"},{"line_number":180,"context_line":"                            \u0027internalURL. \u0027"},{"line_number":181,"context_line":"                            \u0027Default\u003denv[OS_ENDPOINT_TYPE] or \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_7b48105c","line":178,"in_reply_to":"9a0c5dc1_659bd3ca","updated":"2015-05-12 14:35:46.000000000","message":"I see novaclient does the indent, but things are lined up in this file. I get some pep8 failures in this file before the patch, so I\u0027m not even sure pep8 is enforced. However, I\u0027m inclined to keep the pattern that already existed for this file.","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":1706,"name":"Tom Hancock","email":"tom.hancock@hp.com","username":"tom-hancock"},"change_message_id":"5fac57dc5cdebea96d032d5a22d37aa198e6cf20","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            self.do_bash_completion(args)"},{"line_number":591,"context_line":"            return 0"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"        if os_endpoint_type is not None:"},{"line_number":594,"context_line":"            endpoint_type \u003d os_endpoint_type"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        (os_username, os_password, os_tenant_name, os_auth_url,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_82efddaf","line":593,"updated":"2015-05-12 14:07:32.000000000","message":"options.os_endpoint_type ?","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8f4df09619874667e46b0243c0cb49dc355eb5b2","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            self.do_bash_completion(args)"},{"line_number":591,"context_line":"            return 0"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"        if os_endpoint_type is not None:"},{"line_number":594,"context_line":"            endpoint_type \u003d os_endpoint_type"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        (os_username, os_password, os_tenant_name, os_auth_url,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_bb9328a3","line":593,"in_reply_to":"9a0c5dc1_82efddaf","updated":"2015-05-12 14:35:46.000000000","message":"this caused a test failure and I changed in next patchset, but I think your \"dest\u003d...\" suggestion is a better idea.","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":1706,"name":"Tom Hancock","email":"tom.hancock@hp.com","username":"tom-hancock"},"change_message_id":"5fac57dc5cdebea96d032d5a22d37aa198e6cf20","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            return 0"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"        if os_endpoint_type is not None:"},{"line_number":594,"context_line":"            endpoint_type \u003d os_endpoint_type"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        (os_username, os_password, os_tenant_name, os_auth_url,"},{"line_number":597,"context_line":"         os_region_name, os_tenant_id, endpoint_type, insecure,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_0503f774","line":594,"updated":"2015-05-12 14:07:32.000000000","message":"endpoint_type is reassigned on the next line so I\u0027m not sure about this?","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8f4df09619874667e46b0243c0cb49dc355eb5b2","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            return 0"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"        if os_endpoint_type is not None:"},{"line_number":594,"context_line":"            endpoint_type \u003d os_endpoint_type"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        (os_username, os_password, os_tenant_name, os_auth_url,"},{"line_number":597,"context_line":"         os_region_name, os_tenant_id, endpoint_type, insecure,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_5be9cc19","line":594,"in_reply_to":"9a0c5dc1_0503f774","updated":"2015-05-12 14:35:46.000000000","message":"Yes, it was a bug.","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":1706,"name":"Tom Hancock","email":"tom.hancock@hp.com","username":"tom-hancock"},"change_message_id":"5fac57dc5cdebea96d032d5a22d37aa198e6cf20","unresolved":false,"context_lines":[{"line_number":600,"context_line":"             args.os_username, args.os_password,"},{"line_number":601,"context_line":"             args.os_tenant_name, args.os_auth_url,"},{"line_number":602,"context_line":"             args.os_region_name, args.os_tenant_id,"},{"line_number":603,"context_line":"             args.endpoint_type, args.insecure,"},{"line_number":604,"context_line":"             args.service_type, args.service_name,"},{"line_number":605,"context_line":"             args.volume_service_name,"},{"line_number":606,"context_line":"             args.bypass_url, args.os_cacert,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_a5be6bfd","line":603,"updated":"2015-05-12 14:07:32.000000000","message":"see above - would it be easier to use args.os_endpoint_type\nand delete the two lines above?","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8f4df09619874667e46b0243c0cb49dc355eb5b2","unresolved":false,"context_lines":[{"line_number":600,"context_line":"             args.os_username, args.os_password,"},{"line_number":601,"context_line":"             args.os_tenant_name, args.os_auth_url,"},{"line_number":602,"context_line":"             args.os_region_name, args.os_tenant_id,"},{"line_number":603,"context_line":"             args.endpoint_type, args.insecure,"},{"line_number":604,"context_line":"             args.service_type, args.service_name,"},{"line_number":605,"context_line":"             args.volume_service_name,"},{"line_number":606,"context_line":"             args.bypass_url, args.os_cacert,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_bbda0877","line":603,"in_reply_to":"9a0c5dc1_a5be6bfd","updated":"2015-05-12 14:35:46.000000000","message":"yes.","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":1706,"name":"Tom Hancock","email":"tom.hancock@hp.com","username":"tom-hancock"},"change_message_id":"5fac57dc5cdebea96d032d5a22d37aa198e6cf20","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        else:"},{"line_number":611,"context_line":"            auth_plugin \u003d None"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        if not endpoint_type:"},{"line_number":614,"context_line":"            endpoint_type \u003d DEFAULT_CINDER_ENDPOINT_TYPE"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        if not service_type:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_a5ad4b8a","line":613,"updated":"2015-05-12 14:07:32.000000000","message":"the option is defaulted - is this check and assignment needed any more?","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8f4df09619874667e46b0243c0cb49dc355eb5b2","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        else:"},{"line_number":611,"context_line":"            auth_plugin \u003d None"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        if not endpoint_type:"},{"line_number":614,"context_line":"            endpoint_type \u003d DEFAULT_CINDER_ENDPOINT_TYPE"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        if not service_type:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_bbc1e882","line":613,"in_reply_to":"9a0c5dc1_a5ad4b8a","updated":"2015-05-12 14:35:46.000000000","message":"Not sure. I\u0027ll test it.","commit_id":"00727fb253146ccb71d1c8cb714371954ff04a8b"},{"author":{"_account_id":1706,"name":"Tom Hancock","email":"tom.hancock@hp.com","username":"tom-hancock"},"change_message_id":"636bcaf81da51767ece5d3ee3bfdea9c0d4ca65e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                            \u0027Default\u003denv[OS_ENDPOINT_TYPE] or \u0027"},{"line_number":182,"context_line":"                            \u0027nova env[CINDER_ENDPOINT_TYPE] or \u0027"},{"line_number":183,"context_line":"                            + DEFAULT_CINDER_ENDPOINT_TYPE + \u0027.\u0027)"},{"line_number":184,"context_line":"        parser.add_argument(\u0027--os-endpoint_type\u0027,"},{"line_number":185,"context_line":"                            help\u003dargparse.SUPPRESS)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        parser.add_argument(\u0027--os-volume-api-version\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a0c5dc1_acc1b082","line":184,"updated":"2015-05-12 15:18:24.000000000","message":"os_endpoint_type  IE swap dash for underscore?","commit_id":"5a5783a19a5bafbc0fe9c87a60a3fa0737c51aea"}]}