)]}'
{"cinderclient/v2/shell.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"747430dccd798e2c4862f1341856a82866a19c4c","unresolved":false,"context_lines":[{"line_number":262,"context_line":"class CheckSizeArgForCreate(argparse.Action):"},{"line_number":263,"context_line":"    def __call__(self, parser, args, values, option_string\u003dNone):"},{"line_number":264,"context_line":"        if (args.snapshot_id or args.source_volid or args.source_replica"},{"line_number":265,"context_line":"                or values) is None:"},{"line_number":266,"context_line":"            parser.error(\u0027Size is a required parameter if snapshot \u0027"},{"line_number":267,"context_line":"                         \u0027or source volume is not specified.\u0027)"},{"line_number":268,"context_line":"        setattr(args, self.dest, values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_2f5412c8","line":265,"updated":"2015-06-04 17:05:53.000000000","message":"The reason that this gives a false positive is that \u0027values\u0027 is not None, it is \u00270\u0027.\nSo if there is a \u00270\u0027 for values, the Size is indeed set (to zero) and the error is not caught until later in volume/flows/api/create_volume.py","commit_id":"82a031518ea49f171de6644ea227cd6c008ecc7e"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"cea0a0f80998bd39259fcfb25c74489ff1394d73","unresolved":false,"context_lines":[{"line_number":262,"context_line":"class CheckSizeArgForCreate(argparse.Action):"},{"line_number":263,"context_line":"    def __call__(self, parser, args, values, option_string\u003dNone):"},{"line_number":264,"context_line":"        if (args.snapshot_id or args.source_volid or args.source_replica"},{"line_number":265,"context_line":"                or values) is None:"},{"line_number":266,"context_line":"            parser.error(\u0027Size is a required parameter if snapshot \u0027"},{"line_number":267,"context_line":"                         \u0027or source volume is not specified.\u0027)"},{"line_number":268,"context_line":"        setattr(args, self.dest, values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ff82b1c7","line":265,"in_reply_to":"5afe65bd_2f5412c8","updated":"2015-06-05 07:59:56.000000000","message":"That\u0027s for sure, you\u0027ve described current behavior of my change. If \u0027values\u0027 is \u00270\u0027 and there aren\u0027t source vol and snap, the error will caught in api, because \u00270\u0027 is not None.","commit_id":"82a031518ea49f171de6644ea227cd6c008ecc7e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"da1b8edfab2288d597a26e43c73f7c6ccd98bc07","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        if (values or args.snapshot_id or args.source_volid"},{"line_number":265,"context_line":"           or args.source_replica) is None:"},{"line_number":266,"context_line":"            parser.error(\u0027Size is a required parameter if snapshot \u0027"},{"line_number":267,"context_line":"                         \u0027or source volume is not specified.\u0027)"},{"line_number":268,"context_line":"        setattr(args, self.dest, values)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_d04b1886","side":"PARENT","line":267,"updated":"2015-06-08 15:29:03.000000000","message":"What about source_replica?","commit_id":"4f7bb8f3d73c00c68e4daf7d8f7cb08e8a2d6db1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"da1b8edfab2288d597a26e43c73f7c6ccd98bc07","unresolved":false,"context_lines":[{"line_number":262,"context_line":"class CheckSizeArgForCreate(argparse.Action):"},{"line_number":263,"context_line":"    def __call__(self, parser, args, values, option_string\u003dNone):"},{"line_number":264,"context_line":"        if ((args.snapshot_id or args.source_volid or args.source_replica)"},{"line_number":265,"context_line":"                is None and values is None):"},{"line_number":266,"context_line":"            parser.error(\u0027Size is a required parameter if snapshot \u0027"},{"line_number":267,"context_line":"                         \u0027or source volume is not specified.\u0027)"},{"line_number":268,"context_line":"        setattr(args, self.dest, values)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_507968c7","line":265,"updated":"2015-06-08 15:29:03.000000000","message":"How about:\n\n   if args.snapshot_id is None and args.source_volid is None and args.source_replica is None and values \u003d\u003d 0:\n\nJust make it so simple that no one has to think twice about what is going on here.","commit_id":"d3b8606ed29473b38d3d41499364b7b7b4d75aeb"}]}