)]}'
{"id":"openstack%2Fpython-cinderclient~182344","triplet_id":"openstack%2Fpython-cinderclient~master~I164970a600d6e86bd7076dd485f676a703f5e487","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1454276","hashtags":[],"change_id":"I164970a600d6e86bd7076dd485f676a703f5e487","subject":"Fix condition in CheckSizeArgForCreate parser action","status":"MERGED","created":"2015-05-12 15:19:03.000000000","updated":"2015-06-12 11:25:31.000000000","submitted":"2015-06-12 11:25:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ad97235a89956e861591ee241ecaaadb8b0e3f20","_number":182344,"virtual_id_number":182344,"owner":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2015-06-12 11:25:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2015-06-08 17:49:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":1,"date":"2015-06-08 17:08:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":1,"date":"2015-06-10 21:57:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":2,"date":"2015-06-12 10:34:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":1,"date":"2015-06-12 10:34:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-08 15:29:03.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2015-06-08 17:08:50.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2015-06-08 17:49:47.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2015-06-10 21:57:15.000000000","updated_by":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"reviewer":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"state":"REVIEWER"},{"updated":"2015-06-12 10:34:31.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-06-12 11:25:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dc270e3492405e8ac3f9ca5a44e245a91673aaab","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-05-12 15:19:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e2a5b7d745262b4c33a67384d3c453ec7c84427f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-12 16:22:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/44/182344/1/check/gate-python-cinderclient-python26/ef30c32/ : SUCCESS in 1m 47s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/44/182344/1/check/gate-python-cinderclient-pep8/b6bc522/ : SUCCESS in 51s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/44/182344/1/check/gate-python-cinderclient-docs/6b4bc19//doc/build/html/ : SUCCESS in 39s\n- gate-python-cinderclient-python27 http://logs.openstack.org/44/182344/1/check/gate-python-cinderclient-python27/ec36c0a/ : SUCCESS in 41s\n- gate-python-cinderclient-python34 http://logs.openstack.org/44/182344/1/check/gate-python-cinderclient-python34/d9527be/ : SUCCESS in 1m 28s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/44/182344/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/9d6bb82/ : SUCCESS in 45m 15s\n- gate-python-cinderclient-pypy http://logs.openstack.org/44/182344/1/check/gate-python-cinderclient-pypy/82746f3/ : FAILURE in 48s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dfe932b5374de4d313e59027cc8a544a2dafa880","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-06-02 03:55:54.000000000","message":"Patch Set 1: Code-Review-1\n\nMaybe I\u0027m missing something, but this doesn\u0027t look like it actually addresses what the commit message says. This just reorders the condition checks, and the unit test validates that if size of 0 is provided that it actually does make the API call.\n\nPlease correct me if I misunderstand something here.","accounts_in_message":[],"_revision_number":1},{"id":"4e71dbfbde6ccaaaa79b4a7b13e2652dea7ae65a","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-02 12:36:47.000000000","message":"Patch Set 1:\n\nSean,\norder in condition is important, because \u0027x or y\u0027 operation equivalent to \u0027if x is false, then y, else x\u0027. So if source vol or snapshot don\u0027t specified, size will be checked(and \u0027size \u003d 0\u0027 means that it is specified)","accounts_in_message":[],"_revision_number":1},{"id":"0c9e954bf28f0ff125a0f0adb4f5f49df773f922","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-06-02 13:08:54.000000000","message":"Patch Set 1:\n\nSorry, still not getting it. The conditional expression \u0027x or y\u0027 operation actually is not equivalent to \u0027if x is false, then y, else x\u0027. It would be equivalent to \u0027if x is false or if y is false, then do the block\u0027. And I still don\u0027t see where a check for 0 is done.","accounts_in_message":[],"_revision_number":1},{"id":"e8c302b6cefd4154489562e0629e6258f6b1fdf2","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-02 13:20:14.000000000","message":"Patch Set 1:\n\nSean, please read doc about boolean expressions\n https://docs.python.org/2/library/stdtypes.html#boolean-operations-and-or-not\nx or y \u003d if x is false, then y, else x.\n So we check last op \u0027size is None\u0027 to determine it is set or not(in case snap and source don\u0027t specified)","accounts_in_message":[],"_revision_number":1},{"id":"375eba337773cae627835e37edfb524bbd0a8b27","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-06-02 14:02:23.000000000","message":"Patch Set 1: -Code-Review\n\nI see - your wording was misleading. As far as the order things are evaluated that statement makes sense.\n\nIt still doesn\u0027t check if the value is 0 though.\n\nIt\u0027s possible my vacation brain isn\u0027t back completely, so I\u0027ll remove my -1 so there\u0027s a better chance others will review. I\u0027ll look again later and see if it makes more sense to me. :)","accounts_in_message":[],"_revision_number":1},{"id":"3a2ec9d33925ddb5f0fd24821bbd681138178cb0","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-02 14:17:52.000000000","message":"Patch Set 1:\n\nSean, thanks for review, agree this check is misleading, so I think more explicit check is needed here.","accounts_in_message":[],"_revision_number":1},{"id":"747430dccd798e2c4862f1341856a82866a19c4c","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2015-06-04 17:05:53.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nTo catch this you\u0027ll need to check that values is not zero. it is incorrect to check that it is not \u0027None\u0027. See comment.","accounts_in_message":[],"_revision_number":1},{"id":"cea0a0f80998bd39259fcfb25c74489ff1394d73","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-05 07:59:56.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c2a4548c6fb242f96bde6a2d35f3095266f3c4d7","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-08 09:43:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"15f41a8dd48f65e2e8c26c2b76ab224901a51e34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-08 10:42:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/44/182344/2/check/gate-python-cinderclient-python26/72aac75/ : SUCCESS in 1m 03s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/44/182344/2/check/gate-python-cinderclient-pep8/8ac3dca/ : SUCCESS in 48s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/44/182344/2/check/gate-python-cinderclient-docs/0d0449a//doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-cinderclient-python27 http://logs.openstack.org/44/182344/2/check/gate-python-cinderclient-python27/884305d/ : SUCCESS in 1m 13s\n- gate-python-cinderclient-python34 http://logs.openstack.org/44/182344/2/check/gate-python-cinderclient-python34/b51bce8/ : SUCCESS in 1m 29s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/44/182344/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/3a16511/ : SUCCESS in 57m 32s\n- gate-python-cinderclient-pypy http://logs.openstack.org/44/182344/2/check/gate-python-cinderclient-pypy/9f38da0/ : SUCCESS in 1m 55s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ba2962e6056c27f27e9bd67fc8d2feb2c95ff169","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-06-08 14:46:30.000000000","message":"Patch Set 2: Code-Review-1\n\nStill not checking if values is \"0\" (and not None) and there is no unit test validating that passing in 0 results in an error return.","accounts_in_message":[],"_revision_number":2},{"id":"da1b8edfab2288d597a26e43c73f7c6ccd98bc07","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2015-06-08 15:29:03.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nWe should be writing simple, straightforward high level\ncode that no one has to think twice about in order to\nparse.","accounts_in_message":[],"_revision_number":2},{"id":"13e120cd31bd0593e0953f480095b50a761d6970","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-08 15:33:28.000000000","message":"Patch Set 2:\n\nSean, Tom,\nCheckSizeArgForCreate action isn\u0027t check that size equal 0, it checks size is specified when snapshot or source volume aren\u0027t. I didn\u0027t add new functionality here, just fix  condition to pass when size\u003d0.","accounts_in_message":[],"_revision_number":2},{"id":"4a017ec4dcf4bf41eb50cd75fa5d6ba3186fd987","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-06-08 16:06:29.000000000","message":"Patch Set 2:\n\nEither the commit message needs to be updated or the code needs to be changed. If 0 is not a valid value then I would want the code to be changed.","accounts_in_message":[],"_revision_number":2},{"id":"f9e449f070c2d2fb12379d0d6e9c6d6cb7a6b2ba","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2015-06-08 16:15:29.000000000","message":"Patch Set 2: Code-Review+1\n\nI think the commit message would be more clear if it basically re-stated the info in the bug.","accounts_in_message":[],"_revision_number":2},{"id":"88c794331766e44303dae7b008b016ad6ee17fbe","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-06-08 16:20:53.000000000","message":"Patch Set 2: -Code-Review\n\nAfter discussion in IRC I see I am misinterpreting the intent of this patch. If we know 0 is going to fail I would rather see that caught right away, but that\u0027s a different issue.","accounts_in_message":[],"_revision_number":2},{"id":"38b11cd3c2c759d28706268cd6c46d8a0e5bd026","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-08 16:37:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5369b0d5420d91bf47922372d680c58d786c241c","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2015-06-08 17:08:50.000000000","message":"Patch Set 3: Code-Review+1\n\nThanks. Commit message is much more clear now.","accounts_in_message":[],"_revision_number":3},{"id":"a011e6cae883a983aebab6335d79f73056ecd0d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-08 17:32:31.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-python26/24197d7/ : SUCCESS in 1m 17s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-pep8/22a28f5/ : SUCCESS in 1m 06s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/44/182344/3/check/gate-python-cinderclient-docs/651497e//doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-cinderclient-python27 http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-python27/33e2459/ : SUCCESS in 1m 12s\n- gate-python-cinderclient-python34 http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-python34/d70e46c/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/44/182344/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient/f68884e/ : FAILURE in 51m 53s\n- gate-python-cinderclient-pypy http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-pypy/8b58a97/ : SUCCESS in 1m 53s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"9be52eb95dc3fd676328dc68937a7b7170bb1ba1","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-06-08 17:49:47.000000000","message":"Patch Set 3: Code-Review+2\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"b1a61a78c140a0ebd4f78b86620ca7f5965f76b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-08 18:49:19.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-python26/0146ed1/ : SUCCESS in 1m 22s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-pep8/2e51021/ : SUCCESS in 1m 21s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/44/182344/3/check/gate-python-cinderclient-docs/0f1d59a//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-cinderclient-python27 http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-python27/bb86f85/ : SUCCESS in 1m 20s\n- gate-python-cinderclient-python34 http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-python34/71935a4/ : SUCCESS in 1m 47s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/44/182344/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient/f53f9c6/ : SUCCESS in 52m 48s\n- gate-python-cinderclient-pypy http://logs.openstack.org/44/182344/3/check/gate-python-cinderclient-pypy/d7b1aa7/ : SUCCESS in 2m 07s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"9b8a3289b3a2f57055a27b048ce0bbe886b0b2ce","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2015-06-10 21:57:15.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"406a54bacdd4d249f5fe0fbca142abc4babb9884","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-06-12 10:34:31.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nLooks good. Thanks for fixing it!","accounts_in_message":[],"_revision_number":3},{"id":"9a03d3a66bb8a8cb695d64828ffbb5228ae6125a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-12 10:34:37.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"6ce1d0f7a403491c557b2e49574712d1192d560c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-12 11:25:28.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/44/182344/3/gate/gate-python-cinderclient-python26/59c0b50/ : SUCCESS in 1m 06s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/44/182344/3/gate/gate-python-cinderclient-docs/6faa215//doc/build/html/ : SUCCESS in 59s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/44/182344/3/gate/gate-python-cinderclient-pep8/d97c3cf/ : SUCCESS in 45s\n- gate-python-cinderclient-python27 http://logs.openstack.org/44/182344/3/gate/gate-python-cinderclient-python27/091f312/ : SUCCESS in 1m 08s\n- gate-python-cinderclient-python34 http://logs.openstack.org/44/182344/3/gate/gate-python-cinderclient-python34/7680324/ : SUCCESS in 1m 22s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/44/182344/3/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/e83ff0f/ : SUCCESS in 47m 34s\n- gate-python-cinderclient-pypy http://logs.openstack.org/44/182344/3/gate/gate-python-cinderclient-pypy/644ae5e/ : SUCCESS in 1m 35s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"4eaa48a7b8326c39b81a10171164ca6f50c60a90","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-12 11:25:31.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9cd42ef3ee5e8b386cb6e1941b39608ed216a04f","revisions":{"82a031518ea49f171de6644ea227cd6c008ecc7e":{"kind":"REWORK","_number":1,"created":"2015-05-12 15:19:03.000000000","uploader":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"ref":"refs/changes/44/182344/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/44/182344/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/1"}}},"commit":{"parents":[{"commit":"17bccf1a0643821b877bdb54839726e947d107d4","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/17bccf1a0643821b877bdb54839726e947d107d4"}]}],"author":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-05-12 14:42:10.000000000","tz":180},"committer":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-05-12 15:18:51.000000000","tz":180},"subject":"Fix condition in CheckSizeArgForCreate parser action","message":"Fix condition in CheckSizeArgForCreate parser action\n\nCheckSizeArgForCreate checks that size is specified when snapshot\nor source volume aren\u0027t. But it generates false-positives when size\nis 0. This change fix it.\n\nChange-Id: I164970a600d6e86bd7076dd485f676a703f5e487\nCloses-Bug: #1454276\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/82a031518ea49f171de6644ea227cd6c008ecc7e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/82a031518ea49f171de6644ea227cd6c008ecc7e"}]},"branch":"refs/heads/master"},"d3b8606ed29473b38d3d41499364b7b7b4d75aeb":{"kind":"REWORK","_number":2,"created":"2015-06-08 09:43:20.000000000","uploader":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"ref":"refs/changes/44/182344/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/44/182344/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/2"}}},"commit":{"parents":[{"commit":"4f7bb8f3d73c00c68e4daf7d8f7cb08e8a2d6db1","subject":"Merge \"Add findall server side filtering\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4f7bb8f3d73c00c68e4daf7d8f7cb08e8a2d6db1"}]}],"author":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-05-12 14:42:10.000000000","tz":180},"committer":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-06-05 13:02:29.000000000","tz":180},"subject":"Fix condition in CheckSizeArgForCreate parser action","message":"Fix condition in CheckSizeArgForCreate parser action\n\nCheckSizeArgForCreate checks that size is specified when snapshot\nor source volume aren\u0027t. But it generates false-positives when size\nis 0. This change fix it.\n\nChange-Id: I164970a600d6e86bd7076dd485f676a703f5e487\nCloses-Bug: #1454276\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d3b8606ed29473b38d3d41499364b7b7b4d75aeb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d3b8606ed29473b38d3d41499364b7b7b4d75aeb"}]},"branch":"refs/heads/master"},"9cd42ef3ee5e8b386cb6e1941b39608ed216a04f":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-06-08 16:37:19.000000000","uploader":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"ref":"refs/changes/44/182344/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/44/182344/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/44/182344/3"}}},"commit":{"parents":[{"commit":"4f7bb8f3d73c00c68e4daf7d8f7cb08e8a2d6db1","subject":"Merge \"Add findall server side filtering\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4f7bb8f3d73c00c68e4daf7d8f7cb08e8a2d6db1"}]}],"author":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-05-12 14:42:10.000000000","tz":180},"committer":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-06-08 16:25:01.000000000","tz":180},"subject":"Fix condition in CheckSizeArgForCreate parser action","message":"Fix condition in CheckSizeArgForCreate parser action\n\nCheckSizeArgForCreate checks that size is specified when snapshot\nor source volume aren\u0027t. But when size is 0, CheckSizeArgForCreate\naction works wrong and generates error: \u0027Size is a required\nparameter if snapshot or source volume is not specified\u0027, meanwhile\nuser expected to see: \u0027Volume size \u00270\u0027 must be greater than 0\u0027.\n\nChange-Id: I164970a600d6e86bd7076dd485f676a703f5e487\nCloses-Bug: #1454276\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9cd42ef3ee5e8b386cb6e1941b39608ed216a04f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/9cd42ef3ee5e8b386cb6e1941b39608ed216a04f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}