)]}'
{"cinderclient/v2/shell.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"7d42489ed2379a44e5975fa7e2cf0b2e52c99334","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            utils.find_volume(cs, volume).force_detach()"},{"line_number":456,"context_line":"        except Exception as e:"},{"line_number":457,"context_line":"            msg \u003d \"force_detach for volume %s failed: %s\" % (volume, e)"},{"line_number":458,"context_line":"            print(msg)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"@utils.arg(\u0027volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027, nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_72b00344","line":458,"updated":"2015-07-21 11:35:28.000000000","message":"We need a test to verify that the error case here gets handled properly.","commit_id":"577032fe90b35792f84fdfc7e43d6ed1064056d0"}],"cinderclient/v2/volumes.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"737ce9d10295dfe74340628741759d5dab511d6b","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def force_detach(self):"},{"line_number":64,"context_line":"        \"\"\"Clear attachment metadata.\"\"\""},{"line_number":65,"context_line":"        return self.manager.force_detach(self)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def reserve(self, volume):"},{"line_number":68,"context_line":"        \"\"\"Reserve this volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_443f7e87","line":65,"updated":"2015-06-26 12:05:38.000000000","message":"This method will be overridden by the force_detach method defined below. It should probably be removed or its name changed.","commit_id":"a3ca8b23b68ab1aa9d22f59b1fb2f9359abb6381"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"b1be7f48ea33934d99f6cedc910946d8769cd75f","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def force_detach(self):"},{"line_number":64,"context_line":"        \"\"\"Clear attachment metadata.\"\"\""},{"line_number":65,"context_line":"        return self.manager.force_detach(self)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def reserve(self, volume):"},{"line_number":68,"context_line":"        \"\"\"Reserve this volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_54e634b5","line":65,"in_reply_to":"fa32b979_443f7e87","updated":"2015-07-20 22:06:39.000000000","message":"You are right.","commit_id":"a3ca8b23b68ab1aa9d22f59b1fb2f9359abb6381"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"737ce9d10295dfe74340628741759d5dab511d6b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def force_detach(self):"},{"line_number":119,"context_line":"        \"\"\"Detach the specified volume ignoring its current state."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param volume: The UUID of the volume to force-detach."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        self.manager.force_detach(self)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_c48e2e79","line":121,"updated":"2015-06-26 12:05:38.000000000","message":"There\u0027s no volume parameter defined for this method.","commit_id":"a3ca8b23b68ab1aa9d22f59b1fb2f9359abb6381"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"b1be7f48ea33934d99f6cedc910946d8769cd75f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def force_detach(self):"},{"line_number":119,"context_line":"        \"\"\"Detach the specified volume ignoring its current state."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param volume: The UUID of the volume to force-detach."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        self.manager.force_detach(self)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_34f28870","line":121,"in_reply_to":"fa32b979_c48e2e79","updated":"2015-07-20 22:06:39.000000000","message":"right. Docstring is incorrect and should go.","commit_id":"a3ca8b23b68ab1aa9d22f59b1fb2f9359abb6381"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"737ce9d10295dfe74340628741759d5dab511d6b","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param volume: The UUID of the volume to force-detach."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        self.manager.force_detach(self)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def reset_state(self, state):"},{"line_number":126,"context_line":"        \"\"\"Update the volume with the provided state.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_241cba12","line":123,"updated":"2015-06-26 12:05:38.000000000","message":"If volume is supposed to be used, it\u0027ll need to get passed to the force_detach call here.","commit_id":"a3ca8b23b68ab1aa9d22f59b1fb2f9359abb6381"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"b1be7f48ea33934d99f6cedc910946d8769cd75f","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param volume: The UUID of the volume to force-detach."},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        self.manager.force_detach(self)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def reset_state(self, state):"},{"line_number":126,"context_line":"        \"\"\"Update the volume with the provided state.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_d4e8047f","line":123,"in_reply_to":"fa32b979_241cba12","updated":"2015-07-20 22:06:39.000000000","message":"self is the volume.\nSee L#35-38::\nclass Volume(base.Resource):\n    \"\"\"A volume is an extra block level storage to the OpenStack instances.\"\"\"\n    def __repr__(self):\n        return \"\u003cVolume: %s\u003e\" % self.id","commit_id":"a3ca8b23b68ab1aa9d22f59b1fb2f9359abb6381"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"737ce9d10295dfe74340628741759d5dab511d6b","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \"\"\"Clear attachment metadata."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        :param volume: The :class:`Volume` (or its ID)"},{"line_number":424,"context_line":"                       you would like to force detach."},{"line_number":425,"context_line":"        \"\"\""},{"line_number":426,"context_line":"        return self._action(\u0027os-force_detach\u0027, volume,"},{"line_number":427,"context_line":"                            {\u0027attachment_id\u0027: attachment_uuid})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_04717677","line":424,"updated":"2015-06-26 12:05:38.000000000","message":"Please also add a :param: line for attachment_uuid.","commit_id":"a3ca8b23b68ab1aa9d22f59b1fb2f9359abb6381"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"b1be7f48ea33934d99f6cedc910946d8769cd75f","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \"\"\"Clear attachment metadata."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        :param volume: The :class:`Volume` (or its ID)"},{"line_number":424,"context_line":"                       you would like to force detach."},{"line_number":425,"context_line":"        \"\"\""},{"line_number":426,"context_line":"        return self._action(\u0027os-force_detach\u0027, volume,"},{"line_number":427,"context_line":"                            {\u0027attachment_id\u0027: attachment_uuid})"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_d4448475","line":424,"in_reply_to":"fa32b979_04717677","updated":"2015-07-20 22:06:39.000000000","message":"Done","commit_id":"a3ca8b23b68ab1aa9d22f59b1fb2f9359abb6381"}]}
