)]}'
{"id":"openstack%2Fpython-cinderclient~191621","triplet_id":"openstack%2Fpython-cinderclient~master~I5c9a693711db2918abbd3bbfae53e48162a01c3c","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1462104","hashtags":[],"change_id":"I5c9a693711db2918abbd3bbfae53e48162a01c3c","subject":"The is_public filter in VolumeTypeManager.list broke the find in VolumeTypeAccessManager, which caused all commands which should have taken a volume_type name to fail.  I have choosen to fix this by effectively removing the filter in the client (and the --all argument to type-list). This is OK, since Cinder implements the filtering by user anyway.  The consequence of this change is that the Admin user will always see the entire list (including private types) every time they execute type-list","status":"MERGED","created":"2015-06-15 03:41:25.000000000","updated":"2015-06-16 19:06:53.000000000","submitted":"2015-06-16 19:06:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9c04c3cb36548837bbbac177ae8edb5098d8535b","_number":191621,"virtual_id_number":191621,"owner":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2015-06-16 19:06:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"recommended":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"all":[{"value":1,"date":"2015-06-16 09:04:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":2,"date":"2015-06-15 21:38:43.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-06-16 18:06:16.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":1,"date":"2015-06-16 00:06:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"all":[{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-06-16 18:06:16.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-15 21:38:43.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2015-06-16 00:06:30.000000000","updated_by":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"reviewer":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"state":"REVIEWER"},{"updated":"2015-06-16 09:04:19.000000000","updated_by":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"reviewer":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"state":"REVIEWER"},{"updated":"2015-06-16 18:06:16.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2015-06-16 19:06:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b44ca408c3a4ba1519f4fca87c8096cb4d15c5ee","author":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"date":"2015-06-15 03:41:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fd6b44a6bd4a4e529a8bbeb4f9755c48307ecf63","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-15 04:36:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/21/191621/1/check/gate-python-cinderclient-python26/5e75108/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/21/191621/1/check/gate-python-cinderclient-pep8/c37245f/ : SUCCESS in 1m 01s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/21/191621/1/check/gate-python-cinderclient-docs/53e0b86//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-cinderclient-python27 http://logs.openstack.org/21/191621/1/check/gate-python-cinderclient-python27/9ba61f1/ : SUCCESS in 1m 02s\n- gate-python-cinderclient-python34 http://logs.openstack.org/21/191621/1/check/gate-python-cinderclient-python34/e9c2b66/ : SUCCESS in 1m 30s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/21/191621/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/4ce04b9/ : SUCCESS in 55m 24s\n- gate-python-cinderclient-pypy http://logs.openstack.org/21/191621/1/check/gate-python-cinderclient-pypy/85440b6/ : SUCCESS in 1m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f3906795546b0157ce054e93dcf7e6b7b4ed1eeb","author":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"date":"2015-06-15 14:06:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a8efe8519edbfabbe4638797cde1d8d4569f2206","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-15 15:00:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/21/191621/2/check/gate-python-cinderclient-python26/cd18ba5/ : SUCCESS in 1m 07s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/21/191621/2/check/gate-python-cinderclient-pep8/c7c65c5/ : SUCCESS in 1m 01s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/21/191621/2/check/gate-python-cinderclient-docs/8c1db81//doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-cinderclient-python27 http://logs.openstack.org/21/191621/2/check/gate-python-cinderclient-python27/f6d80fd/ : SUCCESS in 1m 31s\n- gate-python-cinderclient-python34 http://logs.openstack.org/21/191621/2/check/gate-python-cinderclient-python34/88edeaf/ : SUCCESS in 1m 38s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/21/191621/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/70171a8/ : SUCCESS in 45m 45s\n- gate-python-cinderclient-pypy http://logs.openstack.org/21/191621/2/check/gate-python-cinderclient-pypy/9105fc4/ : SUCCESS in 1m 33s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"49345f4a57440ff241b0eb23021082f7ca162d2d","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-06-15 21:38:43.000000000","message":"Patch Set 2: Code-Review+2\n\nSo in my opinion I prefer this, frankly the --all is kind of a silly option to have.  We should be consistent with things like image-list where you by default get everything that\u0027s \"yours\" or \"public\".\n\nAlso, given the fact that this does nothing if you\u0027re not Admin anyway, doesn\u0027t really make a ton of sense.\n\nIf there\u0027s a concern about back compat etc, I\u0027d recommend keeping the option, but listing a deprecation warning and just have it \"do nothing\".  But like I said, I\u0027m not really a fan of the option anyway.","accounts_in_message":[],"_revision_number":2},{"id":"152afcd917e4debf7f7d0f6698c234051e4ae86f","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2015-06-16 00:06:30.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks ok to me","accounts_in_message":[],"_revision_number":2},{"id":"cc99cecf2c95fe4ce19165e2eff55e4814979e52","author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"date":"2015-06-16 09:04:19.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b726c869b91eeaebf1032da3ef8cd9aa0308287a","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2015-06-16 18:06:16.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e6daf1efde8405d67b26b7823237f465ea5cfa32","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-16 18:06:22.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ffb240a24d2f1493cad6bbe1a2675c6465476811","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-16 19:06:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/21/191621/2/gate/gate-python-cinderclient-python26/c420747/ : SUCCESS in 1m 14s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/21/191621/2/gate/gate-python-cinderclient-docs/8ffb90a//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/21/191621/2/gate/gate-python-cinderclient-pep8/0fd1019/ : SUCCESS in 1m 01s\n- gate-python-cinderclient-python27 http://logs.openstack.org/21/191621/2/gate/gate-python-cinderclient-python27/0046992/ : SUCCESS in 1m 15s\n- gate-python-cinderclient-python34 http://logs.openstack.org/21/191621/2/gate/gate-python-cinderclient-python34/a0de25d/ : SUCCESS in 2m 03s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/21/191621/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/d67dfbc/ : SUCCESS in 58m 28s\n- gate-python-cinderclient-pypy http://logs.openstack.org/21/191621/2/gate/gate-python-cinderclient-pypy/5d7d162/ : SUCCESS in 1m 55s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"14c7c578609abf4b841692403c182fab7919e05a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-16 19:06:53.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"289ab37c790b8848e78582926c336628ca51ca6d","revisions":{"24733b53c981dfbe116921b4443e22c479087ef2":{"kind":"REWORK","_number":1,"created":"2015-06-15 03:41:25.000000000","uploader":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"ref":"refs/changes/21/191621/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/21/191621/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/21/191621/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/21/191621/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/21/191621/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/21/191621/1"}}},"commit":{"parents":[{"commit":"91bf760989a6c992918d6eadb038d7265ea18287","subject":"Merge \"Prep for 1.2.2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/91bf760989a6c992918d6eadb038d7265ea18287"}]}],"author":{"name":"Ed Balduf","email":"balduf@ieee.org","date":"2015-06-15 03:11:03.000000000","tz":-360},"committer":{"name":"Ed Balduf","email":"balduf@ieee.org","date":"2015-06-15 03:11:03.000000000","tz":-360},"subject":"The is_public filter in VolumeTypeManager.list broke the find in VolumeTypeAccessManager, which caused all commands which should have taken a volume_type name to fail.  I have choosen to fix this by effectively removing the filter in the client (and the --all argument to type-list). This is OK, since Cinder implements the filtering by user anyway.  The consequence of this change is that the Admin user will always see the entire list (including private types) every time they execute type-list","message":"The is_public filter in VolumeTypeManager.list broke the find in\nVolumeTypeAccessManager, which caused all commands which should have taken\na volume_type name to fail.  I have choosen to fix this by effectively\nremoving the filter in the client (and the --all argument to type-list).\nThis is OK, since Cinder implements the filtering by user anyway.  The\nconsequence of this change is that the Admin user will always see the\nentire list (including private types) every time they execute type-list\n\nChange-Id: I5c9a693711db2918abbd3bbfae53e48162a01c3c\nCloses-Bug: #1462104\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/24733b53c981dfbe116921b4443e22c479087ef2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/24733b53c981dfbe116921b4443e22c479087ef2"}]},"branch":"refs/heads/master"},"289ab37c790b8848e78582926c336628ca51ca6d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-06-15 14:06:43.000000000","uploader":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"ref":"refs/changes/21/191621/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/21/191621/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/21/191621/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/21/191621/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/21/191621/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/21/191621/2"}}},"commit":{"parents":[{"commit":"91bf760989a6c992918d6eadb038d7265ea18287","subject":"Merge \"Prep for 1.2.2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/91bf760989a6c992918d6eadb038d7265ea18287"}]}],"author":{"name":"Ed Balduf","email":"balduf@ieee.org","date":"2015-06-15 03:11:03.000000000","tz":-360},"committer":{"name":"Ed Balduf","email":"balduf@ieee.org","date":"2015-06-15 14:06:45.000000000","tz":-360},"subject":"The is_public filter in VolumeTypeManager.list broke the find in VolumeTypeAccessManager, which caused all commands which should have taken a volume_type name to fail.  I have choosen to fix this by effectively removing the filter in the client (and the --all argument to type-list). This is OK, since Cinder implements the filtering by user anyway.  The consequence of this change is that the Admin user will always see the entire list (including private types) every time they execute type-list","message":"The is_public filter in VolumeTypeManager.list broke the find in\nVolumeTypeAccessManager, which caused all commands which should have taken\na volume_type name to fail.  I have choosen to fix this by effectively\nremoving the filter in the client (and the --all argument to type-list).\nThis is OK, since Cinder implements the filtering by user anyway.  The\nconsequence of this change is that the Admin user will always see the\nentire list (including private types) every time they execute type-list\n\nChange-Id: I5c9a693711db2918abbd3bbfae53e48162a01c3c\nCloses-Bug: 1462104\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/289ab37c790b8848e78582926c336628ca51ca6d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/289ab37c790b8848e78582926c336628ca51ca6d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}