)]}'
{"id":"openstack%2Fpython-cinderclient~199595","triplet_id":"openstack%2Fpython-cinderclient~master~Ifabb4a2aec070c00349e794364a71394feea99f1","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1472636","hashtags":[],"change_id":"Ifabb4a2aec070c00349e794364a71394feea99f1","subject":"Remove unnecessary check for tenant information","status":"MERGED","created":"2015-07-08 14:45:48.000000000","updated":"2015-07-21 16:19:25.000000000","submitted":"2015-07-20 13:05:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8e273e510d8e5da5bc888f9080fb3c6bd3e5142f","_number":199595,"virtual_id_number":199595,"owner":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-07-08 19:25:43.000000000","_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":2,"date":"2015-07-20 13:05:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":9188,"name":"Liang Bo","email":"liang.bo@99cloud.net","username":"LiangBo"},{"value":0,"date":"2015-07-10 13:27:14.000000000","_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"date":"2015-07-08 18:59:44.000000000","_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":2,"date":"2015-07-12 17:42:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2015-07-09 09:50:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-07-09 08:18:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":1,"date":"2015-07-10 14:22:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9188,"name":"Liang Bo","email":"liang.bo@99cloud.net","username":"LiangBo"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":1,"date":"2015-07-08 19:57:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":1,"date":"2015-07-09 08:07:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"value":1,"date":"2015-07-20 11:30:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":1,"date":"2015-07-14 00:13:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":2,"date":"2015-07-20 12:03:50.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2015-07-09 09:49:59.000000000","_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":9188,"name":"Liang Bo","email":"liang.bo@99cloud.net","username":"LiangBo"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},{"value":0,"date":"2015-07-10 13:29:40.000000000","_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":1,"date":"2015-07-20 12:03:50.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":9188,"name":"Liang Bo","email":"liang.bo@99cloud.net","username":"LiangBo"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":9188,"name":"Liang Bo","email":"liang.bo@99cloud.net","username":"LiangBo"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-08 14:48:13.000000000","updated_by":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"reviewer":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"state":"REVIEWER"},{"updated":"2015-07-08 14:48:23.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2015-07-08 18:59:44.000000000","updated_by":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"reviewer":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"state":"REVIEWER"},{"updated":"2015-07-09 08:07:47.000000000","updated_by":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"reviewer":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"state":"REVIEWER"},{"updated":"2015-07-09 08:18:55.000000000","updated_by":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"reviewer":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"state":"REVIEWER"},{"updated":"2015-07-09 09:49:59.000000000","updated_by":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"reviewer":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"state":"REVIEWER"},{"updated":"2015-07-10 13:27:14.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-07-10 13:29:40.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2015-07-10 14:22:41.000000000","updated_by":{"_account_id":9188,"name":"Liang Bo","email":"liang.bo@99cloud.net","username":"LiangBo"},"reviewer":{"_account_id":9188,"name":"Liang Bo","email":"liang.bo@99cloud.net","username":"LiangBo"},"state":"REVIEWER"},{"updated":"2015-07-12 17:42:31.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2015-07-14 00:13:53.000000000","updated_by":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"reviewer":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"state":"REVIEWER"},{"updated":"2015-07-20 11:30:47.000000000","updated_by":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"reviewer":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"state":"REVIEWER"},{"updated":"2015-07-20 12:03:50.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2015-07-20 13:05:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e4dc120f2729e13848092a3caf501f14d2401036","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-08 14:45:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8ff3dcc3b6988f0b9e555f2c98bbf43959b6fe5b","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2015-07-08 14:47:54.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks like the correct fix, and the dupe check needed cleaning up anyway. Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"b23800054d067a1cb1876937080ba158ad37c86d","author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"date":"2015-07-08 15:04:39.000000000","message":"Patch Set 1: Code-Review-1\n\nJust tested this, when I do a random \u0027cinder list\u0027 for example I get:\n\nERROR: \u0027Namespace\u0027 object has no attribute \u0027project_domain_name\u0027\n\nShould references to self.options.project_domain_name and self.options.project_domain_id be replaced with self.options.os_project_domain_name and self.options.os_project_domain_id?","accounts_in_message":[],"_revision_number":1},{"id":"7f0b230a6fef4847c1baf8103f73842bada87824","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-08 15:51:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/95/199595/1/check/gate-python-cinderclient-python26/9a00f88/ : SUCCESS in 1m 15s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/95/199595/1/check/gate-python-cinderclient-pep8/e0f4fd7/ : FAILURE in 2m 46s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/95/199595/1/check/gate-python-cinderclient-docs/7cf1cad//doc/build/html/ : SUCCESS in 2m 28s\n- gate-python-cinderclient-python27 http://logs.openstack.org/95/199595/1/check/gate-python-cinderclient-python27/8721fa1/ : SUCCESS in 2m 42s\n- gate-python-cinderclient-python34 http://logs.openstack.org/95/199595/1/check/gate-python-cinderclient-python34/ef2abdf/ : SUCCESS in 2m 58s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/95/199595/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/7742bc3/ : SUCCESS in 1h 00m 49s\n- gate-python-cinderclient-pypy http://logs.openstack.org/95/199595/1/check/gate-python-cinderclient-pypy/bdf2205/ : SUCCESS in 3m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e6d6ffd2d2ff53bac76826d415c549ed08d20ae5","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-08 16:48:46.000000000","message":"Patch Set 1:\n\nGood catch Matt. I think you\u0027re correct. I\u0027m going to talk to the other hacking cores about H701. Until then, I\u0027m going to just copy \u0026 paste that error string around","accounts_in_message":[],"_revision_number":1},{"id":"b0dab20e174ae73af41be732eb5cdba98781f32f","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-08 16:48:51.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"e4cb1105bc89e6b7e71798fd16c937d387b356ee","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-08 17:12:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8f7e7938814309eb21409c42fdce6d2d2cf30c70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-08 18:08:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/95/199595/2/check/gate-python-cinderclient-python26/9b77c84/ : SUCCESS in 1m 09s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/95/199595/2/check/gate-python-cinderclient-pep8/e55fbda/ : SUCCESS in 1m 12s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/95/199595/2/check/gate-python-cinderclient-docs/50144c7//doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-cinderclient-python27 http://logs.openstack.org/95/199595/2/check/gate-python-cinderclient-python27/bfcbaee/ : SUCCESS in 1m 17s\n- gate-python-cinderclient-python34 http://logs.openstack.org/95/199595/2/check/gate-python-cinderclient-python34/f04daf4/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/95/199595/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/8ecfc8c/ : SUCCESS in 54m 01s\n- gate-python-cinderclient-pypy http://logs.openstack.org/95/199595/2/check/gate-python-cinderclient-pypy/a7d3b5e/ : SUCCESS in 1m 52s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"40cbaf7153eb038c12e66a9370a6dffddbf2cfd3","author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"date":"2015-07-08 18:59:44.000000000","message":"Patch Set 2:\n\nI think you could have done the translation when you created the variable:\n\n    project_info_required \u003d _(\u0027.....\u0027)\n\nand then skipped using the translation when you used it:\n\n    raise exc.CommandError(project_info_required)\n\nThe H701 is raised when the _() is used without a string because the translatable string is programatically gathered from the code by matching the _() and extracting the string.","accounts_in_message":[],"_revision_number":2},{"id":"4b31951aff423016f72b0be9239f5fc062862771","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-08 19:25:43.000000000","message":"Patch Set 2:\n\nJames, I wanted to avoid using the translations if they are being eagerly translated. Assigning a string is very fast meanwhile the translations might not be. The string shouldn\u0027t change very much so either way it shouldn\u0027t matter.\n\nIf we decide we want to always translate that in case there\u0027s an error, I\u0027ll be happy to update this with that.","accounts_in_message":[],"_revision_number":2},{"id":"50393036aa90d9de91eb3bdf48264b9fdf23f0d1","author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"date":"2015-07-08 19:57:44.000000000","message":"Patch Set 2: Code-Review+1\n\nIan, that makes sense.","accounts_in_message":[],"_revision_number":2},{"id":"6e62b25fc803ff86dee70a732a383635c2a60ebb","author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"date":"2015-07-09 08:07:47.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ddabe53060bee340d305c8e9f52551a6dc7bb892","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-07-09 08:18:55.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e657efd4a76d1650661c622ed773c1b1eee8331b","author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"date":"2015-07-09 09:50:07.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"5096573cb528fb4d2b8510e152fb3c08d79d0749","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-07-10 13:27:14.000000000","message":"Patch Set 2:\n\ncheck experimental","accounts_in_message":[],"_revision_number":2},{"id":"0775f4ea9426f6facfb0e4943da55fb297c263a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-10 14:13:38.000000000","message":"Patch Set 2:\n\nBuild succeeded (experimental pipeline).\n\n- check-cinderclient-dsvm-functional http://logs.openstack.org/95/199595/2/experimental/check-cinderclient-dsvm-functional/ba68627/ : SUCCESS in 25m 46s","accounts_in_message":[],"_revision_number":2},{"id":"e6f3d61a69ec924b9659fec5fe76c81c65e86073","author":{"_account_id":9188,"name":"Liang Bo","email":"liang.bo@99cloud.net","username":"LiangBo"},"date":"2015-07-10 14:22:41.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e7ea1519f28a74ef0bcc4cce54ec437e930b8657","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-10 17:36:30.000000000","message":"Patch Set 2:\n\nBuild failed (experimental-tripleo).\n\n- check-tripleo-ironic-undercloud-precise-nonha http://logs.openstack.org/95/199595/2/experimental-tripleo/check-tripleo-ironic-undercloud-precise-nonha/9d44bf6/ : FAILURE in 2h 55m 12s\n- check-tripleo-ironic-overcloud-precise-nonha http://logs.openstack.org/95/199595/2/experimental-tripleo/check-tripleo-ironic-overcloud-precise-nonha/bbdfd35/ : FAILURE in 2h 55m 12s\n- check-tripleo-ironic-overcloud-f21-nonha http://logs.openstack.org/95/199595/2/experimental-tripleo/check-tripleo-ironic-overcloud-f21-nonha/fc38552/ : SUCCESS in 1h 37m 11s","accounts_in_message":[],"_revision_number":2},{"id":"98fa6a3d598988af42795dd7e5334e8c18cec98d","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-07-12 17:42:31.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"bbc56b20830b56a8eaa6e8a9a516556dd6c19a1b","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2015-07-14 00:13:53.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"60aa9d0b7a56ac641185274baef74adcc0000396","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-07-14 20:23:39.000000000","message":"Patch Set 2:\n\ncheck experimental","accounts_in_message":[],"_revision_number":2},{"id":"900c6c9f84768eb27078542b7d6e178135001c7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-14 20:40:47.000000000","message":"Patch Set 2:\n\nBuild failed (experimental-tripleo).\n\n- check-tripleo-ironic-undercloud-precise-nonha http://logs.openstack.org/95/199595/2/experimental-tripleo/check-tripleo-ironic-undercloud-precise-nonha/96c4bdd/ : FAILURE in 14m 14s\n- check-tripleo-ironic-overcloud-precise-nonha http://logs.openstack.org/95/199595/2/experimental-tripleo/check-tripleo-ironic-overcloud-precise-nonha/92bea60/ : FAILURE in 8m 58s\n- check-tripleo-ironic-overcloud-f21-nonha http://logs.openstack.org/95/199595/2/experimental-tripleo/check-tripleo-ironic-overcloud-f21-nonha/3aa38ff/ : FAILURE in 8m 24s","accounts_in_message":[],"_revision_number":2},{"id":"bd400843ec481a48467a2e7907bc9849de88c5f5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-14 20:42:10.000000000","message":"Patch Set 2:\n\nBuild failed (experimental pipeline).\n\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/95/199595/2/experimental/gate-cinderclient-dsvm-functional/0951f33/ : NOT_REGISTERED","accounts_in_message":[],"_revision_number":2},{"id":"4c6f684a86e1f7b97c886cbee3e602118c369e22","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-15 14:39:03.000000000","message":"Patch Set 2:\n\nIvan, are those checks due to Ironic problems or this patch? I\u0027m not familiar with those checks.","accounts_in_message":[],"_revision_number":2},{"id":"6065407a8b858579cde37b450cbf5cb8e2a88dd1","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2015-07-20 11:30:47.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d771b6616448647b52a05c13d0f4825a34d1373d","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2015-07-20 12:03:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"0e3f19e78fc51aa61e58529a274c4b11194bacc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-20 12:03:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"f5302deafeeac1a2bc33bcf73c28314580db4c37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-20 13:05:40.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/95/199595/2/gate/gate-python-cinderclient-python26/d208e91/ : SUCCESS in 1m 25s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/95/199595/2/gate/gate-python-cinderclient-docs/b61ec3c//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/95/199595/2/gate/gate-python-cinderclient-pep8/fa06a59/ : SUCCESS in 1m 04s\n- gate-python-cinderclient-python27 http://logs.openstack.org/95/199595/2/gate/gate-python-cinderclient-python27/2ea5fdf/ : SUCCESS in 1m 26s\n- gate-python-cinderclient-python34 http://logs.openstack.org/95/199595/2/gate/gate-python-cinderclient-python34/b17c873/ : SUCCESS in 1m 22s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/95/199595/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/702aa01/ : SUCCESS in 1h 01m 24s\n- gate-python-cinderclient-pypy http://logs.openstack.org/95/199595/2/gate/gate-python-cinderclient-pypy/86eee6b/ : SUCCESS in 2m 01s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7db3c754b819be95ac71bdf60a4ba4ad10d0c781","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-20 13:05:42.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"f8e2d111678e3c98c436788bb0a7840c80e65b48","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-21 16:19:25.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/kilo as commit b2e2150e2d786c9cfcc838995a042f710d3459d5","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8afc06c562ac8c189fae6ded7cc50f1b579f06c4","revisions":{"50f63bf3a196c3e73dbc046e0629bbd0ba4c391c":{"kind":"REWORK","_number":1,"created":"2015-07-08 14:45:48.000000000","uploader":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"ref":"refs/changes/95/199595/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/95/199595/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/95/199595/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/95/199595/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/95/199595/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/95/199595/1"}}},"commit":{"parents":[{"commit":"f860668d7146bc5cd1b9914ea15ad5d6f0dd9585","subject":"Merge \"Fix outdated URLs and some minor fixes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/f860668d7146bc5cd1b9914ea15ad5d6f0dd9585"}]}],"author":{"name":"Ian Cordasco","email":"graffatcolmingov@gmail.com","date":"2015-07-08 14:37:07.000000000","tz":-300},"committer":{"name":"Ian Cordasco","email":"graffatcolmingov@gmail.com","date":"2015-07-08 14:44:13.000000000","tz":-300},"subject":"Remove unnecessary check for tenant information","message":"Remove unnecessary check for tenant information\n\nKeystone v3 has changed the name of tenants to projects which means that\nOS_TENANT_NAME is meaningless in a cloud where v3 is the default\nauthentication version. As such, if a user does not have OS_TENANT_NAME\nenabled, cinderclient will not work even though it has checks for v3\nimmediately below this check (and the same check replicated further\nbelow that). Removing this allows cinderclient to work with Keystone v3\nwithout setting OS_TENANT_NAME unnecessarily.\n\nCloses-bug: 1472636\nChange-Id: Ifabb4a2aec070c00349e794364a71394feea99f1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/50f63bf3a196c3e73dbc046e0629bbd0ba4c391c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/50f63bf3a196c3e73dbc046e0629bbd0ba4c391c"}]},"branch":"refs/heads/master"},"8afc06c562ac8c189fae6ded7cc50f1b579f06c4":{"kind":"REWORK","_number":2,"created":"2015-07-08 17:12:17.000000000","uploader":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"ref":"refs/changes/95/199595/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/95/199595/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/95/199595/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/95/199595/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/95/199595/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/95/199595/2"}}},"commit":{"parents":[{"commit":"f860668d7146bc5cd1b9914ea15ad5d6f0dd9585","subject":"Merge \"Fix outdated URLs and some minor fixes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/f860668d7146bc5cd1b9914ea15ad5d6f0dd9585"}]}],"author":{"name":"Ian Cordasco","email":"graffatcolmingov@gmail.com","date":"2015-07-08 14:37:07.000000000","tz":-300},"committer":{"name":"Ian Cordasco","email":"graffatcolmingov@gmail.com","date":"2015-07-08 17:11:07.000000000","tz":-300},"subject":"Remove unnecessary check for tenant information","message":"Remove unnecessary check for tenant information\n\nKeystone v3 has changed the name of tenants to projects which means that\nOS_TENANT_NAME is meaningless in a cloud where v3 is the default\nauthentication version. As such, if a user does not have OS_TENANT_NAME\nenabled, cinderclient will not work even though it has checks for v3\nimmediately below this check (and the same check replicated further\nbelow that). Removing this allows cinderclient to work with Keystone v3\nwithout setting OS_TENANT_NAME unnecessarily.\n\nFurther, the check for project information was incorrectly referring to\nproject_domain_name and project_domain_id instead of\nos_project_domain_name and os_project_domain_id.\n\nCloses-bug: 1472636\nChange-Id: Ifabb4a2aec070c00349e794364a71394feea99f1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8afc06c562ac8c189fae6ded7cc50f1b579f06c4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8afc06c562ac8c189fae6ded7cc50f1b579f06c4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}