)]}'
{"id":"openstack%2Fpython-cinderclient~204232","triplet_id":"openstack%2Fpython-cinderclient~master~I53aff3973cc6365a5b1d40c21b0885c1d8166df5","project":"openstack/python-cinderclient","branch":"master","topic":"bp/non-disruptive-backup","hashtags":[],"change_id":"I53aff3973cc6365a5b1d40c21b0885c1d8166df5","subject":"CLI: Non-disruptive backup","status":"MERGED","created":"2015-07-21 20:00:14.000000000","updated":"2015-08-29 01:05:08.000000000","submitted":"2015-08-29 01:05:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e1156adb8829c4adda3adcfa672c68d056ee4919","_number":204232,"virtual_id_number":204232,"owner":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-08-29 01:05:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"date":"2015-08-19 18:34:55.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"recommended":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-08-24 12:35:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":2,"date":"2015-08-21 13:36:29.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":1,"date":"2015-08-28 23:34:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},{"value":2,"date":"2015-08-28 23:48:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},{"value":1,"date":"2015-08-28 23:48:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-18 13:50:16.000000000","updated_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"reviewer":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"state":"REVIEWER"},{"updated":"2015-08-18 18:02:04.000000000","updated_by":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"reviewer":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"state":"REVIEWER"},{"updated":"2015-08-18 22:04:23.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2015-08-18 22:34:23.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2015-08-21 13:36:29.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2015-08-24 12:35:40.000000000","updated_by":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"reviewer":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"state":"REVIEWER"},{"updated":"2015-08-28 23:34:25.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2015-08-28 23:48:30.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2015-08-29 01:05:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a105da594bc949a51d5dcdcb2b7f3fb338232901","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-07-21 20:00:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c3603119a138b08fbccd238aedebc5f94b85eccf","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2015-07-21 21:40:23.000000000","message":"Patch Set 1: Code-Review-1\n\nDon\u0027t we need unit tests with force-flag True and with force-flag False?","accounts_in_message":[],"_revision_number":1},{"id":"35c6f0a0bf80a1038842c18e5327fe4d5513d5fd","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-07-21 23:36:42.000000000","message":"Patch Set 1:\n\nHi Tom,\n\nYes, I need to add unit tests. I just want to submit it before I forget about it and overwrite it with something else:). Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"c249187d9e5cfb18a69ae965d4b6f983fcb5ec09","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-21 23:37:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/32/204232/1/check/gate-python-cinderclient-python26/26a0456/ : SUCCESS in 1m 14s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/32/204232/1/check/gate-python-cinderclient-pep8/9c74b30/ : FAILURE in 1m 11s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/32/204232/1/check/gate-python-cinderclient-docs/0b9c918//doc/build/html/ : SUCCESS in 51s\n- gate-python-cinderclient-python27 http://logs.openstack.org/32/204232/1/check/gate-python-cinderclient-python27/66209a5/ : SUCCESS in 2m 29s\n- gate-python-cinderclient-python34 http://logs.openstack.org/32/204232/1/check/gate-python-cinderclient-python34/6fcd9b7/ : SUCCESS in 1m 22s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/32/204232/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/6cd55b4/ : SUCCESS in 1h 04m 22s\n- gate-python-cinderclient-pypy http://logs.openstack.org/32/204232/1/check/gate-python-cinderclient-pypy/a0121fd/ : SUCCESS in 1m 38s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/32/204232/1/check/gate-cinderclient-dsvm-functional/e49b701/ : SUCCESS in 26m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6f211b43ee29f3ac7eb86fe4db446007892f0966","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2015-07-21 23:39:01.000000000","message":"Patch Set 1:\n\nThat makes sense :-)","accounts_in_message":[],"_revision_number":1},{"id":"8db26ba5cbddf062cc01a71b3d2297f50763cf87","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2015-07-31 14:52:08.000000000","message":"Patch Set 1: Code-Review-1\n\nI agree with Tom, once tests are added this will be good to go.","accounts_in_message":[],"_revision_number":1},{"id":"08132d18663ce7bdc3025f4b02a2d4d938ffa64a","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-11 16:06:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"df15a23d6045a099b17440f3aaa144a2c4698a23","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-11 16:06:55.000000000","message":"Patch Set 2:\n\nAdded unit tests.  Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"33159b2c025a74bcfe7137c128b366d9cae3bcef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-11 17:35:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/32/204232/2/check/gate-python-cinderclient-python26/8454633/ : SUCCESS in 1m 17s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/32/204232/2/check/gate-python-cinderclient-pep8/a1067cb/ : SUCCESS in 31s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/32/204232/2/check/gate-python-cinderclient-docs/0e039a5//doc/build/html/ : SUCCESS in 51s\n- gate-python-cinderclient-python27 http://logs.openstack.org/32/204232/2/check/gate-python-cinderclient-python27/61dc464/ : SUCCESS in 1m 18s\n- gate-python-cinderclient-python34 http://logs.openstack.org/32/204232/2/check/gate-python-cinderclient-python34/4b3f565/ : SUCCESS in 1m 01s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/32/204232/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/18b86b3/ : SUCCESS in 56m 48s\n- gate-python-cinderclient-pypy http://logs.openstack.org/32/204232/2/check/gate-python-cinderclient-pypy/340e35d/ : SUCCESS in 1m 22s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/32/204232/2/check/gate-cinderclient-dsvm-functional/60da408/ : SUCCESS in 21m 00s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"caad4a326e7fc76c9e4a64f74cd175b0cd302b27","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2015-08-12 14:49:38.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8093ade044598a5d9f5267cb1711b3ac865b6132","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2015-08-12 14:56:15.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6b547fb6fb1e6371d1133ac328d9197984f4918b","author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"date":"2015-08-18 13:50:16.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks good to me. Thank you for working on this!","accounts_in_message":[],"_revision_number":2},{"id":"672117bc38ce6418d55eaf3e380940d26608888f","author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"date":"2015-08-18 18:02:04.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks good to me. Good work!","accounts_in_message":[],"_revision_number":2},{"id":"2c562b1dd2d3ed8b2ad75c57e8fced793ba775ee","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2015-08-18 22:04:23.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"1c507fb8f9f6f1215b4986ca479718f80b977c14","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2015-08-18 22:34:23.000000000","message":"Patch Set 2: Code-Review-1\n\nApologies for this not being discussed earlier in this effort...\n\na)  I don\u0027t like that --force has to be specified by the user.  This shouldn\u0027t be an exceptional case, backing up an in-use volume should be a routine operation.  Here, we are pushing off extra thinking onto the user where a common path will be:\n  1) Attempt backup\n  2) Read error message, figure out why it didn\u0027t work\n  3) Attempt backup again now that you know you have to add an extra argument\n\nIt should be something more like:\n  1) Attempt backup\n  2) Cinder (server and/or client) figures out if it can do the backup online or not, and throws a reasonable error telling the user what happened if we can\u0027t.\n\nBut, if there\u0027s some reason we can\u0027t do (a)...\n\n\nb) I really don\u0027t like using the terminology \"force\" for this. The parameter should be called something more like \"--online\", \"--nondisruptive\" (too complicated), etc.\n\nI understand that this fits our other uses of \"force\" to mean \"override a status check\", but to a user, this really doesn\u0027t make much sense. \"Forcing\" a backup creation is not something that really has a predictable meaning if you don\u0027t know Cinder internals. People will guess and assign various meanings to it, and then be unclear on why their backup still doesn\u0027t run, when the force option actually does help, etc.","accounts_in_message":[],"_revision_number":2},{"id":"769ebdb088798209f718362249550f9b24f7db2d","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-19 01:23:30.000000000","message":"Patch Set 2:\n\nHi Eric,\n\nI believe this patch is already doing what you are suggesting as option A.\n\nHere is an example. User attempts to backup an in-use volume without the force flag, backup will fail with a message telling the user backing up an in-use volume needs to use the force flag.\n\ncinder backup-create 72f93a78-f7ea-4bcf-a820-d676d837ceb6\n\nERROR: Invalid volume: Backing up an in-use volume must use the force flag. (HTTP 400) (Request-ID: req-78d1bdcf-b0cc-4f87-b58d-c470d0dff77b)\n\nAfter reading this message, user can redo backup using the following command:\n\ncinder backup-create --force 72f93a78-f7ea-4bcf-a820-d676d837ceb6\n\nPlease let me know if this has addressed your concerns. Thanks.","accounts_in_message":[],"_revision_number":2},{"id":"4890da0b713212906371e2783a60c558ec0552d2","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-19 02:01:12.000000000","message":"Patch Set 2:\n\nHi Eric,\n\nIn \"cinder snapshot-create\", we already use a force flag to snapshot an in-use volume: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/shell.py#L635 .  We should probably be consistent and use the force flag to backup an in-use volume here.  What do you think?  Thanks.","accounts_in_message":[],"_revision_number":2},{"id":"30f0840d0ecfb295fbd970c1e0e99bcd7dc6f69c","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-19 03:02:04.000000000","message":"Patch Set 2:\n\nI added an item in tomorrow\u0027s meeting agenda to discuss about this. Thanks.","accounts_in_message":[],"_revision_number":2},{"id":"509519ae6084ebe35861edcaeb3f4de763ac5d40","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2015-08-19 16:03:49.000000000","message":"Patch Set 2: Code-Review+1\n\nI totally agree this is identical to snapshots, and we should use the established terminology. Like snapshots, an online backup means your data is only crash consistent, which is different to a properly unmounted volume.","accounts_in_message":[],"_revision_number":2},{"id":"b60d942ff9799bcd70ac45583d490a4f4aecd882","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-19 18:31:28.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f01009e9bf68c466cce483a0d8eae4af9eb6e0e2","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-19 18:34:12.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5141a31913629adc344474351da420b35eddf5ee","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-19 18:34:55.000000000","message":"Patch Set 4:\n\nUpdated the help text. Thanks.","accounts_in_message":[],"_revision_number":4},{"id":"baa65c2badfa8f3e3384b5b5670501f01f219800","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 20:11:27.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-python26/6d8c65b/ : SUCCESS in 1m 13s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-pep8/42f5728/ : SUCCESS in 1m 08s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/32/204232/4/check/gate-python-cinderclient-docs/4fa8079//doc/build/html/ : SUCCESS in 1m 39s\n- gate-python-cinderclient-python27 http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-python27/7b47b7e/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-python34 http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-python34/6a46212/ : SUCCESS in 1m 31s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/32/204232/4/check/gate-tempest-dsvm-neutron-src-python-cinderclient/229ba95/ : FAILURE in 1h 06m 26s\n- gate-python-cinderclient-pypy http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-pypy/e29e9e2/ : SUCCESS in 2m 12s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/32/204232/4/check/gate-cinderclient-dsvm-functional/6bfc20b/ : SUCCESS in 26m 31s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"e622b678198fce5a6c255abae048fda84c54d4f2","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-19 20:23:18.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"ba9d0cdb626052b4c7a3b043a2697c417499c797","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-20 00:02:57.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-python26/ecf3cf6/ : SUCCESS in 1m 16s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-pep8/c7414c0/ : SUCCESS in 1m 58s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/32/204232/4/check/gate-python-cinderclient-docs/de5fd5b//doc/build/html/ : SUCCESS in 2m 09s\n- gate-python-cinderclient-python27 http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-python27/da263b9/ : SUCCESS in 2m 16s\n- gate-python-cinderclient-python34 http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-python34/2b87212/ : SUCCESS in 1m 46s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/32/204232/4/check/gate-tempest-dsvm-neutron-src-python-cinderclient/326ed83/ : SUCCESS in 1h 13m 30s\n- gate-python-cinderclient-pypy http://logs.openstack.org/32/204232/4/check/gate-python-cinderclient-pypy/d4a21e3/ : SUCCESS in 3m 10s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/32/204232/4/check/gate-cinderclient-dsvm-functional/7f5390d/ : SUCCESS in 25m 56s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"780f2fb3db688103ca4d395a1c4543e3c4b398cc","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2015-08-21 13:36:29.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"f5c5cfbc8c5fa8da8c958589beff5966d45a8436","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2015-08-24 12:35:40.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"28c433237b29854c2e2754b14e3e76a38bf71dff","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2015-08-28 23:34:25.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"39d5daa9decc47caed095b65f25d553816a656de","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2015-08-28 23:48:30.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nThis looks ok to me.  The server side has merged so we should get this in.","accounts_in_message":[],"_revision_number":4},{"id":"faa8930a4deb1bbfe9a77172739e5efc8368b05e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-28 23:48:36.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"7817d3314169fa31b2437cb622e0a7fd1164cec9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-29 01:05:06.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/32/204232/4/gate/gate-python-cinderclient-python26/30d84f6/ : SUCCESS in 1m 38s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/32/204232/4/gate/gate-python-cinderclient-docs/775f39e//doc/build/html/ : SUCCESS in 49s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/32/204232/4/gate/gate-python-cinderclient-pep8/b528d14/ : SUCCESS in 1m 06s\n- gate-python-cinderclient-python27 http://logs.openstack.org/32/204232/4/gate/gate-python-cinderclient-python27/e74b1e6/ : SUCCESS in 1m 17s\n- gate-python-cinderclient-python34 http://logs.openstack.org/32/204232/4/gate/gate-python-cinderclient-python34/cd51ff6/ : SUCCESS in 1m 46s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/32/204232/4/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/18658a0/ : SUCCESS in 1h 13m 14s","accounts_in_message":[],"_revision_number":4},{"id":"53a080c235f37b4e9aa73b6d6965de35086d730d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-29 01:05:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2c3169e55e533154bb24e9b1eb9aa94a3e01719a","revisions":{"aa6da0890211e6c9bffdd59c33b79691f9a59d9e":{"kind":"REWORK","_number":1,"created":"2015-07-21 20:00:14.000000000","uploader":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"ref":"refs/changes/32/204232/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/32/204232/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/1"}}},"commit":{"parents":[{"commit":"a0f13ea8f1b7e5269f73e2175ace03347090f345","subject":"Merge \"Remove unnecessary check for tenant information\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a0f13ea8f1b7e5269f73e2175ace03347090f345"}]}],"author":{"name":"Xing Yang","email":"xing.yang@emc.com","date":"2015-07-21 19:06:39.000000000","tz":-240},"committer":{"name":"Xing Yang","email":"xing.yang@emc.com","date":"2015-07-21 20:00:13.000000000","tz":-240},"subject":"CLI: Non-disruptive backup","message":"CLI: Non-disruptive backup\n\nThis is the CLI change required to support non-disruptive backup\nfor volumes in \u0027in-use\u0027 status. A force flag is added to the create\nbackup CLI. The force flag needs to be True when backing up an\n\u0027in-use\u0027 volume. By default it is False and it is not needed when\nbacking up an \u0027available\u0027 volume.\n\nThe Cinder server side change is here:\nhttps://review.openstack.org/#/c/193937/\n\nPartial-implements blueprint non-disruptive-backup\n\nChange-Id: I53aff3973cc6365a5b1d40c21b0885c1d8166df5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/aa6da0890211e6c9bffdd59c33b79691f9a59d9e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/aa6da0890211e6c9bffdd59c33b79691f9a59d9e"}]},"branch":"refs/heads/master"},"af2ff597ae57b05b6c05827bac5f12c4dfa9660a":{"kind":"REWORK","_number":2,"created":"2015-08-11 16:06:02.000000000","uploader":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"ref":"refs/changes/32/204232/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/32/204232/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/2"}}},"commit":{"parents":[{"commit":"03542ee65a5e818a5d908a85a6a9eba21ef63b53","subject":"Fix ClientException init when there is no message on py34","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/03542ee65a5e818a5d908a85a6a9eba21ef63b53"}]}],"author":{"name":"Xing Yang","email":"xing.yang@emc.com","date":"2015-07-21 19:06:39.000000000","tz":-240},"committer":{"name":"Xing Yang","email":"xing.yang@emc.com","date":"2015-08-08 09:45:38.000000000","tz":-240},"subject":"CLI: Non-disruptive backup","message":"CLI: Non-disruptive backup\n\nThis is the CLI change required to support non-disruptive backup\nfor volumes in \u0027in-use\u0027 status. A force flag is added to the create\nbackup CLI. The force flag needs to be True when backing up an\n\u0027in-use\u0027 volume. By default it is False and it is not needed when\nbacking up an \u0027available\u0027 volume.\n\nThe Cinder server side change is merged:\nhttps://review.openstack.org/#/c/193937/\n\nPartial-implements blueprint non-disruptive-backup\n\nChange-Id: I53aff3973cc6365a5b1d40c21b0885c1d8166df5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/af2ff597ae57b05b6c05827bac5f12c4dfa9660a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/af2ff597ae57b05b6c05827bac5f12c4dfa9660a"}]},"branch":"refs/heads/master"},"4f43338e5913ec97bebb7d14c6ecf6eae552f2c7":{"kind":"REWORK","_number":3,"created":"2015-08-19 18:31:28.000000000","uploader":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"ref":"refs/changes/32/204232/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/32/204232/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/3"}}},"commit":{"parents":[{"commit":"b573e90d67c4777e1f6d0f2d4ab16013b02c0feb","subject":"Merge \"Add support \u0027--all-tenants\u0027 for cinder backup-list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/b573e90d67c4777e1f6d0f2d4ab16013b02c0feb"}]}],"author":{"name":"Xing Yang","email":"xing.yang@emc.com","date":"2015-07-21 19:06:39.000000000","tz":-240},"committer":{"name":"Xing Yang","email":"xing.yang@emc.com","date":"2015-08-11 14:17:00.000000000","tz":-240},"subject":"CLI: Non-disruptive backup","message":"CLI: Non-disruptive backup\n\nThis is the CLI change required to support non-disruptive backup\nfor volumes in \u0027in-use\u0027 status. A force flag is added to the create\nbackup CLI. The force flag needs to be True when backing up an\n\u0027in-use\u0027 volume. By default it is False and it is not needed when\nbacking up an \u0027available\u0027 volume.\n\nIf the user attempts to backup an in-use volume without the force flag,\nbackup will fail with a message telling the user backing up an in-use\nvolume needs to use the force flag.\n\ncinder backup-create 72f93a78-f7ea-4bcf-a820-d676d837ceb6\n\nERROR: Invalid volume: Backing up an in-use volume must use the force\nflag. (HTTP 400) (Request-ID: req-78d1bdcf-b0cc-4f87-b58d-c470d0dff77b)\n\nAfter reading this message, the user can re-run backup using the\nfollowing command:\n\ncinder backup-create --force 72f93a78-f7ea-4bcf-a820-d676d837ceb6\n\nThe Cinder server side change is merged:\nhttps://review.openstack.org/#/c/193937/\n\nPartial-implements blueprint non-disruptive-backup\n\nChange-Id: I53aff3973cc6365a5b1d40c21b0885c1d8166df5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4f43338e5913ec97bebb7d14c6ecf6eae552f2c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4f43338e5913ec97bebb7d14c6ecf6eae552f2c7"}]},"branch":"refs/heads/master"},"2c3169e55e533154bb24e9b1eb9aa94a3e01719a":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2015-08-19 18:34:12.000000000","uploader":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"ref":"refs/changes/32/204232/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/32/204232/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/32/204232/4"}}},"commit":{"parents":[{"commit":"b573e90d67c4777e1f6d0f2d4ab16013b02c0feb","subject":"Merge \"Add support \u0027--all-tenants\u0027 for cinder backup-list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/b573e90d67c4777e1f6d0f2d4ab16013b02c0feb"}]}],"author":{"name":"Xing Yang","email":"xing.yang@emc.com","date":"2015-07-21 19:06:39.000000000","tz":-240},"committer":{"name":"Xing Yang","email":"xing.yang@emc.com","date":"2015-08-11 14:18:01.000000000","tz":-240},"subject":"CLI: Non-disruptive backup","message":"CLI: Non-disruptive backup\n\nThis is the CLI change required to support non-disruptive backup\nfor volumes in \u0027in-use\u0027 status. A force flag is added to the create\nbackup CLI. The force flag needs to be True when backing up an\n\u0027in-use\u0027 volume. By default it is False and it is not needed when\nbacking up an \u0027available\u0027 volume.\n\nThe Cinder server side change is merged:\nhttps://review.openstack.org/#/c/193937/\n\nPartial-implements blueprint non-disruptive-backup\n\nChange-Id: I53aff3973cc6365a5b1d40c21b0885c1d8166df5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2c3169e55e533154bb24e9b1eb9aa94a3e01719a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2c3169e55e533154bb24e9b1eb9aa94a3e01719a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}