)]}'
{"id":"openstack%2Fpython-cinderclient~209258","triplet_id":"openstack%2Fpython-cinderclient~master~I738cb9c8d4f015048c45a1df16bf18e29190e392","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1481478","hashtags":[],"change_id":"I738cb9c8d4f015048c45a1df16bf18e29190e392","subject":"Fix ClientException init when there is no message on py34","status":"MERGED","created":"2015-08-04 21:21:33.000000000","updated":"2015-08-06 07:40:15.000000000","submitted":"2015-08-06 07:40:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5fb83c6a82b0c21429859af2791299f2641c33f6","_number":209258,"virtual_id_number":209258,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":2,"date":"2015-08-06 07:40:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"recommended":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"all":[{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-08-04 21:32:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":2,"date":"2015-08-05 22:32:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2015-08-06 06:21:52.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":1,"date":"2015-08-05 05:35:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"value":2,"date":"2015-08-05 23:27:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"all":[{"value":0,"date":"2015-08-05 13:19:25.000000000","_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2015-08-06 06:21:52.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-04 21:32:55.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2015-08-05 05:35:31.000000000","updated_by":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"reviewer":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"state":"REVIEWER"},{"updated":"2015-08-05 13:19:25.000000000","updated_by":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"reviewer":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"state":"REVIEWER"},{"updated":"2015-08-05 22:32:56.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2015-08-05 23:27:28.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2015-08-06 06:21:52.000000000","updated_by":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"reviewer":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"state":"REVIEWER"},{"updated":"2015-08-06 07:40:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8b9f1ceffe685849467ae1d2a28a2a64591297d9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-08-04 21:21:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"13ded5fc50693c1acf3855444da51ea51b3e24af","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-08-04 21:22:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"87b229c95e899f7b6a9bc6cf8544d2363a26b8ed","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2015-08-04 21:32:55.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8a3477d253f08ae4f34eedf594266584c7ce6a0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-04 23:56:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/58/209258/2/check/gate-python-cinderclient-python26/dbd8b63/ : SUCCESS in 1m 05s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/58/209258/2/check/gate-python-cinderclient-pep8/fe53f50/ : SUCCESS in 1m 17s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/58/209258/2/check/gate-python-cinderclient-docs/67809b7//doc/build/html/ : SUCCESS in 51s\n- gate-python-cinderclient-python27 http://logs.openstack.org/58/209258/2/check/gate-python-cinderclient-python27/d5004b8/ : SUCCESS in 1m 36s\n- gate-python-cinderclient-python34 http://logs.openstack.org/58/209258/2/check/gate-python-cinderclient-python34/2277f89/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/58/209258/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/38aca6b/ : SUCCESS in 51m 16s\n- gate-python-cinderclient-pypy http://logs.openstack.org/58/209258/2/check/gate-python-cinderclient-pypy/3f51623/ : SUCCESS in 2m 46s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/58/209258/2/check/gate-cinderclient-dsvm-functional/3b61ea2/ : SUCCESS in 26m 51s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d659f551564676239e123a7b5e57b063b4416e27","author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"date":"2015-08-05 05:35:31.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"eb5f01ed2b27b703e559cf04d8d0f94bdcdcc025","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2015-08-05 22:32:56.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5006e0a8510e5922838895cbd2b90109bf1ba267","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2015-08-05 23:27:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1a04ded3f80b28732d227e77db0462551c413e8d","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2015-08-06 06:21:52.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e77a837883dc52d82f4dc88a874c13379f6dacf4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-06 06:21:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"8fc32adecf3cecf3bf0e3a00c7a51c1a5d515abb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-06 07:40:15.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/58/209258/2/gate/gate-python-cinderclient-python26/eed82bb/ : SUCCESS in 1m 06s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/58/209258/2/gate/gate-python-cinderclient-docs/d1c28d8//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/58/209258/2/gate/gate-python-cinderclient-pep8/e1ccad2/ : SUCCESS in 1m 04s\n- gate-python-cinderclient-python27 http://logs.openstack.org/58/209258/2/gate/gate-python-cinderclient-python27/d96046e/ : SUCCESS in 1m 17s\n- gate-python-cinderclient-python34 http://logs.openstack.org/58/209258/2/gate/gate-python-cinderclient-python34/b2f0c63/ : SUCCESS in 1m 43s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/58/209258/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/8f13fce/ : SUCCESS in 1h 16m 32s","accounts_in_message":[],"_revision_number":2},{"id":"3d5016079a28a2e6e51e58e13f2cb750ba5e0e03","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-06 07:40:15.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"03542ee65a5e818a5d908a85a6a9eba21ef63b53","revisions":{"dc423a7e0a4af4c0751a4a3165f124c368f236b2":{"kind":"REWORK","_number":1,"created":"2015-08-04 21:21:33.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/58/209258/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/58/209258/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/58/209258/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/58/209258/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/58/209258/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/58/209258/1"}}},"commit":{"parents":[{"commit":"59fef40f0e9f7754c7a8e9c3b98a3027a46d767d","subject":"Merge \"Add response message when volume delete\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/59fef40f0e9f7754c7a8e9c3b98a3027a46d767d"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-08-04 21:20:53.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-08-04 21:21:19.000000000","tz":-420},"subject":"Fix ClientException init when there is no message on py34","message":"Fix ClientException init when there is no message on py34\n\nBaseException.message was removed in python 3 per PEP 0352 so if a\nmessage is passed to the ClientException __init__ it will blow up:\n\nAttributeError: type object \u0027ClientException\u0027 has no attribute \u0027message\u0027\n\nSo this change does two things:\n\n1. Default to \u0027n/a\u0027 for message and details when body[\u0027keys\u0027] doesn\u0027t\n   have a message or details in it (which should be fine since\n   from_response defaults to n/a if there \u0027keys\u0027 is not in body).\n2. Use getattr for self.__class__.message and default to None if that\n   attribute is not set.  Arguably we could just remove this and make\n   the message kwarg default to \u0027n/a\u0027 in ClientException.__init__ but\n   I figured that was more invasive.\n\nCloses-Bug: #1481478\n\nChange-Id: I738cb9c8d4f015048c45a1df16bf18e29190e392\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/dc423a7e0a4af4c0751a4a3165f124c368f236b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/dc423a7e0a4af4c0751a4a3165f124c368f236b2"}]},"branch":"refs/heads/master"},"03542ee65a5e818a5d908a85a6a9eba21ef63b53":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-08-04 21:22:25.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/58/209258/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/58/209258/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/58/209258/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/58/209258/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/58/209258/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/58/209258/2"}}},"commit":{"parents":[{"commit":"59fef40f0e9f7754c7a8e9c3b98a3027a46d767d","subject":"Merge \"Add response message when volume delete\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/59fef40f0e9f7754c7a8e9c3b98a3027a46d767d"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-08-04 21:20:53.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-08-04 21:21:52.000000000","tz":-420},"subject":"Fix ClientException init when there is no message on py34","message":"Fix ClientException init when there is no message on py34\n\nBaseException.message was removed in python 3 per PEP 0352 so if no\nmessage is passed to the ClientException __init__ it will blow up:\n\nAttributeError: type object \u0027ClientException\u0027 has no attribute \u0027message\u0027\n\nSo this change does two things:\n\n1. Default to \u0027n/a\u0027 for message and details when body[\u0027keys\u0027] doesn\u0027t\n   have a message or details in it (which should be fine since\n   from_response defaults to n/a if \u0027keys\u0027 is not in body).\n2. Use getattr for self.__class__.message and default to None if that\n   attribute is not set.  Arguably we could just remove this and make\n   the message kwarg default to \u0027n/a\u0027 in ClientException.__init__ but\n   I figured that was more invasive.\n\nCloses-Bug: #1481478\n\nChange-Id: I738cb9c8d4f015048c45a1df16bf18e29190e392\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/03542ee65a5e818a5d908a85a6a9eba21ef63b53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/03542ee65a5e818a5d908a85a6a9eba21ef63b53"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}