)]}'
{"cinderclient/v2/shell.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"bb267614db816b60995ebe333146358a76ad87c9","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":1824,"context_line":"    resp, body \u003d volume.show_image_metadata(volume)"},{"line_number":1825,"context_line":"    if body and body.get(\u0027metadata\u0027):"},{"line_number":1826,"context_line":"        utils.print_dict(body[\u0027metadata\u0027], \u0027Metadata-property\u0027)"},{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":""},{"line_number":1829,"context_line":"@utils.arg(\u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_243a5dce","line":1826,"updated":"2015-08-10 12:41:00.000000000","message":"We should either print a message or raise an exception if no metadata is found for a given volume.","commit_id":"196e32621a9287d4768d28b254235cb976312c7c"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"a09dc67bc14577b94a869c0c8d2d0daa6c0f454b","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":1824,"context_line":"    resp, body \u003d volume.show_image_metadata(volume)"},{"line_number":1825,"context_line":"    if body and body.get(\u0027metadata\u0027):"},{"line_number":1826,"context_line":"        utils.print_dict(body[\u0027metadata\u0027], \u0027Metadata-property\u0027)"},{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":""},{"line_number":1829,"context_line":"@utils.arg(\u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5fa836db","line":1826,"in_reply_to":"1a4dcd0f_243a5dce","updated":"2015-09-29 06:09:22.000000000","message":"Peter, I think this code above is not necessary since we can never get here.\n\n- If the volume doesnt exist it will raise an exception to indicate the volume doesn\u0027t exist.\n\n- If there is no image metadata for the specific volume, it will raise GlanceMetadataNotFound exception.\n\nI am not sure if there is any need to wrap the code here with \"try... except\" and then print out other message instead of the orignial since \"metadata-show\" command doesn\u0027t do this either.\n\nI\u0027d like to follow if anyone think we should do this.","commit_id":"196e32621a9287d4768d28b254235cb976312c7c"}]}