)]}'
{"cinderclient/tests/unit/test_shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"843040f72aa6b815703ff6b77aa9ce10038e6990","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def test_password_prompted(self, mock_getpass, mock_stdin):"},{"line_number":129,"context_line":"        self.make_env(exclude\u003d\u0027OS_PASSWORD\u0027)"},{"line_number":130,"context_line":"        with mock.patch(\u0027requests.Session.request\u0027,"},{"line_number":131,"context_line":"                        side_effect\u003dreq_exc.ConnectionError()):"},{"line_number":132,"context_line":"            self.assertRaises(ks_exc.ConnectionRefused, self.shell, \u0027list\u0027)"},{"line_number":133,"context_line":"            mock_getpass.assert_called_with(\u0027OS Password: \u0027)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_df976f46","line":131,"updated":"2015-08-19 17:01:42.000000000","message":"We should probably mock out the call to keystoneclient and make it fail rather than mocking the requests library calls inside of keystoneclient.\n\nDoing this the way you have here may break when keystoneclient changes code, and we really just want to test the cinderclient behavior.","commit_id":"4f624d5330bef1a6cfae68f8faffd004b1679130"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"d1a3d22a286eb5b97c0e53e186ee481e03590954","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        with mock.patch(\u0027keystoneclient.adapter.Adapter.get_token\u0027,"},{"line_number":130,"context_line":"                        side_effect\u003dks_exc.ConnectionRefused()):"},{"line_number":131,"context_line":"            with mock.patch(\u0027keystoneclient.discover.Discover\u0027,"},{"line_number":132,"context_line":"                            side_effect\u003dks_exc.ConnectionRefused()):"},{"line_number":133,"context_line":"                _shell \u003d shell.OpenStackCinderShell()"},{"line_number":134,"context_line":"                self.assertRaises(ks_exc.ConnectionRefused, _shell.main,"},{"line_number":135,"context_line":"                                  [\u0027list\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_9db8c312","line":132,"updated":"2015-08-21 07:48:26.000000000","message":"Could you avoid the nested mock by putting them on top of the method as the decorator?","commit_id":"97d9aa4e43764f9e37299a98c30a03156318865f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ee375ab793a687e58b813b2d2da998a452e27e1b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    @mock.patch(\u0027sys.stdin\u0027, side_effect\u003dmock.MagicMock)"},{"line_number":130,"context_line":"    @mock.patch(\u0027getpass.getpass\u0027, return_value\u003d\u0027password\u0027)"},{"line_number":131,"context_line":"    def test_password_prompted(self, mock_getpass, mock_stdin, mock_token,"},{"line_number":132,"context_line":"                               mock_discover):"},{"line_number":133,"context_line":"        self.make_env(exclude\u003d\u0027OS_PASSWORD\u0027)"},{"line_number":134,"context_line":"        _shell \u003d shell.OpenStackCinderShell()"},{"line_number":135,"context_line":"        self.assertRaises(ks_exc.ConnectionRefused, _shell.main, [\u0027list\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_4223d1bd","line":132,"updated":"2015-08-27 14:23:46.000000000","message":"The order of the new parameters is reversed.","commit_id":"589e80c6ea76f6f3e128a61dc8fb240951d73850"}]}