)]}'
{"id":"openstack%2Fpython-cinderclient~239430","triplet_id":"openstack%2Fpython-cinderclient~master~I0a7dc48ba19ed8b6b7f178444571b7da758e530d","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1509460","hashtags":[],"change_id":"I0a7dc48ba19ed8b6b7f178444571b7da758e530d","subject":"Fix usage of setUpClass method in functional tests","status":"ABANDONED","created":"2015-10-26 13:25:01.000000000","updated":"2015-11-20 17:41:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"222194f614c01d4b408b03ec1a3df85a1faa5c49","_number":239430,"virtual_id_number":239430,"owner":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"date":"2015-11-16 12:36:06.000000000","_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":1,"date":"2015-10-26 14:23:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"date":"2015-11-19 19:11:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-11-04 14:22:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":-1,"date":"2015-11-19 11:19:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":-1,"date":"2015-11-16 21:16:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"date":"2015-11-04 17:17:46.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-26 14:23:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-11-04 14:22:34.000000000","updated_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"reviewer":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"state":"REVIEWER"},{"updated":"2015-11-04 17:17:46.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2015-11-16 21:16:58.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2015-11-19 11:19:14.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-11-19 19:11:28.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"6129b8d1d8a31b7c83262d4169365c476c2477ce","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-10-26 13:25:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8a76751a8dec262158ec19179ad82cb8ac0ac9d9","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-10-26 13:25:26.000000000","message":"Topic set to bug/1509460","accounts_in_message":[],"_revision_number":1},{"id":"959d8d975bfc7ee41720de4a0784f780a8df77d5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-26 14:23:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/30/239430/1/check/gate-python-cinderclient-python26/824197c/ : SUCCESS in 1m 15s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/30/239430/1/check/gate-python-cinderclient-pep8/4cce425/ : SUCCESS in 53s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/30/239430/1/check/gate-python-cinderclient-docs/dca1737//doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-cinderclient-python27 http://logs.openstack.org/30/239430/1/check/gate-python-cinderclient-python27/f490864/ : SUCCESS in 1m 23s\n- gate-python-cinderclient-python34 http://logs.openstack.org/30/239430/1/check/gate-python-cinderclient-python34/fca978a/ : SUCCESS in 1m 54s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/30/239430/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/a7d519c/ : SUCCESS in 55m 32s\n- gate-python-cinderclient-pypy http://logs.openstack.org/30/239430/1/check/gate-python-cinderclient-pypy/2e3f1d0/ : SUCCESS in 1m 54s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/30/239430/1/check/gate-cinderclient-dsvm-functional/3b804ee/ : SUCCESS in 28m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9c8ef3be9468c09d8b39bb5adfa770e3178cd7a0","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-11-03 02:38:47.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"93822c14dac7b3a1f2bbdeffb6a4a3320d64f333","author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"date":"2015-11-04 14:22:34.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks good to me. Thanks for cleaning up this bug.","accounts_in_message":[],"_revision_number":1},{"id":"6c8ec4a88d08f757c4a96836fbf44b195638ceb4","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-11-16 12:17:58.000000000","message":"Patch Set 1: Code-Review-1\n\nMaking such changes without any comment in the config could raise issues in the future when multithreaded test run will be needed.\n\nConcurrency should be configured in a right way. Current fix looks like a hack","accounts_in_message":[],"_revision_number":1},{"id":"118b09e379c5c584186e2de92f873df2a23f6f81","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-16 12:36:06.000000000","message":"Patch Set 1:\n\nIvan,\n\nFirst of all, configuration via lib config can not be hack. It is configuration.\n\nSecond, the fact that \"setUpClass\" runs more than one time is a bug, very expensive bug.\n\nBest fix would be fix of testrepository runner. Exactly it should handle class and test runs properly.\n\nUntil it happens, updated cinderclient\u0027s config for testrepository to exclude appearance of the bug.\n\nAnd third, current change does not block usage of multithreading. All separate test classes still are able to run in parallel.\n\nSo, do I understand you correctly that \"adding comment to config\" would be enough in current situation?","accounts_in_message":[],"_revision_number":1},{"id":"4896c366f4423fdcc08f02292548bc310d999777","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-11-16 14:05:29.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"9464be34f9c47bf312ae8acfe6715d7e0f9a3792","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-11-16 14:05:50.000000000","message":"Patch Set 1:\n\nLooks like I\u0027ve misunderstood what this patch does","accounts_in_message":[],"_revision_number":1},{"id":"10ce75ffb74076ffa8558793ea2f919993253f25","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2015-11-16 21:16:58.000000000","message":"Patch Set 1: Code-Review-1\n\nfor what it\u0027s worth, running the functional tests takes about 10 seconds longer to run with this patch than without.\nSo, what is the the original problem that this patch is trying to solve.   Don\u0027t want want to run tests in multiple threads to speed up execution ?\n\nThe original bug looks like it\u0027s filed against the manila client.\n\nRan 19 tests in 66.952s (-9.090s)\n\nvs\n\nRan 19 tests in 76.042s (-0.218s)","accounts_in_message":[],"_revision_number":1},{"id":"900828c5f74529ccb26e0f0d27bf75b50b51b03e","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-19 10:22:47.000000000","message":"Patch Set 1:\n\nWalter,\n\nСommit message and my comment-answer for Ivan answer your questions. Please, reread them. Nothing to do with your -1.\n\nFor the moment, this commit prevents future resources leak when Cinderclient functional tests start use class methods for resource setup that is just not used right now.\n\nSoon or later, it should be fixed.","accounts_in_message":[],"_revision_number":1},{"id":"71f34d24901e6be461fd34a5d600a4e1328e5f6c","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-11-19 11:19:14.000000000","message":"Patch Set 1: Code-Review-1\n\nValeriy, if this patch is not needed right now, why do we need it?","accounts_in_message":[],"_revision_number":1},{"id":"1a7ea95a3f64f6575dd1d9aef66cf543a05e44f0","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-19 12:00:33.000000000","message":"Patch Set 1:\n\nIvan,\n\nI propose bugfix, if you think cinderclient does not need it because it does not suffer from it yet, then, please, set \"won\u0027t fix\" status to bug-report and I will abandon this change.","accounts_in_message":[],"_revision_number":1},{"id":"ecc8639cb6c47c43c1a975398f255da21834f540","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2015-11-19 18:55:42.000000000","message":"Patch Set 1:\n\nAs a side note, I don\u0027t see where setUpClass is ever declared/used inside of the cinderclient/tests dir.","accounts_in_message":[],"_revision_number":1},{"id":"43087565b64ce9d4c6a4c285e7b68d098df66b25","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2015-11-19 19:11:28.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"222194f614c01d4b408b03ec1a3df85a1faa5c49","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-20 17:41:57.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a155da8100b5ac5acbddf7c7e097d16d4103e095","revisions":{"a155da8100b5ac5acbddf7c7e097d16d4103e095":{"kind":"REWORK","_number":1,"created":"2015-10-26 13:25:01.000000000","uploader":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"ref":"refs/changes/30/239430/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/30/239430/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/30/239430/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/30/239430/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/30/239430/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/30/239430/1"}}},"commit":{"parents":[{"commit":"cfecd8ebe0c3baf259142615e94d698fc0b4169f","subject":"Merge \"Add note for broken cinderclient versions 1.2.?\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cfecd8ebe0c3baf259142615e94d698fc0b4169f"}]}],"author":{"name":"Valeriy Ponomaryov","email":"vponomaryov@mirantis.com","date":"2015-10-26 13:23:06.000000000","tz":120},"committer":{"name":"Valeriy Ponomaryov","email":"vponomaryov@mirantis.com","date":"2015-10-26 13:24:53.000000000","tz":120},"subject":"Fix usage of setUpClass method in functional tests","message":"Fix usage of setUpClass method in functional tests\n\nClass method \u0027setUpClass\u0027 is executed for each test of test suite that\nappeared in new thread. It leads to creation of redundant resources,\nand, hence, waste of resources.\n\nSo, add \u0027group_regex\u0027 option in testr config that will make all tests\nof each class run in one thread.\n\nChange-Id: I0a7dc48ba19ed8b6b7f178444571b7da758e530d\nCloses-Bug: #1509460\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a155da8100b5ac5acbddf7c7e097d16d4103e095"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a155da8100b5ac5acbddf7c7e097d16d4103e095"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}