)]}'
{"cinderclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"7aa8bcbc127d03171b7e9d88059fcb2f0405be48","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        self.run_command(\u0027snapshot-list --tenant 123\u0027)"},{"line_number":433,"context_line":"        self.assert_called(\u0027GET\u0027,"},{"line_number":434,"context_line":"                           \u0027/snapshots/detail?all_tenants\u003d1\u0026project_id\u003d123\u0027)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_rename(self):"},{"line_number":437,"context_line":"        # basic rename with positional arguments"},{"line_number":438,"context_line":"        self.run_command(\u0027rename 1234 new-name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_bd1c0678","line":435,"updated":"2015-11-10 13:05:02.000000000","message":"This test is called without all tenants. So self.assert_called() should be without all_tenants\u003d1.","commit_id":"bf8cee672a0ffcb22415bd2d2841ba9e3abcbe42"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"bd38b4eb79b146cbf63c3ff9965d30f7b473feab","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        self.run_command(\u0027snapshot-list --tenant 123\u0027)"},{"line_number":433,"context_line":"        self.assert_called(\u0027GET\u0027,"},{"line_number":434,"context_line":"                           \u0027/snapshots/detail?all_tenants\u003d1\u0026project_id\u003d123\u0027)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_rename(self):"},{"line_number":437,"context_line":"        # basic rename with positional arguments"},{"line_number":438,"context_line":"        self.run_command(\u0027rename 1234 new-name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_44ae5099","line":435,"in_reply_to":"da85f559_bd1c0678","updated":"2015-11-10 18:20:19.000000000","message":"This is intentional. See shell.py which sets all_tenants to 1 while calling the REST API. On the server side, if all_tenants is not set to 1, it uses user\u0027s current project_id instead of the command-line param to lookup the snapshots.","commit_id":"bf8cee672a0ffcb22415bd2d2841ba9e3abcbe42"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"df783c4b414377e73fbc5e348b2aa3834fae6951","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                  \u0027form of \u003ckey\u003e[:\u003casc|desc\u003e]. \u0027"},{"line_number":637,"context_line":"                  \u0027Valid keys: %s. \u0027"},{"line_number":638,"context_line":"                  \u0027Default\u003dNone.\u0027) % \u0027, \u0027.join(base.SORT_KEY_VALUES)))"},{"line_number":639,"context_line":"@utils.service_type(\u0027volumev2\u0027)"},{"line_number":640,"context_line":"@utils.arg(\u0027--tenant\u0027,"},{"line_number":641,"context_line":"           type\u003dstr,"},{"line_number":642,"context_line":"           dest\u003d\u0027tenant\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_78ceacb5","line":639,"updated":"2015-11-10 13:13:09.000000000","message":"In my view it would be better put down this line just before the function definition (def do_snapshot_list) for consistency.","commit_id":"bf8cee672a0ffcb22415bd2d2841ba9e3abcbe42"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"bd38b4eb79b146cbf63c3ff9965d30f7b473feab","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                  \u0027form of \u003ckey\u003e[:\u003casc|desc\u003e]. \u0027"},{"line_number":637,"context_line":"                  \u0027Valid keys: %s. \u0027"},{"line_number":638,"context_line":"                  \u0027Default\u003dNone.\u0027) % \u0027, \u0027.join(base.SORT_KEY_VALUES)))"},{"line_number":639,"context_line":"@utils.service_type(\u0027volumev2\u0027)"},{"line_number":640,"context_line":"@utils.arg(\u0027--tenant\u0027,"},{"line_number":641,"context_line":"           type\u003dstr,"},{"line_number":642,"context_line":"           dest\u003d\u0027tenant\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_c4c32056","line":639,"in_reply_to":"da85f559_78ceacb5","updated":"2015-11-10 18:20:19.000000000","message":"Done","commit_id":"bf8cee672a0ffcb22415bd2d2841ba9e3abcbe42"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"72e53598f35713a4966d471a384b8036ad81598e","unresolved":false,"context_lines":[{"line_number":645,"context_line":"@utils.service_type(\u0027volumev2\u0027)"},{"line_number":646,"context_line":"def do_snapshot_list(cs, args):"},{"line_number":647,"context_line":"    \"\"\"Lists all snapshots.\"\"\""},{"line_number":648,"context_line":"    all_tenants \u003d 1 if args.tenant else \\"},{"line_number":649,"context_line":"        int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    if args.display_name is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_3e5c237c","line":648,"updated":"2015-12-08 17:25:11.000000000","message":"Would be great if we can avoid the \\ and wrap this in () if you do another update. Otherwise, that is how the existing code is, so not a huge deal.","commit_id":"970d50cd8a42f44cac329ace5419e39c36e409b4"}]}
