)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2b87439193fc93b252f79ccfe239800afcb04451","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add request_ids attribute to resource objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added request_ids attribute to resource object and returning list with"},{"line_number":10,"context_line":"request_ids as attribute in case of \u0027list\u0027 api for encryption types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"These changes are required to return \u0027request_id\u0027 from client to log"},{"line_number":13,"context_line":"request_id mappings of cross projects."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_834c6971","line":10,"updated":"2016-01-02 17:20:40.000000000","message":"You also changed backups and transfers, in addition to encryption types.  Please add them to commit message as well.","commit_id":"4b05379a3cd608fc58b8c71d26a1317c518367b5"}],"cinderclient/v2/volume_backups.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"54d9afadbb43c9aa160b8a1c02e678cc49025e84","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.run_hooks(\u0027modify_body_for_action\u0027, body, **kwargs)"},{"line_number":97,"context_line":"        url \u003d \u0027/backups/%s/action\u0027 % base.getid(backup)"},{"line_number":98,"context_line":"        resp, body \u003d self.api.client.post(url, body\u003dbody)"},{"line_number":99,"context_line":"        return common_base.TupleWithMeta(resp, body)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def export_record(self, backup_id):"},{"line_number":102,"context_line":"        \"\"\"Export volume backup metadata record."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a57f1b5_a4502cd5","line":99,"updated":"2016-02-12 15:02:52.000000000","message":"Same comment here.","commit_id":"db5f4dcda990f2d984c715782d1ca41924355f2d"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"bbc0bfe52b6bfc2a440cb71c6ab6fa62145c1d6f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"             sort\u003dNone):"},{"line_number":74,"context_line":"        \"\"\"Get a list of all volume backups."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :rtype: list of :class:`VolumeBackup`"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        resource_type \u003d \"backups\""},{"line_number":79,"context_line":"        url \u003d self._build_list_url(resource_type, detailed\u003ddetailed,"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_d472a210","line":76,"range":{"start_line":76,"start_character":16,"end_line":76,"end_character":20},"updated":"2016-02-17 02:45:06.000000000","message":"It returns ListWithMeta now.","commit_id":"c49fce3909a1705855ee2b91a82c39830fe17edd"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"bbc0bfe52b6bfc2a440cb71c6ab6fa62145c1d6f","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :param backup_service: Backup service to use for importing the backup"},{"line_number":117,"context_line":"        :param backup_url: Backup URL for importing the backup metadata"},{"line_number":118,"context_line":"        :rtype: :class:`VolumeBackup`"},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        body \u003d {\u0027backup-record\u0027: {\u0027backup_service\u0027: backup_service,"},{"line_number":121,"context_line":"                                  \u0027backup_url\u0027: backup_url}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_54d4d2bb","line":118,"range":{"start_line":118,"start_character":16,"end_line":118,"end_character":37},"updated":"2016-02-17 02:45:06.000000000","message":"It returns a DictWithMeta now.","commit_id":"c49fce3909a1705855ee2b91a82c39830fe17edd"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"a3fe9046080bcedc7cf666e3610c525d52ee1452","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :param backup_service: Backup service to use for importing the backup"},{"line_number":117,"context_line":"        :param backup_url: Backup URL for importing the backup metadata"},{"line_number":118,"context_line":"        :rtype: :class:`VolumeBackup`"},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        body \u003d {\u0027backup-record\u0027: {\u0027backup_service\u0027: backup_service,"},{"line_number":121,"context_line":"                                  \u0027backup_url\u0027: backup_url}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_5f67bd4c","line":118,"range":{"start_line":118,"start_character":16,"end_line":118,"end_character":37},"in_reply_to":"dae33548_46df000d","updated":"2016-02-17 09:46:05.000000000","message":"Hi Cao ShuFeng,\n\nI have tested this on master and it returns a dictionary containing volume backup metadata.\nI have submitted a separate patch [1] to fix this docstring\n\n[1] https://review.openstack.org/#/c/281141","commit_id":"c49fce3909a1705855ee2b91a82c39830fe17edd"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"5e83977fe22454d6df925c99526a5b0390e1e4c8","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :param backup_service: Backup service to use for importing the backup"},{"line_number":117,"context_line":"        :param backup_url: Backup URL for importing the backup metadata"},{"line_number":118,"context_line":"        :rtype: :class:`VolumeBackup`"},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        body \u003d {\u0027backup-record\u0027: {\u0027backup_service\u0027: backup_service,"},{"line_number":121,"context_line":"                                  \u0027backup_url\u0027: backup_url}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_46df000d","line":118,"range":{"start_line":118,"start_character":16,"end_line":118,"end_character":37},"in_reply_to":"dae33548_54d4d2bb","updated":"2016-02-17 06:52:23.000000000","message":"The returned value is not a VolumeBackup or subclass of VolumeBackup, in my opinion.","commit_id":"c49fce3909a1705855ee2b91a82c39830fe17edd"}],"cinderclient/v2/volume_encryption_types.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"bbc0bfe52b6bfc2a440cb71c6ab6fa62145c1d6f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        List all volume encryption types."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        :param volume_types: a list of volume types"},{"line_number":45,"context_line":"        :return: a list of :class: VolumeEncryptionType instances"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        # Since the encryption type is a volume type extension, we cannot get"},{"line_number":48,"context_line":"        # all encryption types without going through all volume types."}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_d4a8e279","line":45,"range":{"start_line":45,"start_character":17,"end_line":45,"end_character":65},"updated":"2016-02-17 02:45:06.000000000","message":"It returns a ListWithMeta now.","commit_id":"c49fce3909a1705855ee2b91a82c39830fe17edd"}],"cinderclient/v2/volume_transfers.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"bbc0bfe52b6bfc2a440cb71c6ab6fa62145c1d6f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def list(self, detailed\u003dTrue, search_opts\u003dNone):"},{"line_number":74,"context_line":"        \"\"\"Get a list of all volume transfer."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :rtype: list of :class:`VolumeTransfer`"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        if search_opts is None:"},{"line_number":79,"context_line":"            search_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_14808abf","line":76,"range":{"start_line":76,"start_character":16,"end_line":76,"end_character":20},"updated":"2016-02-17 02:45:06.000000000","message":"It returns a ListWithMeta now.","commit_id":"c49fce3909a1705855ee2b91a82c39830fe17edd"}]}
