)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"73d4713bfbb37528c269f68e09f43df5cce87c25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lisali \u003cxiaoyan.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-30 16:57:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup-rename"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add backup-rename command to update name and description"},{"line_number":10,"context_line":"of a backup."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_761f546c","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":17},"updated":"2016-07-06 09:24:49.000000000","message":"-1: New command should be backup-update to be consistent with other commands.","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6a3d61ffa28bd849f6699e68557c074c5ab380f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lisali \u003cxiaoyan.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-30 16:57:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup-rename"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add backup-rename command to update name and description"},{"line_number":10,"context_line":"of a backup."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_474c4170","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":17},"in_reply_to":"1aa78d24_761f546c","updated":"2016-08-04 05:55:57.000000000","message":"Done","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"}],"cinderclient/tests/unit/v3/test_shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02ee518f6d840599df5d234745cb9577eb806f13","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.assert_called_anytime(\u0027POST\u0027, \u0027/volumes/1234/action\u0027,"},{"line_number":96,"context_line":"                                   body\u003dexpected)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_backup_rename(self):"},{"line_number":99,"context_line":"        self.run_command(\u0027backup-rename 1234 new_name\u0027)"},{"line_number":100,"context_line":"        expected \u003d {\u0027backup\u0027: {\u0027display_name\u0027: \u0027new_name\u0027}}"},{"line_number":101,"context_line":"        self.assert_called(\u0027PUT\u0027, \u0027/backups/1234\u0027, body\u003dexpected)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_0c13be5d","line":98,"updated":"2016-06-28 09:35:12.000000000","message":"-1: We should try to test just 1 thing in each method.","commit_id":"ed91c4629d09ed6531e76786870f75b60b414de7"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"8e20ccfb1e7295605a961a15647901339f55fc8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3aaa91ec_b86eab2c","line":130,"updated":"2016-06-30 08:59:20.000000000","message":"Seems I need to add another test case when version is lower than 3.7.","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6a3d61ffa28bd849f6699e68557c074c5ab380f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bacf61ea_6777c59f","line":130,"in_reply_to":"1aa78d24_e139c0d8","updated":"2016-08-04 05:55:57.000000000","message":"Added.","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"73d4713bfbb37528c269f68e09f43df5cce87c25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1aa78d24_e139c0d8","line":130,"in_reply_to":"3aaa91ec_b86eab2c","updated":"2016-07-06 09:24:49.000000000","message":"That would be ideal","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3d968cb89659bc4f1ba3aa198c5b25959809000c","unresolved":false,"context_lines":[{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"    if not any(kwargs):"},{"line_number":1576,"context_line":"        msg \u003d \u0027Must supply either name or description.\u0027"},{"line_number":1577,"context_line":"        raise exceptions.ClientException(code\u003d1, message\u003dmsg)"},{"line_number":1578,"context_line":""},{"line_number":1579,"context_line":"    _find_backup(cs, args.backup).update(**kwargs)"},{"line_number":1580,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_62e3d2d9","line":1577,"updated":"2016-02-23 22:40:45.000000000","message":"This results in an error saying \"(HTTP 1)\" which is not correct.\n\n$ cinder backup-rename fdb366c5-b469-4e7c-a8b6-05648699f194 \nERROR: Must supply either name or description. (HTTP 1)","commit_id":"c43630be30f613c2e48071ccbd40da85e388af39"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"2986a3b838ad333762352b9e8af5cef2b9cddede","unresolved":false,"context_lines":[{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"    if not any(kwargs):"},{"line_number":1576,"context_line":"        msg \u003d \u0027Must supply either name or description.\u0027"},{"line_number":1577,"context_line":"        raise exceptions.ClientException(code\u003d1, message\u003dmsg)"},{"line_number":1578,"context_line":""},{"line_number":1579,"context_line":"    _find_backup(cs, args.backup).update(**kwargs)"},{"line_number":1580,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_f9d950f4","line":1577,"in_reply_to":"bae84128_62e3d2d9","updated":"2016-02-24 02:57:29.000000000","message":"With your change in https://review.openstack.org/#/c/283850/, this problem is fixed.","commit_id":"c43630be30f613c2e48071ccbd40da85e388af39"}],"cinderclient/v2/volume_backups.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"ea482e325b9dff2425590ff08336ece6c94bfa94","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                  \u0027backup_url\u0027: backup_url}}"},{"line_number":126,"context_line":"        self.run_hooks(\u0027modify_body_for_update\u0027, body, \u0027backup-record\u0027)"},{"line_number":127,"context_line":"        resp, body \u003d self.api.client.post(\"/backups/import_record\", body\u003dbody)"},{"line_number":128,"context_line":"        return common_base.DictWithMeta(body[\u0027backup\u0027], resp)"},{"line_number":129,"context_line":"        return body[\u0027backup\u0027]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def update(self, backup, **kwargs):"},{"line_number":132,"context_line":"        \"\"\"Update the name or description for a backup."}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_4255501b","line":129,"range":{"start_line":128,"start_character":8,"end_line":129,"end_character":29},"updated":"2016-02-27 05:56:21.000000000","message":"A function can return twice?\n:)","commit_id":"f00bdb1c824b7aad4b845792d818b67c728e990f"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"d0bd16d2444441e940037cb1579eb66cc7fca9da","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                  \u0027backup_url\u0027: backup_url}}"},{"line_number":126,"context_line":"        self.run_hooks(\u0027modify_body_for_update\u0027, body, \u0027backup-record\u0027)"},{"line_number":127,"context_line":"        resp, body \u003d self.api.client.post(\"/backups/import_record\", body\u003dbody)"},{"line_number":128,"context_line":"        return common_base.DictWithMeta(body[\u0027backup\u0027], resp)"},{"line_number":129,"context_line":"        return body[\u0027backup\u0027]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def update(self, backup, **kwargs):"},{"line_number":132,"context_line":"        \"\"\"Update the name or description for a backup."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_7a25e25a","line":129,"range":{"start_line":128,"start_character":8,"end_line":129,"end_character":29},"in_reply_to":"9aed3d3a_4255501b","updated":"2016-06-28 01:57:16.000000000","message":"Fixed.","commit_id":"f00bdb1c824b7aad4b845792d818b67c728e990f"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"ea482e325b9dff2425590ff08336ece6c94bfa94","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        body \u003d {\"backup\": kwargs}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self._update(\"/backups/%s\" % base.getid(backup), body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_022228b9","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":62},"updated":"2016-02-27 05:56:21.000000000","message":"Now we must return request_ids to users according to this spec[1].\n\nI suggest:\nreturn self._update(\"/backups/%s\" % base.getid(backup), body)\n\n[1]: http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html","commit_id":"f00bdb1c824b7aad4b845792d818b67c728e990f"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"3fc91a5f8e6452d1da2421f4d34acd22bf2b12a3","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        body \u003d {\"backup\": kwargs}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self._update(\"/backups/%s\" % base.getid(backup), body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1a993e20","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":62},"in_reply_to":"3aaa91ec_7ab3220b","updated":"2016-06-28 02:16:11.000000000","message":"This function may called by lib users, so we need to return HttpResponse header \"request-id\" to lib users.\n(I mean every public function in Manager class need to return a list of request-id to user.)\nSo I suggest to make this function consistent with other Manager classes\u0027 update function.","commit_id":"f00bdb1c824b7aad4b845792d818b67c728e990f"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"d0bd16d2444441e940037cb1579eb66cc7fca9da","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        body \u003d {\"backup\": kwargs}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self._update(\"/backups/%s\" % base.getid(backup), body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_7ab3220b","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":62},"in_reply_to":"9aed3d3a_022228b9","updated":"2016-06-28 01:57:16.000000000","message":"Sorry, I didn\u0027t see any differences from you suggest.","commit_id":"f00bdb1c824b7aad4b845792d818b67c728e990f"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02ee518f6d840599df5d234745cb9577eb806f13","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027,"},{"line_number":1582,"context_line":"           help\u003d\u0027Name or ID of backup to rename.\u0027)"},{"line_number":1583,"context_line":"@utils.arg(\u0027name\u0027, nargs\u003d\u0027?\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1584,"context_line":"           help\u003d\u0027New name for backup.\u0027)"},{"line_number":1585,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1586,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_29902cec","line":1583,"updated":"2016-06-28 09:35:12.000000000","message":"nit: For consistency with the description, shouldn\u0027t you set `default\u003dNone` as well? (Or remove it from both)","commit_id":"ed91c4629d09ed6531e76786870f75b60b414de7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02ee518f6d840599df5d234745cb9577eb806f13","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"           default\u003dNone,"},{"line_number":1587,"context_line":"           help\u003d\u0027Backup description. Default\u003dNone.\u0027)"},{"line_number":1588,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1589,"context_line":"def do_backup_rename(cs, args):"},{"line_number":1590,"context_line":"    \"\"\"Renames a backup.\"\"\""},{"line_number":1591,"context_line":"    kwargs \u003d {}"},{"line_number":1592,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_097730d5","line":1589,"updated":"2016-06-28 09:35:12.000000000","message":"-1: This must be limited to v3.7","commit_id":"ed91c4629d09ed6531e76786870f75b60b414de7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02ee518f6d840599df5d234745cb9577eb806f13","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"    if args.description is not None:"},{"line_number":1597,"context_line":"        kwargs[\u0027display_description\u0027] \u003d args.description"},{"line_number":1598,"context_line":""},{"line_number":1599,"context_line":"    if not any(kwargs):"},{"line_number":1600,"context_line":"        msg \u003d \u0027Must supply either name or description.\u0027"},{"line_number":1601,"context_line":"        raise exceptions.ClientException(code\u003d1, message\u003dmsg)"},{"line_number":1602,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_a916dc52","line":1599,"updated":"2016-06-28 09:35:12.000000000","message":"-1: This should be:\n\n if not kwargs:","commit_id":"ed91c4629d09ed6531e76786870f75b60b414de7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"73d4713bfbb37528c269f68e09f43df5cce87c25","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027,"},{"line_number":1582,"context_line":"           help\u003d\u0027Name or ID of backup to rename.\u0027)"},{"line_number":1583,"context_line":"@utils.arg(\u0027name\u0027, nargs\u003d\u0027?\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1584,"context_line":"           help\u003d\u0027New name for backup.\u0027)"},{"line_number":1585,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1586,"context_line":"           help\u003d\u0027Backup description. Default\u003dNone.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_61895075","line":1583,"range":{"start_line":1583,"start_character":11,"end_line":1583,"end_character":17},"updated":"2016-07-06 09:24:49.000000000","message":"-1: \u0027--name\u0027","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6a3d61ffa28bd849f6699e68557c074c5ab380f3","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027,"},{"line_number":1582,"context_line":"           help\u003d\u0027Name or ID of backup to rename.\u0027)"},{"line_number":1583,"context_line":"@utils.arg(\u0027name\u0027, nargs\u003d\u0027?\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1584,"context_line":"           help\u003d\u0027New name for backup.\u0027)"},{"line_number":1585,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1586,"context_line":"           help\u003d\u0027Backup description. Default\u003dNone.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_3391939a","line":1583,"range":{"start_line":1583,"start_character":11,"end_line":1583,"end_character":17},"in_reply_to":"1aa78d24_61895075","updated":"2016-08-04 05:55:57.000000000","message":"Done","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"73d4713bfbb37528c269f68e09f43df5cce87c25","unresolved":false,"context_lines":[{"line_number":1584,"context_line":"           help\u003d\u0027New name for backup.\u0027)"},{"line_number":1585,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1586,"context_line":"           help\u003d\u0027Backup description. Default\u003dNone.\u0027)"},{"line_number":1587,"context_line":"@utils.service_type(\u0027volumev3.7\u0027)"},{"line_number":1588,"context_line":"def do_backup_rename(cs, args):"},{"line_number":1589,"context_line":"    \"\"\"Renames a backup.\"\"\""},{"line_number":1590,"context_line":"    kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_e1f70089","line":1587,"range":{"start_line":1587,"start_character":0,"end_line":1587,"end_character":33},"updated":"2016-07-06 09:24:49.000000000","message":"-1: This should be:\n\n @utils.service_type(\u0027volumev3\u0027)\n @api_versions.wraps(\u00273.7\u0027)","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6a3d61ffa28bd849f6699e68557c074c5ab380f3","unresolved":false,"context_lines":[{"line_number":1584,"context_line":"           help\u003d\u0027New name for backup.\u0027)"},{"line_number":1585,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1586,"context_line":"           help\u003d\u0027Backup description. Default\u003dNone.\u0027)"},{"line_number":1587,"context_line":"@utils.service_type(\u0027volumev3.7\u0027)"},{"line_number":1588,"context_line":"def do_backup_rename(cs, args):"},{"line_number":1589,"context_line":"    \"\"\"Renames a backup.\"\"\""},{"line_number":1590,"context_line":"    kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_c76e71c8","line":1587,"range":{"start_line":1587,"start_character":0,"end_line":1587,"end_character":33},"in_reply_to":"1aa78d24_e1f70089","updated":"2016-08-04 05:55:57.000000000","message":"Done","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"73d4713bfbb37528c269f68e09f43df5cce87c25","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1586,"context_line":"           help\u003d\u0027Backup description. Default\u003dNone.\u0027)"},{"line_number":1587,"context_line":"@utils.service_type(\u0027volumev3.7\u0027)"},{"line_number":1588,"context_line":"def do_backup_rename(cs, args):"},{"line_number":1589,"context_line":"    \"\"\"Renames a backup.\"\"\""},{"line_number":1590,"context_line":"    kwargs \u003d {}"},{"line_number":1591,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_c155a4fa","line":1588,"range":{"start_line":1588,"start_character":4,"end_line":1588,"end_character":20},"updated":"2016-07-06 09:24:49.000000000","message":"-1: do_backup_update","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6a3d61ffa28bd849f6699e68557c074c5ab380f3","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1586,"context_line":"           help\u003d\u0027Backup description. Default\u003dNone.\u0027)"},{"line_number":1587,"context_line":"@utils.service_type(\u0027volumev3.7\u0027)"},{"line_number":1588,"context_line":"def do_backup_rename(cs, args):"},{"line_number":1589,"context_line":"    \"\"\"Renames a backup.\"\"\""},{"line_number":1590,"context_line":"    kwargs \u003d {}"},{"line_number":1591,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_a771bdaa","line":1588,"range":{"start_line":1588,"start_character":4,"end_line":1588,"end_character":20},"in_reply_to":"1aa78d24_c155a4fa","updated":"2016-08-04 05:55:57.000000000","message":"Done","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"}],"cinderclient/v3/volume_backups.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"3c9f4c4004572a455ed91dd1a2f23860d82f947c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        resp, body \u003d self.api.client.post(\"/backups/import_record\", body\u003dbody)"},{"line_number":132,"context_line":"        return common_base.DictWithMeta(body[\u0027backup\u0027], resp)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def update(self, backup, **kwargs):"},{"line_number":135,"context_line":"        \"\"\"Update the name or description for a backup."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param backup: The :class:`Backup` to update."}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_fb74adfe","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":14},"updated":"2016-06-30 09:20:20.000000000","message":"I think we need to add some test for this function, just like codes here[1].\n\nPlease pay attention to such code in[1]: \nself._assert_request_id(xxxx)\n\n[1] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/tests/unit/v2/test_volumes.py#L24","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6a3d61ffa28bd849f6699e68557c074c5ab380f3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        resp, body \u003d self.api.client.post(\"/backups/import_record\", body\u003dbody)"},{"line_number":132,"context_line":"        return common_base.DictWithMeta(body[\u0027backup\u0027], resp)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def update(self, backup, **kwargs):"},{"line_number":135,"context_line":"        \"\"\"Update the name or description for a backup."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param backup: The :class:`Backup` to update."}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_27b5cd30","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":14},"in_reply_to":"1aa78d24_c142c467","updated":"2016-08-04 05:55:57.000000000","message":"Done","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"73d4713bfbb37528c269f68e09f43df5cce87c25","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        resp, body \u003d self.api.client.post(\"/backups/import_record\", body\u003dbody)"},{"line_number":132,"context_line":"        return common_base.DictWithMeta(body[\u0027backup\u0027], resp)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def update(self, backup, **kwargs):"},{"line_number":135,"context_line":"        \"\"\"Update the name or description for a backup."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param backup: The :class:`Backup` to update."}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_c142c467","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":14},"in_reply_to":"3aaa91ec_fb74adfe","updated":"2016-07-06 09:24:49.000000000","message":"-1: I agree, we should have these tests in cinder/tests/unit/v3/test_volume_backups.py","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6a3d61ffa28bd849f6699e68557c074c5ab380f3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        resp, body \u003d self.api.client.post(\"/backups/import_record\", body\u003dbody)"},{"line_number":132,"context_line":"        return common_base.DictWithMeta(body[\u0027backup\u0027], resp)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def update(self, backup, **kwargs):"},{"line_number":135,"context_line":"        \"\"\"Update the name or description for a backup."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param backup: The :class:`Backup` to update."}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_e7aa95d1","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":14},"in_reply_to":"3aaa91ec_fb74adfe","updated":"2016-08-04 05:55:57.000000000","message":"Done","commit_id":"9978bb7ecf764760bb0a4056cfa94506f303b3f1"}]}