)]}'
{"id":"openstack%2Fpython-cinderclient~265583","triplet_id":"openstack%2Fpython-cinderclient~master~I755702d0f6e982d7cba173fbbdb86feb8ab384a0","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1268480","hashtags":[],"change_id":"I755702d0f6e982d7cba173fbbdb86feb8ab384a0","subject":"Replace assertTrue(isinstance()) by optimal assert","status":"MERGED","created":"2016-01-09 19:18:52.000000000","updated":"2016-06-06 07:18:57.000000000","submitted":"2016-06-06 07:18:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"abdd674449b32925da45decdce426cc84be557a5","_number":265583,"virtual_id_number":265583,"owner":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":2,"date":"2016-06-06 07:18:57.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2016-05-28 01:15:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2016-03-11 12:58:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-03-01 14:49:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":1,"date":"2016-01-11 05:25:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":2,"date":"2016-06-06 06:17:11.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":1,"date":"2016-01-14 07:42:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},{"value":1,"date":"2016-01-10 04:49:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":1,"date":"2016-06-06 06:17:11.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-10 04:49:05.000000000","updated_by":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"reviewer":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"state":"REVIEWER"},{"updated":"2016-01-11 05:25:32.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2016-01-14 07:42:11.000000000","updated_by":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"reviewer":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"state":"REVIEWER"},{"updated":"2016-03-01 14:49:55.000000000","updated_by":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"reviewer":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"state":"REVIEWER"},{"updated":"2016-03-11 12:58:23.000000000","updated_by":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"reviewer":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"state":"REVIEWER"},{"updated":"2016-05-28 01:15:48.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2016-06-06 06:17:11.000000000","updated_by":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"reviewer":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"state":"REVIEWER"},{"updated":"2016-06-06 07:18:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"44654d2fcf9fe6d841f79d62fa7bb38689eee956","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-01-09 19:18:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c9052b44aeeea64591887b2850e7e8880a8768c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-09 20:41:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-pep8/e4f0bd7/ : SUCCESS in 1m 09s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/83/265583/1/check/gate-python-cinderclient-docs/8e44d7e//doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-cinderclient-python27 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-python27/e256aae/ : SUCCESS in 1m 18s\n- gate-python-cinderclient-python34 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-python34/ec84875/ : SUCCESS in 1m 47s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/83/265583/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/b70dc13/ : SUCCESS in 1h 22m 09s\n- gate-python-cinderclient-pypy http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-pypy/bae6249/ : SUCCESS in 1m 56s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/83/265583/1/check/gate-cinderclient-dsvm-functional/7fcf8bd/ : SUCCESS in 32m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"88ed4d6a8677c17ddec8d18dfd44cf4a0b6231f7","author":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"date":"2016-01-10 04:49:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9b366f79a62031cb432b2b48876cd8c629887273","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2016-01-11 05:25:32.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6a0b7d6435073f38ded0a585d5cbf5560ff59bab","author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"date":"2016-01-14 07:42:11.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a7350c0b6e1367adf548a6ab94c634379aeb6513","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2016-03-01 14:49:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9d65fd360a9a39c8c56340dbd150c49a46f8fa8e","author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"date":"2016-03-11 02:51:17.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9debf2b9d5d995aed4c7806c8aaab02d0002ccc7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-11 03:52:32.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-pep8/5149b15/ : SUCCESS in 3m 00s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/83/265583/1/check/gate-python-cinderclient-docs/a93a5c9//doc/build/html/ : SUCCESS in 1m 30s\n- gate-python-cinderclient-python27 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-python27/035bdc6/ : SUCCESS in 3m 00s\n- gate-python-cinderclient-python34 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-python34/0b9163e/ : SUCCESS in 5m 24s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/83/265583/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/60881f9/ : SUCCESS in 1h 00m 40s\n- gate-python-cinderclient-pypy http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-pypy/f274a12/ : SUCCESS in 4m 17s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/83/265583/1/check/gate-cinderclient-dsvm-functional/8065fda/ : SUCCESS in 12m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4bb7010bba5fc8b81013eff699784e23640938f3","author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"date":"2016-03-11 12:58:23.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4e340cb6a0b8749959f32eb2d390989c8d69e06d","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-05-18 04:03:44.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0d2d84103328c23ec7d23ef7477a2a1d4fd5487a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-18 05:10:50.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/83/265583/1/check/gate-python-cinderclient-docs/e5860e8//doc/build/html/ : SUCCESS in 1m 54s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-pep8/a5ab3e9/ : SUCCESS in 2m 18s\n- gate-python-cinderclient-python27 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-python27/1709ff0/ : SUCCESS in 2m 49s\n- gate-python-cinderclient-python34 http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-python34/6ebbf7a/ : SUCCESS in 2m 45s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/83/265583/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/fcf3dd5/ : SUCCESS in 1h 03m 18s\n- gate-python-cinderclient-pypy http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-pypy/49c4ef8/ : FAILURE in 1m 51s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/83/265583/1/check/gate-cinderclient-dsvm-functional/2d25035/ : SUCCESS in 20m 42s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/83/265583/1/check/gate-python-cinderclient-pylint/9d4fb0c/ : SUCCESS in 1m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c2a6f619df26f505b4833e657b8c3dabec7ea706","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-05-28 01:15:48.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks fine to me.","accounts_in_message":[],"_revision_number":1},{"id":"da3255266e59fc41ea5716bdc247871e9313b12d","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2016-06-06 06:17:11.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"59ca605414b5818c447d4b700f9195d8e10f8714","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-06 06:17:21.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6b425252d6995b1c57a69ceb733fbe8ea0b2dc2b","date":"2016-06-06 07:18:57.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"ee4cbbcdf9d1296716033d83382ca73595193a70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-06 07:18:57.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/83/265583/1/gate/gate-python-cinderclient-docs/d385560//doc/build/html/ : SUCCESS in 3m 07s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/83/265583/1/gate/gate-python-cinderclient-pep8/5d3f18f/ : SUCCESS in 4m 33s\n- gate-python-cinderclient-python27 http://logs.openstack.org/83/265583/1/gate/gate-python-cinderclient-python27/67a943a/ : SUCCESS in 4m 49s\n- gate-python-cinderclient-python34 http://logs.openstack.org/83/265583/1/gate/gate-python-cinderclient-python34/cd45950/ : SUCCESS in 3m 41s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/83/265583/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/25caa2d/ : SUCCESS in 1h 01m 15s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c297309aff29df550633ab956b99bb3d74c7f43c","revisions":{"c297309aff29df550633ab956b99bb3d74c7f43c":{"kind":"REWORK","_number":1,"created":"2016-01-09 19:18:52.000000000","uploader":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"ref":"refs/changes/83/265583/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/83/265583/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/83/265583/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/83/265583/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/83/265583/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/83/265583/1"}}},"commit":{"parents":[{"commit":"7476dbd8dcae331d63d034eb0d725e3edc1aee06","subject":"Merge \"Add to_dict method to Resource class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/7476dbd8dcae331d63d034eb0d725e3edc1aee06"}]}],"author":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-09 19:18:08.000000000","tz":480},"committer":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-09 19:18:08.000000000","tz":480},"subject":"Replace assertTrue(isinstance()) by optimal assert","message":"Replace assertTrue(isinstance()) by optimal assert\n\nassertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests\nshould be replaced by assertIsInstance(A, B) provided by testtools.\nRelated-bug: #1268480\n\nChange-Id: I755702d0f6e982d7cba173fbbdb86feb8ab384a0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c297309aff29df550633ab956b99bb3d74c7f43c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c297309aff29df550633ab956b99bb3d74c7f43c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}