)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"79ce0d041fa9d55cc064cea75e2af3dbdf531e68","unresolved":false,"context_lines":[{"line_number":1481,"context_line":"@utils.arg(\u0027--volume-id\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1482,"context_line":"           default\u003dNone,"},{"line_number":1483,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1484,"context_line":"@utils.arg(\u0027--volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1485,"context_line":"           default\u003dNone,"},{"line_number":1486,"context_line":"           help\u003d\u0027Name or ID of existing volume to which to restore. \u0027"},{"line_number":1487,"context_line":"           \u0027Default\u003dNone.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_7eddc813","line":1484,"updated":"2016-05-18 21:14:22.000000000","message":"Help should state that --volume is mutually exclusive with --name","commit_id":"aef01beecca12afdd8ddb1f5af1e67db37f9e912"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"79ce0d041fa9d55cc064cea75e2af3dbdf531e68","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"           \u0027Default\u003dNone.\u0027)"},{"line_number":1488,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1489,"context_line":"           default\u003dNone,"},{"line_number":1490,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1491,"context_line":"                \u0027Default\u003dNone.\u0027)"},{"line_number":1492,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1493,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_beb0d0de","line":1490,"updated":"2016-05-18 21:14:22.000000000","message":"Help should state that --name is mutually exclusive with --volume","commit_id":"aef01beecca12afdd8ddb1f5af1e67db37f9e912"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"00110d1fb1bed4d9ab064c00d7e9f2428d8972a6","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1484,"context_line":"@utils.arg(\u0027--volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1485,"context_line":"           default\u003dNone,"},{"line_number":1486,"context_line":"           help\u003d\u0027Name or ID of existing volume to which to restore. \u0027"},{"line_number":1487,"context_line":"           \u0027Default\u003dNone.\u0027)"},{"line_number":1488,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1489,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_a352bb10","line":1486,"updated":"2016-05-23 17:21:21.000000000","message":"Please add:\n\"This is mutually exclusive with --name and takes priority.\"\nThis should be here, in the help, so a user can see it.","commit_id":"13fddcafa49b2af2e6ec2726065564c76f0bacd4"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"c34a0d97b7a3987353778ecd3b278466441c928a","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1484,"context_line":"@utils.arg(\u0027--volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1485,"context_line":"           default\u003dNone,"},{"line_number":1486,"context_line":"           help\u003d\u0027Name or ID of existing volume to which to restore. \u0027"},{"line_number":1487,"context_line":"           \u0027Default\u003dNone.\u0027)"},{"line_number":1488,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1489,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_5a49dbb6","line":1486,"in_reply_to":"bab6814e_a352bb10","updated":"2016-05-25 04:47:59.000000000","message":"Good suggestion. Thanks.","commit_id":"13fddcafa49b2af2e6ec2726065564c76f0bacd4"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"00110d1fb1bed4d9ab064c00d7e9f2428d8972a6","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"           \u0027Default\u003dNone.\u0027)"},{"line_number":1488,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1489,"context_line":"           default\u003dNone,"},{"line_number":1490,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1491,"context_line":"           \u0027The --volume option takes priority if it is specified \u0027"},{"line_number":1492,"context_line":"           \u0027with this option. Default\u003dNone.\u0027)"},{"line_number":1493,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_63b8d311","line":1490,"updated":"2016-05-23 17:21:21.000000000","message":"Please add:\n\"This is mutually exclusive with --volume and --volume takes priority.\"\nThis should be here, in the help, so a user can see it.","commit_id":"13fddcafa49b2af2e6ec2726065564c76f0bacd4"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"c34a0d97b7a3987353778ecd3b278466441c928a","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"           \u0027Default\u003dNone.\u0027)"},{"line_number":1488,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1489,"context_line":"           default\u003dNone,"},{"line_number":1490,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1491,"context_line":"           \u0027The --volume option takes priority if it is specified \u0027"},{"line_number":1492,"context_line":"           \u0027with this option. Default\u003dNone.\u0027)"},{"line_number":1493,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_fa988f6c","line":1490,"in_reply_to":"bab6814e_63b8d311","updated":"2016-05-25 04:47:59.000000000","message":"ditto.","commit_id":"13fddcafa49b2af2e6ec2726065564c76f0bacd4"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"00110d1fb1bed4d9ab064c00d7e9f2428d8972a6","unresolved":false,"context_lines":[{"line_number":1488,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1489,"context_line":"           default\u003dNone,"},{"line_number":1490,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1491,"context_line":"           \u0027The --volume option takes priority if it is specified \u0027"},{"line_number":1492,"context_line":"           \u0027with this option. Default\u003dNone.\u0027)"},{"line_number":1493,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1494,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_e3104302","line":1491,"updated":"2016-05-23 17:21:21.000000000","message":"See comment above, I think that is more clear if \"mutually exclusive\" is mentioned, just as in the Debug output.","commit_id":"13fddcafa49b2af2e6ec2726065564c76f0bacd4"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"c34a0d97b7a3987353778ecd3b278466441c928a","unresolved":false,"context_lines":[{"line_number":1488,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1489,"context_line":"           default\u003dNone,"},{"line_number":1490,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1491,"context_line":"           \u0027The --volume option takes priority if it is specified \u0027"},{"line_number":1492,"context_line":"           \u0027with this option. Default\u003dNone.\u0027)"},{"line_number":1493,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1494,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_bac60714","line":1491,"in_reply_to":"bab6814e_e3104302","updated":"2016-05-25 04:47:59.000000000","message":"Done","commit_id":"13fddcafa49b2af2e6ec2726065564c76f0bacd4"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"d5d4d22dbdd4573d0611b2dd766e9e061437efea","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027,"},{"line_number":1480,"context_line":"           help\u003d\u0027ID of backup to restore.\u0027)"},{"line_number":1481,"context_line":"@utils.arg(\u0027--volume-id\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1482,"context_line":"           default\u003dNone,"},{"line_number":1483,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1484,"context_line":"@utils.arg(\u0027--volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1485,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_7bce41b5","line":1482,"range":{"start_line":1482,"start_character":11,"end_line":1482,"end_character":23},"updated":"2016-05-31 03:15:57.000000000","message":"same as below comment","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"d5d4d22dbdd4573d0611b2dd766e9e061437efea","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"           default\u003dNone,"},{"line_number":1483,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1484,"context_line":"@utils.arg(\u0027--volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":1485,"context_line":"           default\u003dNone,"},{"line_number":1486,"context_line":"           help\u003d\u0027Name or ID of existing volume to which to restore. \u0027"},{"line_number":1487,"context_line":"           \u0027This is mutually exclusive with --name and takes priority. \u0027"},{"line_number":1488,"context_line":"           \u0027Default\u003dNone.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_3bd4b945","line":1485,"range":{"start_line":1485,"start_character":11,"end_line":1485,"end_character":23},"updated":"2016-05-31 03:15:57.000000000","message":"same as below comment","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"d5d4d22dbdd4573d0611b2dd766e9e061437efea","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"           \u0027This is mutually exclusive with --name and takes priority. \u0027"},{"line_number":1488,"context_line":"           \u0027Default\u003dNone.\u0027)"},{"line_number":1489,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1490,"context_line":"           default\u003dNone,"},{"line_number":1491,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1492,"context_line":"           \u0027This is mutually exclusive with --volume and --volume \u0027"},{"line_number":1493,"context_line":"           \u0027takes priority. Default\u003dNone.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_7bf761f5","line":1490,"range":{"start_line":1490,"start_character":11,"end_line":1490,"end_character":24},"updated":"2016-05-31 03:15:57.000000000","message":"We dont need \"default\u003dNone\" here as by default if an optional argument isn’t specified, it gets the None value.\n\nDefault arg by default have None value, so no need to specify explicitely.","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"aa93a8fdfb258e4cb6a8409ce5980d8fa1285f12","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"           \u0027This is mutually exclusive with --name and takes priority. \u0027"},{"line_number":1488,"context_line":"           \u0027Default\u003dNone.\u0027)"},{"line_number":1489,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1490,"context_line":"           default\u003dNone,"},{"line_number":1491,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1492,"context_line":"           \u0027This is mutually exclusive with --volume and --volume \u0027"},{"line_number":1493,"context_line":"           \u0027takes priority. Default\u003dNone.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_aaaedee4","line":1490,"range":{"start_line":1490,"start_character":11,"end_line":1490,"end_character":24},"in_reply_to":"9abb7d3a_49bd7767","updated":"2016-06-02 19:41:44.000000000","message":"I think even if the default value is set to None, I think it is OK to set this value explicitely since there are other parameters have same definition too.","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"620ffcd08f15df630b5117e04d003836715e4110","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"           \u0027This is mutually exclusive with --name and takes priority. \u0027"},{"line_number":1488,"context_line":"           \u0027Default\u003dNone.\u0027)"},{"line_number":1489,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1490,"context_line":"           default\u003dNone,"},{"line_number":1491,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1492,"context_line":"           \u0027This is mutually exclusive with --volume and --volume \u0027"},{"line_number":1493,"context_line":"           \u0027takes priority. Default\u003dNone.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_49bd7767","line":1490,"range":{"start_line":1490,"start_character":11,"end_line":1490,"end_character":24},"in_reply_to":"9abb7d3a_7bf761f5","updated":"2016-05-31 04:27:32.000000000","message":"Oh, it seems you want to keep it for \"--name\" in case no value is passed to it.\nIf so, its ok to ignore.\n(same for above 2 comments)","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"4f494f29dcdc74278a24a245ff16c944366d3681","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1490,"context_line":"           default\u003dNone,"},{"line_number":1491,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1492,"context_line":"           \u0027This is mutually exclusive with --volume and --volume \u0027"},{"line_number":1493,"context_line":"           \u0027takes priority. Default\u003dNone.\u0027)"},{"line_number":1494,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1495,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_b45d3c7b","line":1492,"range":{"start_line":1492,"start_character":57,"end_line":1492,"end_character":65},"updated":"2016-05-31 13:33:16.000000000","message":"--volume and --volume-id","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"b0b689f4461a40d2d9f4a74045be8fd90165049f","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1490,"context_line":"           default\u003dNone,"},{"line_number":1491,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1492,"context_line":"           \u0027This is mutually exclusive with --volume and --volume \u0027"},{"line_number":1493,"context_line":"           \u0027takes priority. Default\u003dNone.\u0027)"},{"line_number":1494,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1495,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_993c7130","line":1492,"range":{"start_line":1492,"start_character":57,"end_line":1492,"end_character":65},"in_reply_to":"9abb7d3a_635b812f","updated":"2016-06-14 13:59:18.000000000","message":"Hum, OK, I was confused with the repetition. It\u0027s clear now. Thanks Scott.","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"cd837e4700c7bcbbb534f176390666bbe4f40d3c","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1490,"context_line":"           default\u003dNone,"},{"line_number":1491,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1492,"context_line":"           \u0027This is mutually exclusive with --volume and --volume \u0027"},{"line_number":1493,"context_line":"           \u0027takes priority. Default\u003dNone.\u0027)"},{"line_number":1494,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1495,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_635b812f","line":1492,"range":{"start_line":1492,"start_character":57,"end_line":1492,"end_character":65},"in_reply_to":"9abb7d3a_8d85f4ae","updated":"2016-06-02 20:14:45.000000000","message":"It is a 2-line sentence:\nThis is mutually exclusive with --volume and --volume takes priority.\nIt shouldn\u0027t be --volume-id, but we repeat \u0027--volume\u0027 because it is what takes priority.\nIf we want to include the deprecated \u0027volume-id\u0027, the sentence would read:\nThis is mutually exclusive with --volume (and the deprecated --volume-id) and --volume (or --volume-id) takes priority.","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"aa93a8fdfb258e4cb6a8409ce5980d8fa1285f12","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1490,"context_line":"           default\u003dNone,"},{"line_number":1491,"context_line":"           help\u003d\u0027Use the name for new volume creation to restore. \u0027"},{"line_number":1492,"context_line":"           \u0027This is mutually exclusive with --volume and --volume \u0027"},{"line_number":1493,"context_line":"           \u0027takes priority. Default\u003dNone.\u0027)"},{"line_number":1494,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1495,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_8d85f4ae","line":1492,"range":{"start_line":1492,"start_character":57,"end_line":1492,"end_character":65},"in_reply_to":"9abb7d3a_b45d3c7b","updated":"2016-06-02 19:41:44.000000000","message":"In my opinion, we don\u0027t need to show --volume-id at other places because it is suppressed option.","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"d5d4d22dbdd4573d0611b2dd766e9e061437efea","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"    vol \u003d args.volume or args.volume_id"},{"line_number":1498,"context_line":"    if vol:"},{"line_number":1499,"context_line":"        volume_id \u003d utils.find_volume(cs, vol).id"},{"line_number":1500,"context_line":"        if args.name:"},{"line_number":1501,"context_line":"            args.name \u003d None"},{"line_number":1502,"context_line":"            print(\"Mutually exclusive options are specified \""},{"line_number":1503,"context_line":"                  \"(--volume and --name) simultaneously. The \""},{"line_number":1504,"context_line":"                  \"--volume option takes priority.\")"},{"line_number":1505,"context_line":"    else:"},{"line_number":1506,"context_line":"        volume_id \u003d None"},{"line_number":1507,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_5bc89d22","line":1504,"range":{"start_line":1500,"start_character":0,"end_line":1504,"end_character":52},"updated":"2016-05-31 03:15:57.000000000","message":"We need not to specify that we will consider vol id not name, this is already part of help message that these are mutually exclusive and volume has priority. \n\nAlso, We need not to check whether args.name was specified or not, just simply assign None and go ahead.. :)\nWe can directly use \n\nif vol:\n    volume_id \u003d utils.find_volume(cs, vol).id\n    args.name \u003d None\nelse:\n    volume_id \u003d None","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2ac8a593015e23783c18df2ccec7adf6ac8f8f01","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"    vol \u003d args.volume or args.volume_id"},{"line_number":1498,"context_line":"    if vol:"},{"line_number":1499,"context_line":"        volume_id \u003d utils.find_volume(cs, vol).id"},{"line_number":1500,"context_line":"        if args.name:"},{"line_number":1501,"context_line":"            args.name \u003d None"},{"line_number":1502,"context_line":"            print(\"Mutually exclusive options are specified \""},{"line_number":1503,"context_line":"                  \"(--volume and --name) simultaneously. The \""},{"line_number":1504,"context_line":"                  \"--volume option takes priority.\")"},{"line_number":1505,"context_line":"    else:"},{"line_number":1506,"context_line":"        volume_id \u003d None"},{"line_number":1507,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_dc7bcc26","line":1504,"range":{"start_line":1500,"start_character":0,"end_line":1504,"end_character":52},"in_reply_to":"9abb7d3a_5bc89d22","updated":"2016-05-31 12:46:59.000000000","message":"I disagree, this is the equivalent of LOG.warning and I think it should be here.\n\n-1: Message may not be correct, what if they specified --volume-id instead of --volume?","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"de395d550b19e78ddb8ce6116d82ed6806682661","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"    vol \u003d args.volume or args.volume_id"},{"line_number":1498,"context_line":"    if vol:"},{"line_number":1499,"context_line":"        volume_id \u003d utils.find_volume(cs, vol).id"},{"line_number":1500,"context_line":"        if args.name:"},{"line_number":1501,"context_line":"            args.name \u003d None"},{"line_number":1502,"context_line":"            print(\"Mutually exclusive options are specified \""},{"line_number":1503,"context_line":"                  \"(--volume and --name) simultaneously. The \""},{"line_number":1504,"context_line":"                  \"--volume option takes priority.\")"},{"line_number":1505,"context_line":"    else:"},{"line_number":1506,"context_line":"        volume_id \u003d None"},{"line_number":1507,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_fe9ee461","line":1504,"range":{"start_line":1500,"start_character":0,"end_line":1504,"end_character":52},"in_reply_to":"9abb7d3a_a31c4914","updated":"2016-06-02 20:34:10.000000000","message":"Thanks. I understand your intention. I\u0027ll take your idea for here and help message.","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"cd837e4700c7bcbbb534f176390666bbe4f40d3c","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"    vol \u003d args.volume or args.volume_id"},{"line_number":1498,"context_line":"    if vol:"},{"line_number":1499,"context_line":"        volume_id \u003d utils.find_volume(cs, vol).id"},{"line_number":1500,"context_line":"        if args.name:"},{"line_number":1501,"context_line":"            args.name \u003d None"},{"line_number":1502,"context_line":"            print(\"Mutually exclusive options are specified \""},{"line_number":1503,"context_line":"                  \"(--volume and --name) simultaneously. The \""},{"line_number":1504,"context_line":"                  \"--volume option takes priority.\")"},{"line_number":1505,"context_line":"    else:"},{"line_number":1506,"context_line":"        volume_id \u003d None"},{"line_number":1507,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_a31c4914","line":1504,"range":{"start_line":1500,"start_character":0,"end_line":1504,"end_character":52},"in_reply_to":"9abb7d3a_a836e6e4","updated":"2016-06-02 20:14:45.000000000","message":"Yes, this message should be here.\nBut it\u0027s a mess due to --volume-id. If it\u0027s deprecated, we should say so in the help instead of suppressing. And the message should use --volume-id as long as it is supported.\nIt is very messy....","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"4f494f29dcdc74278a24a245ff16c944366d3681","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"    vol \u003d args.volume or args.volume_id"},{"line_number":1498,"context_line":"    if vol:"},{"line_number":1499,"context_line":"        volume_id \u003d utils.find_volume(cs, vol).id"},{"line_number":1500,"context_line":"        if args.name:"},{"line_number":1501,"context_line":"            args.name \u003d None"},{"line_number":1502,"context_line":"            print(\"Mutually exclusive options are specified \""},{"line_number":1503,"context_line":"                  \"(--volume and --name) simultaneously. The \""},{"line_number":1504,"context_line":"                  \"--volume option takes priority.\")"},{"line_number":1505,"context_line":"    else:"},{"line_number":1506,"context_line":"        volume_id \u003d None"},{"line_number":1507,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_947bd8f4","line":1504,"range":{"start_line":1500,"start_character":0,"end_line":1504,"end_character":52},"in_reply_to":"9abb7d3a_dc7bcc26","updated":"2016-05-31 13:33:16.000000000","message":"+1 Gorka","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"c7f2e82e3961acc18c9d5574f6b8741a81c52612","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"    vol \u003d args.volume or args.volume_id"},{"line_number":1498,"context_line":"    if vol:"},{"line_number":1499,"context_line":"        volume_id \u003d utils.find_volume(cs, vol).id"},{"line_number":1500,"context_line":"        if args.name:"},{"line_number":1501,"context_line":"            args.name \u003d None"},{"line_number":1502,"context_line":"            print(\"Mutually exclusive options are specified \""},{"line_number":1503,"context_line":"                  \"(--volume and --name) simultaneously. The \""},{"line_number":1504,"context_line":"                  \"--volume option takes priority.\")"},{"line_number":1505,"context_line":"    else:"},{"line_number":1506,"context_line":"        volume_id \u003d None"},{"line_number":1507,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_a836e6e4","line":1504,"range":{"start_line":1500,"start_character":0,"end_line":1504,"end_character":52},"in_reply_to":"9abb7d3a_dc7bcc26","updated":"2016-06-02 19:45:08.000000000","message":"As Gorka mentioned, this is warning message for user, so I also think this should be here.","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"aa93a8fdfb258e4cb6a8409ce5980d8fa1285f12","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"    vol \u003d args.volume or args.volume_id"},{"line_number":1498,"context_line":"    if vol:"},{"line_number":1499,"context_line":"        volume_id \u003d utils.find_volume(cs, vol).id"},{"line_number":1500,"context_line":"        if args.name:"},{"line_number":1501,"context_line":"            args.name \u003d None"},{"line_number":1502,"context_line":"            print(\"Mutually exclusive options are specified \""},{"line_number":1503,"context_line":"                  \"(--volume and --name) simultaneously. The \""},{"line_number":1504,"context_line":"                  \"--volume option takes priority.\")"},{"line_number":1505,"context_line":"    else:"},{"line_number":1506,"context_line":"        volume_id \u003d None"},{"line_number":1507,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_adf7188b","line":1504,"range":{"start_line":1500,"start_character":0,"end_line":1504,"end_character":52},"in_reply_to":"9abb7d3a_dc7bcc26","updated":"2016-06-02 19:41:44.000000000","message":"Hi Gorka,\n\nIf --volume-id is specified with --name, --volume-id takes priority same as --volume.\n\nSince the --volume-id is suppressed(not displayed in help message) and might be deprecated in the future, I thought we don\u0027t need to show --volume-id this warning message.\n\nAny idea?","commit_id":"5dc02d330a7ce82bb3528730f2cb8388f6bdf047"}]}