)]}'
{"id":"openstack%2Fpython-cinderclient~282075","triplet_id":"openstack%2Fpython-cinderclient~master~I887cef64490037b17dbea5d82b099324b5fe9d58","project":"openstack/python-cinderclient","branch":"master","hashtags":[],"change_id":"I887cef64490037b17dbea5d82b099324b5fe9d58","subject":"Add extra_specs_list test","status":"MERGED","created":"2016-02-18 22:11:19.000000000","updated":"2016-02-25 18:18:48.000000000","submitted":"2016-02-25 18:18:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"67e0c245aeb939e5326174a59f1d603d1fd11e52","_number":282075,"virtual_id_number":282075,"owner":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2016-02-25 18:18:48.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2016-02-23 20:13:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-02-24 15:13:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":1,"date":"2016-02-19 15:47:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":2,"date":"2016-02-25 03:24:03.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":1,"date":"2016-02-25 03:24:03.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-19 15:47:22.000000000","updated_by":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"reviewer":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"state":"REVIEWER"},{"updated":"2016-02-23 20:13:50.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2016-02-24 15:13:32.000000000","updated_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"reviewer":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"state":"REVIEWER"},{"updated":"2016-02-25 03:24:03.000000000","updated_by":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"reviewer":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"state":"REVIEWER"},{"updated":"2016-02-25 18:18:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"922d1c54d26e7bcaa9f7c9db09a1c17b81056ee5","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2016-02-18 22:11:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d0f9aa07790bf9b3b873cf727e8146cd3448de53","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2016-02-18 22:11:58.000000000","message":"Patch Set 1:\n\nI wrote this because this patch breaks this command, but unit tests pass:\n\nhttps://review.openstack.org/#/c/281475/3","accounts_in_message":[],"_revision_number":1},{"id":"b1d1f0eb69ed6a26992e5f9b38d7027f44232922","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-19 01:11:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/75/282075/1/check/gate-python-cinderclient-pep8/dc47274/ : SUCCESS in 46s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/75/282075/1/check/gate-python-cinderclient-docs/24b42a7//doc/build/html/ : SUCCESS in 44s\n- gate-python-cinderclient-python27 http://logs.openstack.org/75/282075/1/check/gate-python-cinderclient-python27/7c5f63b/ : SUCCESS in 50s\n- gate-python-cinderclient-python34 http://logs.openstack.org/75/282075/1/check/gate-python-cinderclient-python34/95b34fb/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/75/282075/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/6d72b72/ : SUCCESS in 1h 05m 16s\n- gate-python-cinderclient-pypy http://logs.openstack.org/75/282075/1/check/gate-python-cinderclient-pypy/21e4288/ : SUCCESS in 1m 43s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/75/282075/1/check/gate-cinderclient-dsvm-functional/e05c248/ : SUCCESS in 15m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ad264e3926a3211586f7405a7d5697d820507ac2","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-02-19 09:01:30.000000000","message":"Patch Set 1:\n\n\u003e I wrote this because this patch breaks this command, but unit tests\n \u003e pass:\n \u003e \n \u003e https://review.openstack.org/#/c/281475/3\n\nThis test makes sense, but why wouldn\u0027t you just add a test in\ncinderclient/tests/unit/test_utils.py as this is intended to test\nthe utils.print_list() function.\nMay be like this:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\ncinderclient/tests/unit/test_utils.py:\nclass PrintListTestCase(test_utils.TestCase):\n    def test_print_list_with_list_contains_dict(self):\n        Row \u003d collections.namedtuple(\u0027Row\u0027, [\u0027a\u0027, \u0027b\u0027])\n        to_print \u003d [Row(a\u003d3, b\u003d{}), Row(a\u003d1, b\u003d{\u0027a\u0027:\u0027b\u0027})]\n        with CaptureStdout() as cso:\n            utils.print_list(to_print, [\u0027a\u0027, \u0027b\u0027])\n        # Output should be sorted by the first key (a)\n        self.assertEqual(\"\"\"\\\n+---+------------+\n| a |     b      |\n+---+------------+\n| 1 | {\u0027a\u0027: \u0027b\u0027} |\n| 3 |     {}     |\n+---+------------+\n\"\"\", cso.read())\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d","accounts_in_message":[],"_revision_number":1},{"id":"bb12bc103e1298946fdf40b24ea22797326a13fc","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2016-02-19 15:12:12.000000000","message":"Patch Set 1:\n\nThis mirrors most of the other tests in this file and is useful even as a simple check.\n\nWe could do something like this, but I\u0027m not sure we want to be in the business of testing the exact output of prettytable.","accounts_in_message":[],"_revision_number":1},{"id":"19634f7c25714e45509e0194e437e970585444d6","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-02-19 15:47:22.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4ba1db946c11f64ec2b69a3c4a82127fd2ad433b","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-02-23 20:13:50.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks good to me.","accounts_in_message":[],"_revision_number":1},{"id":"1cbefc82efdd172abc4c3f59309a0a8b18500313","author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"date":"2016-02-24 15:13:32.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks good to me. Thanks for upping our code coverage Eric!","accounts_in_message":[],"_revision_number":1},{"id":"b306035997483b9ad3a252a685129bced408fb26","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2016-02-25 03:24:03.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4ecd04773222139ff1ea2016474f556b814a758a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 03:24:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1bbb855927fc06b5a90c208ca3d8c510db79b3a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 05:19:04.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/75/282075/1/gate/gate-python-cinderclient-docs/e630aba//doc/build/html/ : SUCCESS in 29s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/75/282075/1/gate/gate-python-cinderclient-pep8/a463311/ : SUCCESS in 43s\n- gate-python-cinderclient-python27 http://logs.openstack.org/75/282075/1/gate/gate-python-cinderclient-python27/2ef0333/ : SUCCESS in 57s\n- gate-python-cinderclient-python34 http://logs.openstack.org/75/282075/1/gate/gate-python-cinderclient-python34/2f6c564/ : SUCCESS in 4m 13s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/75/282075/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/5c55440/ : FAILURE in 24m 41s","accounts_in_message":[],"_revision_number":1},{"id":"39d59041696394279bc9b0207ec7a261028a1961","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-02-25 14:50:40.000000000","message":"Patch Set 1:\n\nreverify","accounts_in_message":[],"_revision_number":1},{"id":"f6ac201aa9c2bec64692b4bdd6d8130d9880bddc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 17:04:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/75/282075/1/check/gate-python-cinderclient-pep8/584201b/ : SUCCESS in 1m 18s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/75/282075/1/check/gate-python-cinderclient-docs/a5b9d65//doc/build/html/ : SUCCESS in 2m 57s\n- gate-python-cinderclient-python27 http://logs.openstack.org/75/282075/1/check/gate-python-cinderclient-python27/834d986/ : SUCCESS in 2m 08s\n- gate-python-cinderclient-python34 http://logs.openstack.org/75/282075/1/check/gate-python-cinderclient-python34/c65598a/ : SUCCESS in 2m 46s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/75/282075/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/5074c66/ : SUCCESS in 1h 19m 31s\n- gate-python-cinderclient-pypy http://logs.openstack.org/75/282075/1/check/gate-python-cinderclient-pypy/1152661/ : SUCCESS in 1m 43s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/75/282075/1/check/gate-cinderclient-dsvm-functional/19dbf52/ : SUCCESS in 26m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7793feb3cc8c91f3552b2618804640b1e3a32c27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 17:04:44.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"db5b99ddf8bb3ff85a4b20d78bbeb2d13a5e2a05","date":"2016-02-25 18:18:48.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"67e0c245aeb939e5326174a59f1d603d1fd11e52","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 18:18:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/75/282075/1/gate/gate-python-cinderclient-docs/289fda5//doc/build/html/ : SUCCESS in 46s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/75/282075/1/gate/gate-python-cinderclient-pep8/5f9ae47/ : SUCCESS in 54s\n- gate-python-cinderclient-python27 http://logs.openstack.org/75/282075/1/gate/gate-python-cinderclient-python27/ea2eaab/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-python34 http://logs.openstack.org/75/282075/1/gate/gate-python-cinderclient-python34/466ec2d/ : SUCCESS in 2m 30s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/75/282075/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/c1d72d6/ : SUCCESS in 1h 13m 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"befd35bced49fc8b76f2c2ed2ec80bf75265599a","revisions":{"befd35bced49fc8b76f2c2ed2ec80bf75265599a":{"kind":"REWORK","_number":1,"created":"2016-02-18 22:11:19.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/75/282075/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/75/282075/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/75/282075/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/75/282075/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/75/282075/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/75/282075/1"}}},"commit":{"parents":[{"commit":"f88e4da1d6f507e7fe419a049ca46ba3af5df524","subject":"Merge \"Remove openstack-common.conf\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/f88e4da1d6f507e7fe419a049ca46ba3af5df524"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2016-02-18 22:09:53.000000000","tz":-300},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2016-02-18 22:10:15.000000000","tz":-300},"subject":"Add extra_specs_list test","message":"Add extra_specs_list test\n\nThere is no test covering this command.\n\nChange-Id: I887cef64490037b17dbea5d82b099324b5fe9d58\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/befd35bced49fc8b76f2c2ed2ec80bf75265599a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/befd35bced49fc8b76f2c2ed2ec80bf75265599a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}