)]}'
{"id":"openstack%2Fpython-cinderclient~284377","triplet_id":"openstack%2Fpython-cinderclient~master~I449f3df92b3646c384de717b7d53f7f85258c449","project":"openstack/python-cinderclient","branch":"master","topic":"IsInstance_Fixes","hashtags":[],"change_id":"I449f3df92b3646c384de717b7d53f7f85258c449","subject":"Use instanceof instead of type","status":"MERGED","created":"2016-02-24 19:47:23.000000000","updated":"2016-02-29 11:06:55.000000000","submitted":"2016-02-29 11:06:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6d8f2af3f3879ee91a77957cc7a71c57e64aa0b1","_number":284377,"virtual_id_number":284377,"owner":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":2,"date":"2016-02-29 11:06:55.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"recommended":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"all":[{"value":1,"date":"2016-02-25 15:23:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-02-28 08:00:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":2,"date":"2016-02-29 07:02:25.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":2,"date":"2016-02-26 22:50:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"all":[{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":1,"date":"2016-02-29 07:02:25.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-25 15:23:23.000000000","updated_by":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"reviewer":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"state":"REVIEWER"},{"updated":"2016-02-26 22:50:06.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2016-02-28 08:00:29.000000000","updated_by":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"reviewer":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"state":"REVIEWER"},{"updated":"2016-02-29 07:02:25.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2016-02-29 11:06:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e0c7b2eadf57790997f5ece89c2f296e975aa6b0","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-02-24 19:47:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"64933702a266324bf78882f9fb740bd1d9458744","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-24 21:55:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/77/284377/1/check/gate-python-cinderclient-pep8/655cf4f/ : SUCCESS in 50s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/77/284377/1/check/gate-python-cinderclient-docs/8c45c05//doc/build/html/ : SUCCESS in 53s\n- gate-python-cinderclient-python27 http://logs.openstack.org/77/284377/1/check/gate-python-cinderclient-python27/2766ac9/ : SUCCESS in 1m 06s\n- gate-python-cinderclient-python34 http://logs.openstack.org/77/284377/1/check/gate-python-cinderclient-python34/549db7f/ : SUCCESS in 1m 44s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/77/284377/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/f857b9f/ : SUCCESS in 43m 18s\n- gate-python-cinderclient-pypy http://logs.openstack.org/77/284377/1/check/gate-python-cinderclient-pypy/b98e3b8/ : SUCCESS in 1m 56s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/77/284377/1/check/gate-cinderclient-dsvm-functional/eb2e343/ : SUCCESS in 16m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"05e5d66b0334fe205260ce315577abbfc047448c","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-02-25 15:23:23.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks like you got them all.  Great fix!","accounts_in_message":[],"_revision_number":1},{"id":"ffc96d89361dc1eb08b553dcf6531d4b4f189407","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2016-02-26 22:50:06.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks like this should be ok.","accounts_in_message":[],"_revision_number":1},{"id":"6ba2c66d6ab0f09c49a697bffb7814dd00b596e7","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-02-28 06:55:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b8b098f603c958f8000583bc6ecf50cd9844f1c4","author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"date":"2016-02-28 08:00:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ae6b4e3c34cf5f246ecf80d787b36d83245e1e06","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2016-02-29 07:02:25.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"89ac8856377e7616aad472a1add4066865e9ef6e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-29 07:02:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"99a41ed0805d5054253ca8f81cb340be980d3f52","date":"2016-02-29 11:06:55.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"1ebe82f33f77e35a178ee70cf80785294c47fee1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-29 11:06:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/77/284377/1/gate/gate-python-cinderclient-docs/2cdd8b2//doc/build/html/ : SUCCESS in 53s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/77/284377/1/gate/gate-python-cinderclient-pep8/3074133/ : SUCCESS in 39s\n- gate-python-cinderclient-python27 http://logs.openstack.org/77/284377/1/gate/gate-python-cinderclient-python27/3c775c0/ : SUCCESS in 55s\n- gate-python-cinderclient-python34 http://logs.openstack.org/77/284377/1/gate/gate-python-cinderclient-python34/0845cb8/ : SUCCESS in 1m 28s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/77/284377/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/79861b1/ : SUCCESS in 54m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6b5e3d1faa71ce68836f6351996bd3b37854496b","revisions":{"6b5e3d1faa71ce68836f6351996bd3b37854496b":{"kind":"REWORK","_number":1,"created":"2016-02-24 19:47:23.000000000","uploader":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"ref":"refs/changes/77/284377/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/77/284377/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/77/284377/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/77/284377/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/77/284377/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/77/284377/1"}}},"commit":{"parents":[{"commit":"8155d453c85260f7c30cbd719ed65d674b8fb419","subject":"Merge \"Extra \u0027u\u0027 in output of cinder cli commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8155d453c85260f7c30cbd719ed65d674b8fb419"}]}],"author":{"name":"Brandon Palm","email":"bapalm@us.ibm.com","date":"2016-02-24 19:46:39.000000000","tz":-360},"committer":{"name":"Brandon Palm","email":"bapalm@us.ibm.com","date":"2016-02-24 19:46:39.000000000","tz":-360},"subject":"Use instanceof instead of type","message":"Use instanceof instead of type\n\nAdjusted conditional statements to use instanceof when\ncomparing variables. Instanceof supports inheritance type\nchecking better than type.\n\nChange-Id: I449f3df92b3646c384de717b7d53f7f85258c449\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6b5e3d1faa71ce68836f6351996bd3b37854496b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6b5e3d1faa71ce68836f6351996bd3b37854496b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}