)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"71ab830734dc791fbbe0e8a48973ad452802f3c8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zwei \u003cleidong@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-09 07:20:11 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete an or more volume type from id or name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    delete more volume type eg: cinder type-delete \u003cid\u003e [\u003cid\u003e ...]"},{"line_number":10,"context_line":"    delete volume type from name in api 1 but api 2 no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da0c15f0_4523ed05","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":10},"updated":"2016-03-24 20:09:31.000000000","message":"one","commit_id":"9249d0c6545cdb9f9a043f1f763a55c68fac1dba"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"71ab830734dc791fbbe0e8a48973ad452802f3c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete an or more volume type from id or name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    delete more volume type eg: cinder type-delete \u003cid\u003e [\u003cid\u003e ...]"},{"line_number":10,"context_line":"    delete volume type from name in api 1 but api 2 no"},{"line_number":11,"context_line":"    so cinder --os-volume-api-version 2 type-dete  (type name)"},{"line_number":12,"context_line":"    eg: cinder --os-volume-api-version 2 type-delete test01 test02"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1554794"},{"line_number":15,"context_line":"Change-Id: I54faad2c5b60ab69f4b406310eb8059cf1e8cf76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da0c15f0_e5620116","line":12,"range":{"start_line":9,"start_character":4,"end_line":12,"end_character":66},"updated":"2016-03-24 20:09:31.000000000","message":"There should not be spaces at the beginning of the lines.  Suggest you say the following:\n\nFix api v2 so that you can delete more than one volume_type at a time.  eg:  cinder --os-volume-api-version 2 type-delete test01 test02","commit_id":"9249d0c6545cdb9f9a043f1f763a55c68fac1dba"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1bad79abe1decc4df420b19630cadaed57a9ac28","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete one or more volume type from id or name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    There should not be spaces at the beginning of the lines."},{"line_number":10,"context_line":"Suggest you say the following:"},{"line_number":11,"context_line":"    Fix api v2 so that you can delete more than one volume_type at a time."},{"line_number":12,"context_line":"    eg:  cinder --os-volume-api-version 2 type-delete test01 test02"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da0c15f0_7225f5a9","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"updated":"2016-03-25 14:26:17.000000000","message":"Sorry, it appears my earlier comment was not clear.  Please delete these two lines as they were just my comments on what you had here.  The text below should not have blank space before \u0027Fix\u0027 and \u0027eg:\u0027.  Can you please correct that and then this will be fine.  Thanks!","commit_id":"98e10594cf3117de5a3c591943b934df84cc5b23"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ebd21a9d25c9870ff5ccac1a9f79572ce493e4d4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete one or more volume type from id or name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix api v2 so that you can delete more than one volume_type at a time."},{"line_number":10,"context_line":"eg:  cinder --os-volume-api-version 2 type-delete test01 test02"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #1554794"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da0c15f0_7105bcba","line":9,"updated":"2016-03-28 10:10:15.000000000","message":"-1: This path is also allowing us to delete them by name instead of only by ID.  It should be reflected here.","commit_id":"251776f0d84cdcb00b261184d55d431922fa8737"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"af90d3ee8b0695fda843b7a5b316dd36c2c8f0ef","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix api v2 so that you can delete more than one volume_type at a time."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This path is also allowing us to delete them by name or ID instead of only by ID"},{"line_number":10,"context_line":"eg:  cinder --os-volume-api-version 2 type-delete test01 test02"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #1554794"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba0121b8_9aa54906","line":9,"updated":"2016-03-29 08:40:56.000000000","message":"nit: This line is too long, limit is 72 chars.","commit_id":"31f278e794c3e9e6d32899f56a65ee2febb82e4d"}],"cinderclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"991d1b115015f0d086e51b5bc722897b6cbb74dd","unresolved":false,"context_lines":[{"line_number":688,"context_line":"    def delete_types_1(self, **kw):"},{"line_number":689,"context_line":"        return (202, {}, None)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    def delete_types_3(self, **kw):"},{"line_number":692,"context_line":"        return (202, {}, None)"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    def put_types_1(self, **kw):"},{"line_number":695,"context_line":"        return self.get_types_1()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_e75cccef","line":692,"range":{"start_line":691,"start_character":4,"end_line":692,"end_character":30},"updated":"2016-03-28 16:57:09.000000000","message":"How is this different from the preceeding test? Shouldn\u0027t this be testing to delete more than one extra_spec?","commit_id":"251776f0d84cdcb00b261184d55d431922fa8737"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ebd21a9d25c9870ff5ccac1a9f79572ce493e4d4","unresolved":false,"context_lines":[{"line_number":937,"context_line":"    _print_volume_type_list([vtype])"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"@utils.arg(\u0027id\u0027,"},{"line_number":941,"context_line":"           metavar\u003d\u0027\u003cid\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":942,"context_line":"           help\u003d\u0027Name or ID of volume type or types to delete.\u0027)"},{"line_number":943,"context_line":"@utils.service_type(\u0027volumev2\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da0c15f0_11da8078","line":940,"updated":"2016-03-28 10:10:15.000000000","message":"-1: The name needs to be changed to reflect that now it\u0027s an id or a name, for example changing it to \u0027vol_type\u0027 (as well as in the metavar).","commit_id":"251776f0d84cdcb00b261184d55d431922fa8737"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ebd21a9d25c9870ff5ccac1a9f79572ce493e4d4","unresolved":false,"context_lines":[{"line_number":952,"context_line":"        except Exception as e:"},{"line_number":953,"context_line":"            failure_count +\u003d 1"},{"line_number":954,"context_line":"            print(\"Delete for volume type %s failed: %s\" % (id, e))"},{"line_number":955,"context_line":"            if failure_count \u003d\u003d len(args.id):"},{"line_number":956,"context_line":"                raise exceptions.CommandError(\"Unable to delete any of the \""},{"line_number":957,"context_line":"                                              \"specified types.\")"},{"line_number":958,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da0c15f0_91869063","line":955,"updated":"2016-03-28 10:10:15.000000000","message":"-1: This should be moved out of the for loop, there is no need to check at every iteration of the loop, as this can only ever be True when we have completed the loop.","commit_id":"251776f0d84cdcb00b261184d55d431922fa8737"}]}
