)]}'
{"id":"openstack%2Fpython-cinderclient~290322","triplet_id":"openstack%2Fpython-cinderclient~master~Id00d15a331826b79e14bdce0ea7fc60e482da818","project":"openstack/python-cinderclient","branch":"master","topic":"replace_magic_number","hashtags":[],"change_id":"Id00d15a331826b79e14bdce0ea7fc60e482da818","subject":"Use magic constants instead of magic numbers","status":"ABANDONED","created":"2016-03-09 08:14:32.000000000","updated":"2016-08-18 01:52:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d1114332096617618d58aee488a075d55af43ccb","_number":290322,"virtual_id_number":290322,"owner":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-08-18 01:52:49.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":-1,"date":"2016-03-24 18:39:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-24 18:39:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-08-18 01:52:49.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"5d1c09070b795f7e05af10594944b03e6acad435","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-03-09 08:14:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"998d7c1b46e4a8bd5279aa4b08adf8d73167b7a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-09 09:33:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-pep8 http://logs.openstack.org/22/290322/1/check/gate-python-cinderclient-pep8/88b1c4a/ : SUCCESS in 1m 35s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/22/290322/1/check/gate-python-cinderclient-docs/3be7843//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-cinderclient-python27 http://logs.openstack.org/22/290322/1/check/gate-python-cinderclient-python27/f1d3774/ : SUCCESS in 1m 48s\n- gate-python-cinderclient-python34 http://logs.openstack.org/22/290322/1/check/gate-python-cinderclient-python34/1669c9e/ : SUCCESS in 2m 54s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/22/290322/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/89765c0/ : SUCCESS in 1h 18m 58s\n- gate-python-cinderclient-pypy http://logs.openstack.org/22/290322/1/check/gate-python-cinderclient-pypy/e858be6/ : SUCCESS in 5m 47s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/22/290322/1/check/gate-cinderclient-dsvm-functional/935721a/ : SUCCESS in 22m 56s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"140441c2a7f9c15b88de2667dac391649295d561","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-24 18:39:13.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"4816505a52207bd2f624702bfbdf93af962db52d","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-08-18 01:52:49.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1},{"id":"9663e8c71a381e2a2ff937886d871f4dbaed05bf","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-08-18 01:52:49.000000000","message":"Patch Set 1:\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"eba5cd0f5dbe1e56176a4df5d06536aa6bc8f258","revisions":{"eba5cd0f5dbe1e56176a4df5d06536aa6bc8f258":{"kind":"REWORK","_number":1,"created":"2016-03-09 08:14:32.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/22/290322/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/22/290322/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/290322/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/290322/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/22/290322/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/22/290322/1"}}},"commit":{"parents":[{"commit":"fb175864f93e617da3ceb9d582ad2966e545991c","subject":"Merge \"Add backup list sorted by data_timestamp\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/fb175864f93e617da3ceb9d582ad2966e545991c"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2016-03-09 07:48:00.000000000","tz":-300},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2016-03-09 08:06:49.000000000","tz":-300},"subject":"Use magic constants instead of magic numbers","message":"Use magic constants instead of magic numbers\n\nIt\u0027s a best practice to use magic constants instead of\nmagic numbers. So, this patch tried to introduce the\nHTTP status codes unified by the httplib to replace\nthe direct hard code.\n\nChange-Id: Id00d15a331826b79e14bdce0ea7fc60e482da818\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/eba5cd0f5dbe1e56176a4df5d06536aa6bc8f258"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/eba5cd0f5dbe1e56176a4df5d06536aa6bc8f258"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
