)]}'
{"cinderclient/v3/volume_encryption_types.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"b145b760e33c9fea32d224f7b44b9721c3a82d9b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :param volume_type: the volume type to query"},{"line_number":67,"context_line":"        :return: an instance of :class: VolumeEncryptionType or an empty list"},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        result \u003d self._get(\"/types/%s/encryption\" % base.getid(volume_type))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # return result or an empty list if no result"},{"line_number":72,"context_line":"        if hasattr(result, \u0027volume_type_id\u0027):"},{"line_number":73,"context_line":"            return result"},{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            return common_base.ListWithMeta([], result.request_ids)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create(self, volume_type, specs):"},{"line_number":78,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_acef9ce7","line":75,"range":{"start_line":69,"start_character":0,"end_line":75,"end_character":12},"updated":"2016-04-20 11:06:56.000000000","message":"This will break library callers for sure.","commit_id":"0e3b2610485bd5f4f5e33f214844aadf6db58dfd"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"63e32fc23af10e3c5f40fe7f2dc15d800d33724b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :param volume_type: the volume type to query"},{"line_number":67,"context_line":"        :return: an instance of :class: VolumeEncryptionType or an empty list"},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        result \u003d self._get(\"/types/%s/encryption\" % base.getid(volume_type))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # return result or an empty list if no result"},{"line_number":72,"context_line":"        if hasattr(result, \u0027volume_type_id\u0027):"},{"line_number":73,"context_line":"            return result"},{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            return common_base.ListWithMeta([], result.request_ids)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create(self, volume_type, specs):"},{"line_number":78,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_8e2293a1","line":75,"range":{"start_line":69,"start_character":0,"end_line":75,"end_character":12},"in_reply_to":"1a122d0e_acef9ce7","updated":"2016-04-20 11:52:12.000000000","message":"Hi, Thomas:\nYes, this does break the backward compatibility.\nBut I believe the original logic is wrong.\nOriginally, when there is no Encryption Type, it returns an instance of VolumeEncryptionType which contains useless info in it, which will be a misleading to users.","commit_id":"0e3b2610485bd5f4f5e33f214844aadf6db58dfd"}]}