)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6317fae0f1fc3578ae34d4336c424d2088c18a74","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support for Cinder API /v3 endpoint."},{"line_number":10,"context_line":"A couple of unit tests for /v3 endpoint were added to v3/test_shell.py"},{"line_number":11,"context_line":"to ensure that the v3 shell works, and to also test that modules work with:"},{"line_number":12,"context_line":"from cinderclient.v2.availability_zones import *"},{"line_number":13,"context_line":"syntax."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a061dce_806cdc9d","line":11,"updated":"2016-04-04 09:03:17.000000000","message":"nit: Line too long","commit_id":"86ff2bdcb1ea345759034c73f46191c77c2e8fb8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Add support for Cinder API /v3 endpoint."},{"line_number":15,"context_line":"A couple of unit tests for /v3 endpoint were added to v3/test_shell.py"},{"line_number":16,"context_line":"to ensure that the v3 shell works, and to also test that modules work with:"},{"line_number":17,"context_line":"from cinderclient.v2.availability_zones import *"},{"line_number":18,"context_line":"syntax."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a18252c_bc0c123c","line":16,"updated":"2016-04-14 11:42:57.000000000","message":"nit: Line too long","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Add support for Cinder API /v3 endpoint."},{"line_number":15,"context_line":"A couple of unit tests for /v3 endpoint were added to v3/test_shell.py"},{"line_number":16,"context_line":"to ensure that the v3 shell works, and to also test that modules work with:"},{"line_number":17,"context_line":"from cinderclient.v2.availability_zones import *"},{"line_number":18,"context_line":"syntax."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a18252c_eb0fcc36","line":16,"in_reply_to":"5a18252c_bc0c123c","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"22bd4a6c013e0af3bf083a1836d69cf3b997e9df","unresolved":false,"context_lines":[{"line_number":14,"context_line":"syntax."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6ae0ada221bebb4ab1850d9c99b10fcbb585201f"},{"line_number":17,"context_line":"Implements: https://blueprints.launchpad.net/python-cinderclient/+spec/add-v3-endpoint-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a122d0e_6822eb01","line":17,"updated":"2016-04-18 19:51:13.000000000","message":"Only if you do another update - I believe for this to be properly linked it needs to be the format:\n\nImplements: blueprint add-v3-endpoint-support","commit_id":"27e6f6f7f85ef0e5fcc37b96e67c870b84880760"}],"cinderclient/shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bb878eed1494d84a374683b38c9cdcb5cc423808","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        elif version \u003d\u003d \u00272\u0027:"},{"line_number":395,"context_line":"            actions_module \u003d importutils.import_module(V2_SHELL)"},{"line_number":396,"context_line":"        else:"},{"line_number":397,"context_line":"            actions_module \u003d importutils.import_module(V3_SHELL)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        self._find_actions(subparsers, actions_module)"},{"line_number":400,"context_line":"        self._find_actions(subparsers, self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_a144a049","line":397,"updated":"2016-04-01 10:46:44.000000000","message":"-1: Are we sure this is Ok?, we are changing default on unknown version from v1 to v3 and we no longer accept \u00271.1\u0027.\n\nUnless I\u0027m missing something this is not what we want, but something like this would probably do:\n\n class CinderClientArgumentParser(argparse.ArgumentParser):\n     V1_SHELL \u003d \u0027cinderclient.v1.shell\u0027\n     V2_SHELL \u003d \u0027cinderclient.v2.shell\u0027\n     V3_SHELL \u003d \u0027cinderclient.v3.shell\u0027\n\n     parsers \u003d {\u00271.1\u0027: V1_SHELL,\n                \u00272\u0027: V2_SHELL,\n                \u00273\u0027: V3_SHELL}\n     \n     def get_subcommand_parser(self, version):\n\n     ...\n\n     actions_module \u003d self.parsers.get(version, self.V1_SHELL)","commit_id":"b08280dc65f483973c7a8f351c79ae3d568bfd0a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b18ee94267c9934bfb1455ee4505c7a59b5b3601","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        elif version \u003d\u003d \u00272\u0027:"},{"line_number":395,"context_line":"            actions_module \u003d importutils.import_module(V2_SHELL)"},{"line_number":396,"context_line":"        else:"},{"line_number":397,"context_line":"            actions_module \u003d importutils.import_module(V3_SHELL)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        self._find_actions(subparsers, actions_module)"},{"line_number":400,"context_line":"        self._find_actions(subparsers, self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_419b0466","line":397,"in_reply_to":"ba0121b8_a144a049","updated":"2016-04-01 10:47:52.000000000","message":"Sorry, the end should be:\n\n module \u003d self.parsers.get(version, self.V1_SHELL)\n actions_module \u003d importutils.import_module(module)","commit_id":"b08280dc65f483973c7a8f351c79ae3d568bfd0a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"09312c872479a98c62b86f97a62300c08dbae405","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        elif version \u003d\u003d \u00273\u0027:"},{"line_number":395,"context_line":"            actions_module \u003d importutils.import_module(V3_SHELL)"},{"line_number":396,"context_line":"        else:"},{"line_number":397,"context_line":"            actions_module \u003d importutils.import_module(V1_SHELL)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        self._find_actions(subparsers, actions_module)"},{"line_number":400,"context_line":"        self._find_actions(subparsers, self)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_3bdc2374","line":397,"updated":"2016-04-01 18:57:37.000000000","message":"not very OO :-) but the same result as Gorka\u0027s proposal I think.","commit_id":"86ff2bdcb1ea345759034c73f46191c77c2e8fb8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6317fae0f1fc3578ae34d4336c424d2088c18a74","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        elif version \u003d\u003d \u00273\u0027:"},{"line_number":395,"context_line":"            actions_module \u003d importutils.import_module(V3_SHELL)"},{"line_number":396,"context_line":"        else:"},{"line_number":397,"context_line":"            actions_module \u003d importutils.import_module(V1_SHELL)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        self._find_actions(subparsers, actions_module)"},{"line_number":400,"context_line":"        self._find_actions(subparsers, self)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_8055fcc7","line":397,"in_reply_to":"ba0121b8_3bdc2374","updated":"2016-04-04 09:03:17.000000000","message":"I prefer this solution to mine because it\u0027s easier to read, which is always a plus.","commit_id":"86ff2bdcb1ea345759034c73f46191c77c2e8fb8"}],"cinderclient/tests/unit/v3/fakes.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"51a2daa3a64cb54e82fa3dee9228c5eaa20808d0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from cinderclient.tests.unit.v2 import fakes as fake_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"REQUEST_ID \u003d \u0027req-test-request-id\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def _stub_volume(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1531f4_9778a691","line":20,"updated":"2016-04-15 08:48:25.000000000","message":"nit: Unnecessary","commit_id":"e5936120deb53d66ac748cd8c4e0097069d4bf90"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"9b2153963c27606088592e6a6becfa1aabdaf82f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from cinderclient.tests.unit.v2 import fakes as fake_v2"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"REQUEST_ID \u003d \u0027req-test-request-id\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def _stub_volume(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_4ac0cc7c","line":20,"in_reply_to":"3a1531f4_9778a691","updated":"2016-04-18 16:49:25.000000000","message":"I\u0027ll remove.","commit_id":"e5936120deb53d66ac748cd8c4e0097069d4bf90"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"51a2daa3a64cb54e82fa3dee9228c5eaa20808d0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"REQUEST_ID \u003d \u0027req-test-request-id\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def _stub_volume(*args, **kwargs):"},{"line_number":24,"context_line":"    volume \u003d {"},{"line_number":25,"context_line":"        \"migration_status\": None,"},{"line_number":26,"context_line":"        \"attachments\": [{\u0027server_id\u0027: 1234}],"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1531f4_f76d9acd","line":23,"updated":"2016-04-15 08:48:25.000000000","message":"nit: Unnecessary, it\u0027s not used","commit_id":"e5936120deb53d66ac748cd8c4e0097069d4bf90"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"9b2153963c27606088592e6a6becfa1aabdaf82f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"REQUEST_ID \u003d \u0027req-test-request-id\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def _stub_volume(*args, **kwargs):"},{"line_number":24,"context_line":"    volume \u003d {"},{"line_number":25,"context_line":"        \"migration_status\": None,"},{"line_number":26,"context_line":"        \"attachments\": [{\u0027server_id\u0027: 1234}],"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_aabfe0f9","line":23,"in_reply_to":"3a1531f4_f76d9acd","updated":"2016-04-18 16:49:25.000000000","message":"I\u0027ll remove.","commit_id":"e5936120deb53d66ac748cd8c4e0097069d4bf90"}],"cinderclient/tests/unit/v3/test_shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6317fae0f1fc3578ae34d4336c424d2088c18a74","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027CINDER_USERNAME\u0027: \u0027username\u0027,"},{"line_number":31,"context_line":"        \u0027CINDER_PASSWORD\u0027: \u0027password\u0027,"},{"line_number":32,"context_line":"        \u0027CINDER_PROJECT_ID\u0027: \u0027project_id\u0027,"},{"line_number":33,"context_line":"        \u0027OS_VOLUME_API_VERSION\u0027: \u00272\u0027,"},{"line_number":34,"context_line":"        \u0027CINDER_URL\u0027: keystone_client.BASE_URL,"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_00260c68","line":33,"updated":"2016-04-04 09:03:17.000000000","message":"-1: Shouldn\u0027t this be \u00273\u0027?","commit_id":"86ff2bdcb1ea345759034c73f46191c77c2e8fb8"}],"cinderclient/v2/availability_zones.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"# flake8: noqa"},{"line_number":17,"context_line":"\"\"\"Availability Zone interface (v2 extension)\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cinderclient.v3.availability_zones import *"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_9cd5d61d","line":16,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L19 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"# flake8: noqa"},{"line_number":17,"context_line":"\"\"\"Availability Zone interface (v2 extension)\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cinderclient.v3.availability_zones import *"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_66b49334","line":16,"in_reply_to":"5a18252c_9cd5d61d","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"51a2daa3a64cb54e82fa3dee9228c5eaa20808d0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"\"\"\"Availability Zone interface (v2 extension)\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# flake8: noqa"},{"line_number":19,"context_line":"from cinderclient.v3.availability_zones import *"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1531f4_57e44e3a","line":18,"updated":"2016-04-15 08:48:25.000000000","message":"I really, need to express myself better, whenever someone misunderstands me, I go back to read what I wrote and I see that I just didn\u0027t write what I wanted to say.  :-(\n\nI meant:\n\n from cinderclient.v3.availability_zones import *  # noqa\n\nLike we do in Cinder code, but this is irrelevant for the patch, so forget about it, just me and my quirks.  ;-)","commit_id":"e5936120deb53d66ac748cd8c4e0097069d4bf90"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"9b2153963c27606088592e6a6becfa1aabdaf82f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"\"\"\"Availability Zone interface (v2 extension)\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# flake8: noqa"},{"line_number":19,"context_line":"from cinderclient.v3.availability_zones import *"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_0a9d3459","line":18,"in_reply_to":"3a1531f4_57e44e3a","updated":"2016-04-18 16:49:25.000000000","message":"Well, that does look much better. I\u0027ll fix.","commit_id":"e5936120deb53d66ac748cd8c4e0097069d4bf90"}],"cinderclient/v2/capabilities.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Capabilities interface (v2 extension)\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_dcdbce4d","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L19 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Capabilities interface (v2 extension)\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_e67ee368","line":15,"in_reply_to":"5a18252c_dcdbce4d","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/cgsnapshots.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"cgsnapshot interface (v2 extension).\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_5cf05ec9","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L19 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"cgsnapshot interface (v2 extension).\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_469877c0","line":15,"in_reply_to":"5a18252c_5cf05ec9","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/consistencygroups.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Consistencygroup interface (v2 extension).\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_3ceda2ef","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L19 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Consistencygroup interface (v2 extension).\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_868e0f77","line":15,"in_reply_to":"5a18252c_3ceda2ef","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/limits.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":"\"\"\"Limits interface (v2 extension)\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from cinderclient.v3.limits import *"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_7c8f1a2a","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L18 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":"\"\"\"Limits interface (v2 extension)\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from cinderclient.v3.limits import *"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_c6eac70e","line":15,"in_reply_to":"5a18252c_7c8f1a2a","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/pools.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Pools interface (v2 extension)\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_1c7f0616","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L19 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Pools interface (v2 extension)\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_06f15f01","line":15,"in_reply_to":"5a18252c_1c7f0616","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/qos_specs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# implied."},{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"# flake8: noqa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_fc7b2a26","line":16,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L23 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# implied."},{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"# flake8: noqa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_e6f543ed","line":16,"in_reply_to":"5a18252c_fc7b2a26","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/quota_classes.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinderclient.v3.quota_classes import *"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_1ca6e6ad","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L17 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinderclient.v3.quota_classes import *"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_46dfd768","line":15,"in_reply_to":"5a18252c_1ca6e6ad","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/quotas.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinderclient.v3.quotas import *"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_3ca9227c","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L17 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinderclient.v3.quotas import *"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_66e2d330","line":15,"in_reply_to":"5a18252c_3ca9227c","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/services.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"service interface"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_bcb372e8","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"nit: I would prefer the noqa on L21 as here it\u0027s easier to miss","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"service interface"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_06c83fa7","line":15,"in_reply_to":"5a18252c_bcb372e8","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/volume_backups.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"Volume Backups interface (v2 extension)."}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_5cfb3e47","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"ditto","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"Volume Backups interface (v2 extension)."}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_a6d98b59","line":15,"in_reply_to":"5a18252c_5cfb3e47","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/volume_backups_restore.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Volume Backups Restore interface (v2 extension)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_9c9796eb","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"ditto","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Volume Backups Restore interface (v2 extension)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_e6df0338","line":15,"in_reply_to":"5a18252c_9c9796eb","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/volume_encryption_types.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"Volume Encryption Type interface"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_dc9d8e0b","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"ditto","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"Volume Encryption Type interface"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_86ef2fe8","line":15,"in_reply_to":"5a18252c_dc9d8e0b","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/volume_snapshots.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Volume snapshot interface (v2 extension).\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_7cc39aed","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"ditto","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Volume snapshot interface (v2 extension).\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_c6bbe7e3","line":15,"in_reply_to":"5a18252c_7cc39aed","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/volume_transfers.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"Volume transfer interface (v2 extension)."}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_7fa26cfe","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"ditto","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"Volume transfer interface (v2 extension)."}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_06b2ff05","line":15,"in_reply_to":"5a18252c_7fa26cfe","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/volume_type_access.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"# flake8: noqa"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Volume type access interface.\"\"\""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_bfa884dc","line":14,"updated":"2016-04-14 11:42:57.000000000","message":"ditto","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"# flake8: noqa"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Volume type access interface.\"\"\""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_e6b6e3f7","line":14,"in_reply_to":"5a18252c_bfa884dc","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/volume_types.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Volume Type interface.\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_3fb59430","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"ditto","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Volume Type interface.\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_46d0771f","line":15,"in_reply_to":"5a18252c_3fb59430","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v2/volumes.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8448e2d58463dd86ebb5df8919fda23f40921259","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Volume interface (v2 extension).\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_df7aa076","line":15,"updated":"2016-04-14 11:42:57.000000000","message":"ditto","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"429132cecae0bb4af40204b13f6045755b484131","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"# flake8: noqa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Volume interface (v2 extension).\"\"\""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_86c60f66","line":15,"in_reply_to":"5a18252c_df7aa076","updated":"2016-04-14 15:57:23.000000000","message":"Done","commit_id":"f290f6f40e995240839481de3363f9930ff490c7"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b0e7b3825ef2d54beecc2c9e4bc88f00ef670a1e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        sys.stdout.write(msg)"},{"line_number":45,"context_line":"        sys.stdout.flush()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    print()"},{"line_number":48,"context_line":"    while True:"},{"line_number":49,"context_line":"        obj \u003d poll_fn(obj_id)"},{"line_number":50,"context_line":"        status \u003d obj.status.lower()"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_82557ffb","line":47,"updated":"2016-04-19 14:03:02.000000000","message":"Why do we need this empty print?","commit_id":"27e6f6f7f85ef0e5fcc37b96e67c870b84880760"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3b4c607eae320bd348a7fed4180a64b037c9a578","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        sys.stdout.write(msg)"},{"line_number":45,"context_line":"        sys.stdout.flush()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    print()"},{"line_number":48,"context_line":"    while True:"},{"line_number":49,"context_line":"        obj \u003d poll_fn(obj_id)"},{"line_number":50,"context_line":"        status \u003d obj.status.lower()"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_4291a746","line":47,"in_reply_to":"1a122d0e_625b03f7","updated":"2016-04-19 14:09:49.000000000","message":"Verified that it\u0027s copied from v2 w/o changes. We can found why it was added later","commit_id":"27e6f6f7f85ef0e5fcc37b96e67c870b84880760"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"946c477ced6acf9330bb7ec486b203c2d077cb67","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        sys.stdout.write(msg)"},{"line_number":45,"context_line":"        sys.stdout.flush()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    print()"},{"line_number":48,"context_line":"    while True:"},{"line_number":49,"context_line":"        obj \u003d poll_fn(obj_id)"},{"line_number":50,"context_line":"        status \u003d obj.status.lower()"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_625b03f7","line":47,"in_reply_to":"1a122d0e_82557ffb","updated":"2016-04-19 14:07:10.000000000","message":"I don\u0027t know. This entire file was moved from /v2/shell.py, and that\u0027s the way it is in /v2/shell.py. Perhaps just to add a newline during the \"poll for status\"?\nI could remove it, but it would be altering current behaviour. Let me know what you think....","commit_id":"27e6f6f7f85ef0e5fcc37b96e67c870b84880760"}]}