)]}'
{"cinderclient/api_versions.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a83346b64dff1d0eb86ae3ae6844313575d24f59","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from cinderclient._i18n import _"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"if not LOG.handlers:"},{"line_number":29,"context_line":"    LOG.addHandler(logging.StreamHandler())"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_b73ae396","line":28,"updated":"2016-07-08 01:31:18.000000000","message":"I meant to say I think all of this log configuration should be removed from here. Library code shouldn\u0027t be manipulating the logging settings, so I think lines 28 and 29 should also be removed.\n\nUnless there is some case where StreamHandler should be added. But if so, that should probably happen in shell.py and not here.","commit_id":"b732f7ec26515bf7bbb740fce662d2c6fdc2dcc7"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"96b4386d5303db8e3753e698be490dd4186a775f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from cinderclient._i18n import _"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"if not LOG.handlers:"},{"line_number":29,"context_line":"    LOG.addHandler(logging.StreamHandler())"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_0872b6ad","line":28,"in_reply_to":"1aa78d24_b73ae396","updated":"2016-07-08 03:10:58.000000000","message":"Wow, that definitely shouldn\u0027t be happening here! Doesn\u0027t look like there are any other places doing it, fortunately","commit_id":"b732f7ec26515bf7bbb740fce662d2c6fdc2dcc7"}]}