)]}'
{"cinderclient/tests/unit/v2/test_volume_backups.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"573fcba25e5b9231ae68a3dc1b831e3f05c19cfd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def test_delete_force(self):"},{"line_number":96,"context_line":"        b \u003d cs.backups.list()[0]"},{"line_number":97,"context_line":"        del_back \u003d b.delete(force\u003dTrue)"},{"line_number":98,"context_line":"        cs.assert_called(\u0027POST\u0027,"},{"line_number":99,"context_line":"            \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027)"},{"line_number":100,"context_line":"        self._assert_request_id(del_back)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_d974e2fe","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":32},"updated":"2016-05-06 16:48:27.000000000","message":"It would be better to check expected_body here like this.\n\n  expected_body \u003d {\u0027os-force_delete\u0027: None}\n  cs.assert_called(\u0027POST\u0027,\n      \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027,\n      expected_body)","commit_id":"999d9ddc1cecd3a660ac223265cbcdfbce570f89"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"844222f4f063c8e1dc2b3710a000bba6dd914999","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def test_delete_force(self):"},{"line_number":96,"context_line":"        b \u003d cs.backups.list()[0]"},{"line_number":97,"context_line":"        del_back \u003d b.delete(force\u003dTrue)"},{"line_number":98,"context_line":"        cs.assert_called(\u0027POST\u0027,"},{"line_number":99,"context_line":"            \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027)"},{"line_number":100,"context_line":"        self._assert_request_id(del_back)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_003547d9","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":32},"in_reply_to":"dab17558_d974e2fe","updated":"2016-05-06 18:37:16.000000000","message":"done.","commit_id":"999d9ddc1cecd3a660ac223265cbcdfbce570f89"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"c25cd8c391913fd6add85091368f416d6967263e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        del_back \u003d b.delete(force\u003dTrue)"},{"line_number":99,"context_line":"        expected_body \u003d {\u0027os-force_delete\u0027: None}"},{"line_number":100,"context_line":"        cs.assert_called(\u0027POST\u0027,"},{"line_number":101,"context_line":"            \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027)"},{"line_number":102,"context_line":"            \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027,"},{"line_number":103,"context_line":"            expected_body)"},{"line_number":104,"context_line":"        self._assert_request_id(del_back)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_409bcfc9","line":101,"range":{"start_line":101,"start_character":22,"end_line":101,"end_character":30},"updated":"2016-05-06 18:43:27.000000000","message":"\u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027)\n\n^^ This line is unnecessary... ;)\nRunning pep8 and unit tests are recommended!","commit_id":"6e2e1d241eeda2ae2991d1b7bb3dd52fba78243f"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"9c2691933a4f7d91dadfe3c1e8ccb082cc6e8062","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        del_back \u003d b.delete(force\u003dTrue)"},{"line_number":99,"context_line":"        expected_body \u003d {\u0027os-force_delete\u0027: None}"},{"line_number":100,"context_line":"        cs.assert_called(\u0027POST\u0027,"},{"line_number":101,"context_line":"            \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027)"},{"line_number":102,"context_line":"            \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027,"},{"line_number":103,"context_line":"            expected_body)"},{"line_number":104,"context_line":"        self._assert_request_id(del_back)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_2094cb35","line":101,"range":{"start_line":101,"start_character":22,"end_line":101,"end_character":30},"in_reply_to":"dab17558_409bcfc9","updated":"2016-05-06 18:48:29.000000000","message":"I did run tox -epy27 but i tried to use gerrit for submitting changes.... some copy paste errro from my vm to gerrit. :(\nThanks for pointing.","commit_id":"6e2e1d241eeda2ae2991d1b7bb3dd52fba78243f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ebc1372c49d6e8ac9277258e066d836511e75256","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self._assert_request_id(del_back)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_force_delete_with_default_force_param_value(self):"},{"line_number":96,"context_line":"        \"\"\"Tests delete backup with default value(True) of force parameter\"\"\""},{"line_number":97,"context_line":"        b \u003d cs.backups.list()[0]"},{"line_number":98,"context_line":"        del_back \u003d b.delete(force\u003dTrue)"},{"line_number":99,"context_line":"        expected_body \u003d {\u0027os-force_delete\u0027: None}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_2c09532d","line":96,"updated":"2016-05-13 08:17:18.000000000","message":"Default value is False","commit_id":"80218f55a9001040ea6956c6b2767bead8caee5a"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"d884441dd092bd85f0f9fe566db0fb70a7617df2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self._assert_request_id(del_back)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_force_delete_with_default_force_param_value(self):"},{"line_number":96,"context_line":"        \"\"\"Tests delete backup with default value(True) of force parameter\"\"\""},{"line_number":97,"context_line":"        b \u003d cs.backups.list()[0]"},{"line_number":98,"context_line":"        del_back \u003d b.delete(force\u003dTrue)"},{"line_number":99,"context_line":"        expected_body \u003d {\u0027os-force_delete\u0027: None}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_cc7b67f3","line":96,"in_reply_to":"dab17558_2c09532d","updated":"2016-05-13 08:39:34.000000000","message":"will update the description and test case name.","commit_id":"80218f55a9001040ea6956c6b2767bead8caee5a"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ebc1372c49d6e8ac9277258e066d836511e75256","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"\"\"Tests delete backup with default value(True) of force parameter\"\"\""},{"line_number":97,"context_line":"        b \u003d cs.backups.list()[0]"},{"line_number":98,"context_line":"        del_back \u003d b.delete(force\u003dTrue)"},{"line_number":99,"context_line":"        expected_body \u003d {\u0027os-force_delete\u0027: None}"},{"line_number":100,"context_line":"        cs.assert_called(\u0027POST\u0027,"},{"line_number":101,"context_line":"            \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027,"},{"line_number":102,"context_line":"            expected_body)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_8c5ddf17","line":99,"updated":"2016-05-13 08:17:18.000000000","message":"Why is it None  here?","commit_id":"80218f55a9001040ea6956c6b2767bead8caee5a"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"d884441dd092bd85f0f9fe566db0fb70a7617df2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"\"\"Tests delete backup with default value(True) of force parameter\"\"\""},{"line_number":97,"context_line":"        b \u003d cs.backups.list()[0]"},{"line_number":98,"context_line":"        del_back \u003d b.delete(force\u003dTrue)"},{"line_number":99,"context_line":"        expected_body \u003d {\u0027os-force_delete\u0027: None}"},{"line_number":100,"context_line":"        cs.assert_called(\u0027POST\u0027,"},{"line_number":101,"context_line":"            \u0027/backups/76a17945-3c6f-435c-975b-b5685db10b62/action\u0027,"},{"line_number":102,"context_line":"            expected_body)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_4cd657c4","line":99,"in_reply_to":"dab17558_8c5ddf17","updated":"2016-05-13 08:39:34.000000000","message":"I kept it null here as no values required here in body.\nThis used to be {\u0027os-firce_delete:{}\u0027}","commit_id":"80218f55a9001040ea6956c6b2767bead8caee5a"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cb101028a33631e5da54d17dc0663a0e14e35cdc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"cinderclient/v3/shell.py"},{"line_number":2,"context_line":"# Copyright (c) 2013-2014 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_b695ad41","line":1,"updated":"2016-05-06 16:16:53.000000000","message":"oops","commit_id":"fa2b577210ca4e8a4ebcb3f493f8fa58b8a40bd2"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6f9282d65a635735da7d42b335fb91c90f958faa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"cinderclient/v3/shell.py"},{"line_number":2,"context_line":"# Copyright (c) 2013-2014 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_39040e7d","line":1,"in_reply_to":"dab17558_b695ad41","updated":"2016-05-06 16:45:24.000000000","message":"ah..removed..","commit_id":"fa2b577210ca4e8a4ebcb3f493f8fa58b8a40bd2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cb101028a33631e5da54d17dc0663a0e14e35cdc","unresolved":false,"context_lines":[{"line_number":1460,"context_line":""},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1463,"context_line":"           const\u003dFalse,"},{"line_number":1464,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":1465,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1466,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_36ba5de2","line":1463,"updated":"2016-05-06 16:16:53.000000000","message":"This should be const\u003dTrue, since adding just --force should invoke force.","commit_id":"fa2b577210ca4e8a4ebcb3f493f8fa58b8a40bd2"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6f9282d65a635735da7d42b335fb91c90f958faa","unresolved":false,"context_lines":[{"line_number":1460,"context_line":""},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1463,"context_line":"           const\u003dFalse,"},{"line_number":1464,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":1465,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1466,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_19094a96","line":1463,"in_reply_to":"dab17558_36ba5de2","updated":"2016-05-06 16:45:24.000000000","message":"Done","commit_id":"fa2b577210ca4e8a4ebcb3f493f8fa58b8a40bd2"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b65b4fe2c8ba86dfdb315b3d9cc089253cbe197c","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":1464,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1465,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1466,"context_line":"           \u0027when its status is other than \"available\" or \"error\".\u0027"},{"line_number":1467,"context_line":"           \u0027Default\u003dTrue.\u0027)"},{"line_number":1468,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1469,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_4aa36000","line":1466,"range":{"start_line":1466,"start_character":57,"end_line":1466,"end_character":66},"updated":"2016-05-10 23:11:49.000000000","message":"Missing space at the end of the line here.","commit_id":"c7ee77ba910665579967154d1ba7360324817a85"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6bb33a52c210d498f2659a46877b53a68611d9c5","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":1464,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1465,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1466,"context_line":"           \u0027when its status is other than \"available\" or \"error\".\u0027"},{"line_number":1467,"context_line":"           \u0027Default\u003dTrue.\u0027)"},{"line_number":1468,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1469,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_3c062520","line":1466,"range":{"start_line":1466,"start_character":57,"end_line":1466,"end_character":66},"in_reply_to":"dab17558_4aa36000","updated":"2016-05-11 05:08:15.000000000","message":"Done","commit_id":"c7ee77ba910665579967154d1ba7360324817a85"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"280a78f76b9220c5b6d0d8b4189dcfdf7cb589a0","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1465,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1466,"context_line":"           \u0027when its status is other than \"available\" or \"error\". \u0027"},{"line_number":1467,"context_line":"           \u0027Default\u003dTrue.\u0027)"},{"line_number":1468,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1469,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1470,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_933a9c97","line":1467,"updated":"2016-05-11 07:49:36.000000000","message":"\u0027Defalt\u003dTrue\u0027? Why set default as true? I think it is dangerous.","commit_id":"c85e59255c627f27d0fae9f3377e4ec8a1fe02be"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"fc6a3ac587c3581aced5c2a218ed46ce44ceca08","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1465,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1466,"context_line":"           \u0027when its status is other than \"available\" or \"error\". \u0027"},{"line_number":1467,"context_line":"           \u0027Default\u003dTrue.\u0027)"},{"line_number":1468,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1469,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1470,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_2788c070","line":1467,"in_reply_to":"dab17558_023e5327","updated":"2016-05-11 11:11:59.000000000","message":"I think there\u0027s too much chance for confusion here between the default value when \u0027--force\u0027 is given (True) and the default value when \u0027--force\u0027 isn\u0027t given (False).  IMO it would be clearer just to leave off the optional True,true,False,false args.  If \u0027--force\u0027 is given, then do a forced delete, otherwise don\u0027t.","commit_id":"c85e59255c627f27d0fae9f3377e4ec8a1fe02be"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6e6bd67d9273fe4554c875f8c8437da8bd42329b","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1465,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1466,"context_line":"           \u0027when its status is other than \"available\" or \"error\". \u0027"},{"line_number":1467,"context_line":"           \u0027Default\u003dTrue.\u0027)"},{"line_number":1468,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1469,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1470,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_aadbd57a","line":1467,"in_reply_to":"dab17558_2788c070","updated":"2016-05-11 11:28:58.000000000","message":"Nice suggestion.\nThanks LisaLi and Tom Barron.","commit_id":"c85e59255c627f27d0fae9f3377e4ec8a1fe02be"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"80a07216a05b467270efc366a3f826984c81f475","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1465,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1466,"context_line":"           \u0027when its status is other than \"available\" or \"error\". \u0027"},{"line_number":1467,"context_line":"           \u0027Default\u003dTrue.\u0027)"},{"line_number":1468,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1469,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1470,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_8eec2f2b","line":1467,"in_reply_to":"dab17558_334490b5","updated":"2016-05-11 08:08:27.000000000","message":"This description makes it like: when force is not specified, its default value is true.\ncinder backup-delete XXXX","commit_id":"c85e59255c627f27d0fae9f3377e4ec8a1fe02be"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"99c2492db8adbaeaec3d4e8546cee35407279996","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1465,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1466,"context_line":"           \u0027when its status is other than \"available\" or \"error\". \u0027"},{"line_number":1467,"context_line":"           \u0027Default\u003dTrue.\u0027)"},{"line_number":1468,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1469,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1470,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_023e5327","line":1467,"in_reply_to":"dab17558_8eec2f2b","updated":"2016-05-11 08:48:11.000000000","message":"well let me show you how this information will be presented to user in help, that will clear the doubt:\n\ncinder backup-delete [--force [{True,true,False,false}]]\n                            \u003cbackup\u003e [\u003cbackup\u003e ...]\n\nRemoves one or more backups.\n\nPositional arguments:\n  \u003cbackup\u003e              Name or ID of backup(s) to delete.\n\nOptional arguments:\n  --force [{True,true,False,false}]\n                        Allows deleting backup of a volume when its status is\n                        other than \"available\" or \"error\". Default\u003dTrue.\n\n\nHere values for --force are shown as optional. so, default\u003dTrue represents value part of force argument.","commit_id":"c85e59255c627f27d0fae9f3377e4ec8a1fe02be"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"f28df6a2fb5e121fb0b643ee293dbd2b5dd6cb50","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"           choices\u003d[\u0027True\u0027, \u0027true\u0027, \u0027False\u0027, \u0027false\u0027],"},{"line_number":1465,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1466,"context_line":"           \u0027when its status is other than \"available\" or \"error\". \u0027"},{"line_number":1467,"context_line":"           \u0027Default\u003dTrue.\u0027)"},{"line_number":1468,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1469,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1470,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_334490b5","line":1467,"in_reply_to":"dab17558_933a9c97","updated":"2016-05-11 07:53:12.000000000","message":"IF someone uses \"cinder backup-delete --force\" command, then its ok to treat it as \"--force True\".","commit_id":"c85e59255c627f27d0fae9f3377e4ec8a1fe02be"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"77f7c4e0b02c6f17292a365c548b1c5e0a71e8e5","unresolved":false,"context_lines":[{"line_number":1461,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1462,"context_line":"           action\u003d\"store_true\","},{"line_number":1463,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1464,"context_line":"           \u0027when its status is other than \"available\" or \"error\".)"},{"line_number":1465,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1466,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1467,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_3650f00a","line":1464,"updated":"2016-05-11 12:41:15.000000000","message":"missing single quote at end\n\nDon\u0027t we want \u0027Default\u003dFalse.\u0027 now?","commit_id":"a840d2d193d7d99e570612b6d4027f245e1d880b"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"e7e976b56b24825e0e08cd7bca4b6a9ef8d15bda","unresolved":false,"context_lines":[{"line_number":1461,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":1462,"context_line":"           action\u003d\"store_true\","},{"line_number":1463,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1464,"context_line":"           \u0027when its status is other than \"available\" or \"error\".)"},{"line_number":1465,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1466,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1467,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_e9d16224","line":1464,"in_reply_to":"dab17558_3650f00a","updated":"2016-05-11 15:14:08.000000000","message":"Yes we do required Default\u003dFalse.\nDone.","commit_id":"a840d2d193d7d99e570612b6d4027f245e1d880b"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"4c56540d468a7ccac462ada42d65457dc0fa3319","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"           default\u003dFalse,"},{"line_number":1464,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1465,"context_line":"           \u0027when its status is other than \"available\" or \"error\". \u0027"},{"line_number":1466,"context_line":"           \u0027Default\u003dFalse.)\u0027"},{"line_number":1467,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1468,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1469,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_1a4986d0","line":1466,"range":{"start_line":1466,"start_character":25,"end_line":1466,"end_character":28},"updated":"2016-05-11 14:55:28.000000000","message":"This causes syntax error.\nShould be,\n\n\u0027Default\u003dFalse.)\u0027  --\u003e  \u0027Default\u003dFalse.\u0027)","commit_id":"d4c0a91154415fda289ceeeb31bb0eb5dab0c9d8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"895734ec818a498eaa066b9e2c96d9cc97dbe5b7","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"           default\u003dFalse,"},{"line_number":1464,"context_line":"           help\u003d\u0027Allows deleting backup of a volume \u0027"},{"line_number":1465,"context_line":"           \u0027when its status is other than \"available\" or \"error\". \u0027"},{"line_number":1466,"context_line":"           \u0027Default\u003dFalse.\u0027)"},{"line_number":1467,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, nargs\u003d\u0027+\u0027,"},{"line_number":1468,"context_line":"           help\u003d\u0027Name or ID of backup(s) to delete.\u0027)"},{"line_number":1469,"context_line":"@utils.service_type(\u0027volumev3\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_6abaed6f","line":1466,"updated":"2016-05-19 18:44:15.000000000","message":"Should also remove \u0027Default\u003dFalse\u0027 since we\u0027ve converted this to a store_true action.  No longer applicable.","commit_id":"1892145a7374dba7f1becacbd6fbd61c00ac97d5"}],"cinderclient/v3/volume_backups.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"b30bd108832d9fb4a43e7db6c12efc7afd4b4cc5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"\"\"Delete a volume backup."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param backup: The :class:`VolumeBackup` to delete."},{"line_number":88,"context_line":"        :param force: The :class:`volumeBackup` to delete forcefully."},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        if force:"},{"line_number":91,"context_line":"            return self._action(\u0027os-force_delete\u0027, backup)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_474ba087","line":88,"updated":"2016-05-09 21:43:12.000000000","message":"The description should describe what \"force\" does, i.e.:\nAllow delete in state other than error or available","commit_id":"4ff6c2eb92e90c802d7ff47219606fd8d5533a42"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"73c2f6e56af63341cba61911605ddce3d28f5b40","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"\"\"Delete a volume backup."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param backup: The :class:`VolumeBackup` to delete."},{"line_number":88,"context_line":"        :param force: The :class:`volumeBackup` to allow delete in state"},{"line_number":89,"context_line":"        other than error or available."},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        if force:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_06ae8780","line":88,"updated":"2016-05-10 16:28:18.000000000","message":"I don\u0027t think you need\n:class:`volumeBackup`\nfor this docstring\nJust:\n:param force: allow delete in state other than error or available","commit_id":"53f45eacd0e3dff0356f4120e385be98a4cee88f"}]}