)]}'
{"cinderclient/client.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"96d66e9343a807de82de13bb8008b459ba52635e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"def _log_request_id(logger, resp, service_name):"},{"line_number":93,"context_line":"    request_id \u003d resp.headers.get(\u0027x-openstack-request-id\u0027)"},{"line_number":94,"context_line":"    if request_id:"},{"line_number":95,"context_line":"        msg \u003d (_(\u0027%(method)s call to %(service_name)s for %(url)s \u0027"},{"line_number":96,"context_line":"                 \u0027used request id %(response_request_id)s\u0027) %"},{"line_number":97,"context_line":"               {\u0027method\u0027: resp.request.method,"},{"line_number":98,"context_line":"                \u0027service_name\u0027: service_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b70011ac","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":16},"updated":"2016-06-06 05:45:51.000000000","message":"It is not necessary for debug level output.","commit_id":"af7dc9db2885c24575113fd9d6903f46283bb301"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"409c6d120c844a75e59b5833d2d8b434d8dad75e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"def _log_request_id(logger, resp, service_name):"},{"line_number":93,"context_line":"    request_id \u003d resp.headers.get(\u0027x-openstack-request-id\u0027)"},{"line_number":94,"context_line":"    if request_id:"},{"line_number":95,"context_line":"        msg \u003d (_(\u0027%(method)s call to %(service_name)s for %(url)s \u0027"},{"line_number":96,"context_line":"                 \u0027used request id %(response_request_id)s\u0027) %"},{"line_number":97,"context_line":"               {\u0027method\u0027: resp.request.method,"},{"line_number":98,"context_line":"                \u0027service_name\u0027: service_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_085e22e9","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":16},"in_reply_to":"7aa08908_b70011ac","updated":"2016-06-06 07:23:08.000000000","message":"Done","commit_id":"af7dc9db2885c24575113fd9d6903f46283bb301"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"96d66e9343a807de82de13bb8008b459ba52635e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                \u0027service_name\u0027: service_name,"},{"line_number":99,"context_line":"                \u0027url\u0027: resp.url, \u0027response_request_id\u0027: request_id})"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        logger.debug(msg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class SessionClient(adapter.LegacyJsonAdapter):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b71771ec","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":25},"updated":"2016-06-06 05:45:51.000000000","message":"To avoid unnecessary string interpolation, it should be as follows:\n\n        logger.debug(\u0027%(method)s call to %(service_name)s for %(url)s \u0027\n                     \u0027used request id %(response_request_id)s\u0027,\n                     {\u0027method\u0027: resp.request.method,\n                      \u0027service_name\u0027: service_name,\n                      \u0027url\u0027: resp.url,\n                      \u0027response_request_id\u0027: request_id})","commit_id":"af7dc9db2885c24575113fd9d6903f46283bb301"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"409c6d120c844a75e59b5833d2d8b434d8dad75e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                \u0027service_name\u0027: service_name,"},{"line_number":99,"context_line":"                \u0027url\u0027: resp.url, \u0027response_request_id\u0027: request_id})"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        logger.debug(msg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class SessionClient(adapter.LegacyJsonAdapter):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e862b6ac","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":25},"in_reply_to":"7aa08908_b71771ec","updated":"2016-06-06 07:23:08.000000000","message":"Done","commit_id":"af7dc9db2885c24575113fd9d6903f46283bb301"}],"cinderclient/shell.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c80fc1df8f02c85bf459fe6786db22eecdf1672","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            cacert\u003dcacert, auth_system\u003dos_auth_system,"},{"line_number":656,"context_line":"            auth_plugin\u003dauth_plugin,"},{"line_number":657,"context_line":"            session\u003dauth_session,"},{"line_number":658,"context_line":"            logger\u003dself.ks_logger if auth_session else self.client_logger)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        try:"},{"line_number":661,"context_line":"            if not utils.isunauthenticated(args.func):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_f81f0807","line":658,"range":{"start_line":658,"start_character":12,"end_line":658,"end_character":73},"updated":"2016-06-28 10:56:35.000000000","message":"Why do we pass ks_logger, when we\u0027re creating client_logger anyway?","commit_id":"679cdd245195a6d08cac859b49219ac9112f1d7c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2ddce83ee2c2442c9c5703d886d95183c5ab1bd9","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            cacert\u003dcacert, auth_system\u003dos_auth_system,"},{"line_number":656,"context_line":"            auth_plugin\u003dauth_plugin,"},{"line_number":657,"context_line":"            session\u003dauth_session,"},{"line_number":658,"context_line":"            logger\u003dself.ks_logger if auth_session else self.client_logger)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        try:"},{"line_number":661,"context_line":"            if not utils.isunauthenticated(args.func):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_f39a82c4","line":658,"range":{"start_line":658,"start_character":12,"end_line":658,"end_character":73},"in_reply_to":"3aaa91ec_27b4ccf0","updated":"2016-06-28 12:58:04.000000000","message":"to eliminate duplicate log I have proposed a patch, please refer https://review.openstack.org/309276","commit_id":"679cdd245195a6d08cac859b49219ac9112f1d7c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"dbcec98c5d50c4f275766a85153d941dca4c16e8","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            cacert\u003dcacert, auth_system\u003dos_auth_system,"},{"line_number":656,"context_line":"            auth_plugin\u003dauth_plugin,"},{"line_number":657,"context_line":"            session\u003dauth_session,"},{"line_number":658,"context_line":"            logger\u003dself.ks_logger if auth_session else self.client_logger)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        try:"},{"line_number":661,"context_line":"            if not utils.isunauthenticated(args.func):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_27b4ccf0","line":658,"range":{"start_line":658,"start_character":12,"end_line":658,"end_character":73},"in_reply_to":"3aaa91ec_d8084c30","updated":"2016-06-28 11:57:25.000000000","message":"Without changing that it logs with:\n\n DEBUG:keystoneclient:GET call to volumev3 for http://192.168.1.2:8776/v3/809e7d3ca8c347389f124f6a0663dd07/volumes/detail used request id req-a4a7c523-eb64-4e1c-81e4-9ebe77ff4774\n\nWhere keystoneclient is quite confusing.\n\nWhen I\u0027ve changed that line to logger\u003dself.client_logger it logs in the same way as novaclient does:\n\n DEBUG:cinderclient.client:GET call to volumev3 for http://192.168.1.2:8776/v3/809e7d3ca8c347389f124f6a0663dd07/volumes/detail used request id req-05f7b47f-02d2-4506-b8ee-18aea4710758\n\nSo that\u0027s why I\u0027m confused we cannot pass client_logger in any case, as we\u0027re creating it anyway.","commit_id":"679cdd245195a6d08cac859b49219ac9112f1d7c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"51c5f7f574180125bdbe9bebb73ba60493f86f1e","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            cacert\u003dcacert, auth_system\u003dos_auth_system,"},{"line_number":656,"context_line":"            auth_plugin\u003dauth_plugin,"},{"line_number":657,"context_line":"            session\u003dauth_session,"},{"line_number":658,"context_line":"            logger\u003dself.ks_logger if auth_session else self.client_logger)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        try:"},{"line_number":661,"context_line":"            if not utils.isunauthenticated(args.func):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_d8084c30","line":658,"range":{"start_line":658,"start_character":12,"end_line":658,"end_character":73},"in_reply_to":"3aaa91ec_f81f0807","updated":"2016-06-28 11:07:57.000000000","message":"Hi Michal,\n\nks_logger is required if client is instance of SessionClient and client_logger is required for HTTPClient.","commit_id":"679cdd245195a6d08cac859b49219ac9112f1d7c"}],"cinderclient/tests/unit/test_client.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e7877580b1ae90e616b34f65c613e803e523c229","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        # resp.status_code is 400"},{"line_number":161,"context_line":"        self.assertRaises(exceptions.BadRequest, session_client.request,"},{"line_number":162,"context_line":"                          mock.sentinel.url, \u0027POST\u0027, **kwargs)"},{"line_number":163,"context_line":"        self.assertTrue(1, mock_log.call_count)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @mock.patch.object(exceptions, \u0027from_response\u0027)"},{"line_number":166,"context_line":"    def test_keystone_request_raises_auth_failure_exception("}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_148d4d7b","line":163,"range":{"start_line":163,"start_character":13,"end_line":163,"end_character":23},"updated":"2016-06-23 10:24:14.000000000","message":"It should be \u0027assertEqual\u0027.","commit_id":"c2373dc04f70f932976a161bbf9285360208c179"}],"cinderclient/v2/client.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ef3b5f47562d964a19a52edf0db363a4db84be51","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    setattr(self, extension.name,"},{"line_number":97,"context_line":"                            extension.manager_class(self))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if not logger:"},{"line_number":100,"context_line":"            logger \u003d logging.getLogger(__name__)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.client \u003d client._construct_http_client("},{"line_number":103,"context_line":"            username\u003dusername,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_417b002a","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":48},"updated":"2016-06-27 13:50:19.000000000","message":"Don\u0027t we need similar change in v3 cinderclient?","commit_id":"4a23cf8780712fbef1fb335ad441a7ca57ef948c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"60d3df32f431d383ab0ef0cb61058698d497067b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    setattr(self, extension.name,"},{"line_number":97,"context_line":"                            extension.manager_class(self))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if not logger:"},{"line_number":100,"context_line":"            logger \u003d logging.getLogger(__name__)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.client \u003d client._construct_http_client("},{"line_number":103,"context_line":"            username\u003dusername,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_c287c8d5","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":48},"in_reply_to":"3aaa91ec_417b002a","updated":"2016-06-28 06:34:45.000000000","message":"Done","commit_id":"4a23cf8780712fbef1fb335ad441a7ca57ef948c"}]}