)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"17c888cbfb0d5624bed687148fe87ad5210affef","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return metadata"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def _validate_api_version(api_version, min_version,"},{"line_number":147,"context_line":"                          max_version\u003dapi_versions.MAX_VERSION):"},{"line_number":148,"context_line":"    if (api_version \u003c api_versions.get_api_version(min_version) or"},{"line_number":149,"context_line":"            api_version \u003e api_versions.get_api_version(max_version)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_21d9d257","line":146,"updated":"2016-08-01 16:47:13.000000000","message":"see cinderclient/api_version.py matches() for this function. If we cannot use matches(), we should at least move this to api_version.py or utils.py.","commit_id":"39a8f6ae13b639c2ff42e09287c459dec29f41ae"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"b32eb44f17f87ce8a533ff034b93968959acb251","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return metadata"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def _validate_api_version(api_version, min_version,"},{"line_number":147,"context_line":"                          max_version\u003dapi_versions.MAX_VERSION):"},{"line_number":148,"context_line":"    if (api_version \u003c api_versions.get_api_version(min_version) or"},{"line_number":149,"context_line":"            api_version \u003e api_versions.get_api_version(max_version)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5fb5b37b","line":146,"in_reply_to":"bacf61ea_21d9d257","updated":"2016-08-01 21:39:46.000000000","message":"Done","commit_id":"39a8f6ae13b639c2ff42e09287c459dec29f41ae"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"1ed5081029535e48dd351f388dc686963204a388","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1264,"context_line":"@utils.arg(\u0027--visibility\u0027,"},{"line_number":1265,"context_line":"           metavar\u003d\u0027\u003cpublic|private\u003e\u0027,"},{"line_number":1266,"context_line":"           help\u003d\u0027Makes image publicly accessible.\u0027)"},{"line_number":1267,"context_line":"@utils.arg(\u0027--protected\u0027,"},{"line_number":1268,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1269,"context_line":"           help\u003d\u0027Prevents image from being deleted.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_a2e0162a","line":1266,"updated":"2016-08-01 21:51:14.000000000","message":"It seems like a good idea to keep the defaults and make them explicit in the help. Is there any reason you removed these (and moved them to volumes.py)? In fact, I don\u0027t really like the original, since \"--visibility\" doesn\u0027t imply that it \"makes image publicly accessible\". Maybe that should be something like \"Set image visibility to either public or private\" or something like that.","commit_id":"4448597a7563dac6401f9b6e00978d5dd513f499"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"e35629b73b88075a956d60a3a297a5c56434b8e6","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1264,"context_line":"@utils.arg(\u0027--visibility\u0027,"},{"line_number":1265,"context_line":"           metavar\u003d\u0027\u003cpublic|private\u003e\u0027,"},{"line_number":1266,"context_line":"           help\u003d\u0027Makes image publicly accessible.\u0027)"},{"line_number":1267,"context_line":"@utils.arg(\u0027--protected\u0027,"},{"line_number":1268,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1269,"context_line":"           help\u003d\u0027Prevents image from being deleted.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_656d88cb","line":1266,"in_reply_to":"bacf61ea_a2e0162a","updated":"2016-08-01 22:17:40.000000000","message":"I can change the help message, I agree with that.","commit_id":"4448597a7563dac6401f9b6e00978d5dd513f499"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"1ed5081029535e48dd351f388dc686963204a388","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"           help\u003d\u0027Makes image publicly accessible.\u0027)"},{"line_number":1267,"context_line":"@utils.arg(\u0027--protected\u0027,"},{"line_number":1268,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1269,"context_line":"           help\u003d\u0027Prevents image from being deleted.\u0027)"},{"line_number":1270,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1271,"context_line":"def do_upload_to_image(cs, args):"},{"line_number":1272,"context_line":"    \"\"\"Uploads volume to Image Service as an image.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_42f5daea","line":1269,"updated":"2016-08-01 21:51:14.000000000","message":"It seems like a good idea to keep the defaults and make them explicit in the help. Is there any reason you removed these (and moved them to volumes.py)?","commit_id":"4448597a7563dac6401f9b6e00978d5dd513f499"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"e35629b73b88075a956d60a3a297a5c56434b8e6","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"           help\u003d\u0027Makes image publicly accessible.\u0027)"},{"line_number":1267,"context_line":"@utils.arg(\u0027--protected\u0027,"},{"line_number":1268,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1269,"context_line":"           help\u003d\u0027Prevents image from being deleted.\u0027)"},{"line_number":1270,"context_line":"@utils.service_type(\u0027volumev3\u0027)"},{"line_number":1271,"context_line":"def do_upload_to_image(cs, args):"},{"line_number":1272,"context_line":"    \"\"\"Uploads volume to Image Service as an image.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_8566bcea","line":1269,"in_reply_to":"bacf61ea_42f5daea","updated":"2016-08-01 22:17:40.000000000","message":"So, if I kept the defaults here it caused some issues. If we\u0027re running version 3.0 and the defaults are here, it will check run the \u0027matches\u0027 check because they\u0027re not None, and it\u0027ll raise an exception no matter what, even if you don\u0027t set them yourself. If you want I can still mention what the defaults are in the help, even though they\u0027re set later.","commit_id":"4448597a7563dac6401f9b6e00978d5dd513f499"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8d94e2b0ac86bc40b2b7dbee8961a29638e27981","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"           help\u003d\u0027The new image name.\u0027)"},{"line_number":1262,"context_line":"@utils.arg(\u0027--image_name\u0027,"},{"line_number":1263,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1264,"context_line":"@utils.arg(\u0027--visibility\u0027,"},{"line_number":1265,"context_line":"           metavar\u003d\u0027\u003cpublic|private\u003e\u0027,"},{"line_number":1266,"context_line":"           help\u003d\u0027Set image visibility to either public or private.\u0027)"},{"line_number":1267,"context_line":"@utils.arg(\u0027--protected\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_7f447eb6","line":1264,"updated":"2016-08-03 20:12:32.000000000","message":"Can you use the @api_version.wraps(\u00273.1) decorator here? I\u0027m not sure that it will work in the midst of these @utils.arg(...) decorators, but it would solve the problem if it did.\nSee https://review.openstack.org/#/c/327692/3/cinderclient/v3/shell.py","commit_id":"1440f1ef0adc9dd12105c3f544a5d5802f1e57ae"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"f6cd00187a6181c6be934be00550696691339c71","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"           help\u003d\u0027The new image name.\u0027)"},{"line_number":1262,"context_line":"@utils.arg(\u0027--image_name\u0027,"},{"line_number":1263,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1264,"context_line":"@utils.arg(\u0027--visibility\u0027,"},{"line_number":1265,"context_line":"           metavar\u003d\u0027\u003cpublic|private\u003e\u0027,"},{"line_number":1266,"context_line":"           help\u003d\u0027Set image visibility to either public or private.\u0027)"},{"line_number":1267,"context_line":"@utils.arg(\u0027--protected\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_227cad71","line":1264,"in_reply_to":"bacf61ea_7f447eb6","updated":"2016-08-03 20:26:01.000000000","message":"Unfortunately looks like that doesn\u0027t work, it doesn\u0027t change the help message issue and makes the whole function unavailable to version 3.0.","commit_id":"1440f1ef0adc9dd12105c3f544a5d5802f1e57ae"}],"cinderclient/v3/volumes.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"1ed5081029535e48dd351f388dc686963204a388","unresolved":false,"context_lines":[{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        :param volume: The :class:`Volume` to upload."},{"line_number":476,"context_line":"        \"\"\""},{"line_number":477,"context_line":"        if visibility is None:"},{"line_number":478,"context_line":"            visibility \u003d \u0027private\u0027"},{"line_number":479,"context_line":"        if protected is None:"},{"line_number":480,"context_line":"            protected \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_22d38661","line":477,"updated":"2016-08-01 21:51:14.000000000","message":"see question in shell.py","commit_id":"4448597a7563dac6401f9b6e00978d5dd513f499"}]}