)]}'
{"id":"openstack%2Fpython-cinderclient~322878","triplet_id":"openstack%2Fpython-cinderclient~master~I1512b86815e7248fa226c6969124ddc654145562","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1587071","hashtags":[],"change_id":"I1512b86815e7248fa226c6969124ddc654145562","subject":"Don\u0027t enable lazy translation when loading client","status":"MERGED","created":"2016-05-30 15:11:25.000000000","updated":"2016-05-30 17:18:46.000000000","submitted":"2016-05-30 17:18:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8481ae136f06f20eae31dddc9c137dcf63dc2029","_number":322878,"virtual_id_number":322878,"owner":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":2,"date":"2016-05-30 17:18:46.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2016-05-30 15:54:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-05-30 15:29:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":1,"date":"2016-05-30 15:37:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2016-05-30 15:54:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-30 15:29:37.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2016-05-30 15:37:02.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2016-05-30 15:54:28.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2016-05-30 17:18:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"101a38e0f15f4b5181a67787a9a27ae367de619a","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2016-05-30 15:11:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ad927b16e4eb1fd3b63dab425e79e941b4b98e2b","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2016-05-30 15:13:33.000000000","message":"Patch Set 1:\n\nThere is a second call to _i18n.enable_lazy() in cinderclient/shell.py. Maybe this one is enough to keep the CLI translated?","accounts_in_message":[],"_revision_number":1},{"id":"a418cf4b75e372762f767b720af01dce545edb3e","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2016-05-30 15:15:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"acb4c61c40922b0496309204cb2326c0a20e4eab","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2016-05-30 15:15:55.000000000","message":"Patch Set 2:\n\n(Oops, patch set 2 fixes pep8, I forgot to remove the import.)","accounts_in_message":[],"_revision_number":2},{"id":"27fbc7befebd9ea6aa509ad95b8b377682e79e88","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2016-05-30 15:17:09.000000000","message":"Patch Set 2:\n\nSylvain Bauza proposed a change to revert the whole commit: change I6a2c58d3ef5ee2a1cbb46816ae38871547aca574. I would prefer to keep the nice \"Graduate to oslo.i18n and cleanup incubator usage\" change, but fix Nova \u0026 Trove.","accounts_in_message":[],"_revision_number":2},{"id":"cfda3df4b7ba703aec1655a46bd18d044e444a73","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2016-05-30 15:19:54.000000000","message":"Patch Set 2:\n\nI actually abandoned https://review.openstack.org/#/c/322868/ which was more an attempt to understand what was going on...","accounts_in_message":[],"_revision_number":2},{"id":"b2235f6386c81d18c6ed0d7a30d18c07ae5687a8","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2016-05-30 15:29:37.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8549f431df569900a57461688ef7d2e8f05958df","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2016-05-30 15:37:02.000000000","message":"Patch Set 2: Code-Review+1\n\nConfirmed that removing the call to _i18n.enable_lazy() fixes https://bugs.launchpad.net/python-cinderclient/+bug/1586976 in Nova","accounts_in_message":[],"_revision_number":2},{"id":"6cf45a1dfdbb6e58becc15184259395dc3fd40ff","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-05-30 15:54:28.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks Victor!","accounts_in_message":[],"_revision_number":2},{"id":"13a5db62903365d696dee7b530c3782bd65e21a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-30 16:23:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/78/322878/2/check/gate-python-cinderclient-docs/a1f3dab//doc/build/html/ : SUCCESS in 1m 54s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/78/322878/2/check/gate-python-cinderclient-pep8/9259621/ : SUCCESS in 1m 50s\n- gate-python-cinderclient-python27 http://logs.openstack.org/78/322878/2/check/gate-python-cinderclient-python27/7f41745/ : SUCCESS in 4m 04s\n- gate-python-cinderclient-python34 http://logs.openstack.org/78/322878/2/check/gate-python-cinderclient-python34/a79cbca/ : SUCCESS in 2m 59s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/78/322878/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/fdcd164/ : SUCCESS in 1h 06m 49s\n- gate-python-cinderclient-pypy http://logs.openstack.org/78/322878/2/check/gate-python-cinderclient-pypy/2baf901/ : FAILURE in 1m 55s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/78/322878/2/check/gate-cinderclient-dsvm-functional/7674c22/ : SUCCESS in 22m 43s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/78/322878/2/check/gate-python-cinderclient-pylint/6ee873f/ : SUCCESS in 2m 03s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0d91199f7e04a5d9e9f894aafad8288f8bc1f495","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-30 16:23:09.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7d5247f1dc650e2d4e74bb1cecc70b4fa824b10d","date":"2016-05-30 17:18:46.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"bf332ea195805500591da2d624879283347c01d8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-30 17:18:46.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/78/322878/2/gate/gate-python-cinderclient-docs/e2e0561//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/78/322878/2/gate/gate-python-cinderclient-pep8/175947a/ : SUCCESS in 2m 14s\n- gate-python-cinderclient-python27 http://logs.openstack.org/78/322878/2/gate/gate-python-cinderclient-python27/3cba221/ : SUCCESS in 1m 55s\n- gate-python-cinderclient-python34 http://logs.openstack.org/78/322878/2/gate/gate-python-cinderclient-python34/56435b2/ : SUCCESS in 3m 02s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/78/322878/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/eba8fce/ : SUCCESS in 55m 04s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"623cef2d5c5d9f375c60c991f5ab9f951e9253fa","revisions":{"103ccc39cbe9601e092f2b5c9e7a2b5b91abbc13":{"kind":"REWORK","_number":1,"created":"2016-05-30 15:11:25.000000000","uploader":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"ref":"refs/changes/78/322878/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/78/322878/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/322878/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/322878/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/322878/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/78/322878/1"}}},"commit":{"parents":[{"commit":"df81163fcef785b862f202170ce8bbbbf4372389","subject":"Merge \"Remove deprecated tempest_lib and use tempest.lib\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/df81163fcef785b862f202170ce8bbbbf4372389"}]}],"author":{"name":"Victor Stinner","email":"vstinner@redhat.com","date":"2016-05-30 15:06:31.000000000","tz":120},"committer":{"name":"Victor Stinner","email":"vstinner@redhat.com","date":"2016-05-30 15:11:08.000000000","tz":120},"subject":"Don\u0027t enable lazy translation when loading client","message":"Don\u0027t enable lazy translation when loading client\n\nThe change I9c8db9487b554b637a41620c858a7e7abf802879 introduced a\nregression in nova and trove. Importing cinderclient.client now calls\n_i18n.enable_lazy() which calls oslo_i18n.enable_lazy(). It\u0027s wrong to\nmodify a global variable (oslo_i18n._lazy.USE_LAZY) when a module is\nimported.\n\nThis change removes the call to _i18n.enable_lazy() from client.py.\n\nCloses-Bug: #1587071\nRelated-Bug: 1586976\nChange-Id: I1512b86815e7248fa226c6969124ddc654145562\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/103ccc39cbe9601e092f2b5c9e7a2b5b91abbc13"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/103ccc39cbe9601e092f2b5c9e7a2b5b91abbc13"}]},"branch":"refs/heads/master"},"623cef2d5c5d9f375c60c991f5ab9f951e9253fa":{"kind":"REWORK","_number":2,"created":"2016-05-30 15:15:09.000000000","uploader":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"ref":"refs/changes/78/322878/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/78/322878/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/322878/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/322878/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/78/322878/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/78/322878/2"}}},"commit":{"parents":[{"commit":"df81163fcef785b862f202170ce8bbbbf4372389","subject":"Merge \"Remove deprecated tempest_lib and use tempest.lib\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/df81163fcef785b862f202170ce8bbbbf4372389"}]}],"author":{"name":"Victor Stinner","email":"vstinner@redhat.com","date":"2016-05-30 15:06:31.000000000","tz":120},"committer":{"name":"Victor Stinner","email":"vstinner@redhat.com","date":"2016-05-30 15:14:15.000000000","tz":120},"subject":"Don\u0027t enable lazy translation when loading client","message":"Don\u0027t enable lazy translation when loading client\n\nThe change I9c8db9487b554b637a41620c858a7e7abf802879 introduced a\nregression in nova and trove. Importing cinderclient.client now calls\n_i18n.enable_lazy() which calls oslo_i18n.enable_lazy(). It\u0027s wrong to\nmodify a global variable (oslo_i18n._lazy.USE_LAZY) when a module is\nimported.\n\nThis change removes the call to _i18n.enable_lazy() from client.py.\n\nCloses-Bug: #1587071\nRelated-Bug: 1586976\nChange-Id: I1512b86815e7248fa226c6969124ddc654145562\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/623cef2d5c5d9f375c60c991f5ab9f951e9253fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/623cef2d5c5d9f375c60c991f5ab9f951e9253fa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}