)]}'
{"id":"openstack%2Fpython-cinderclient~325739","triplet_id":"openstack%2Fpython-cinderclient~master~Ia2e2633068ce5b5e6622474b145a1d4f074fd551","project":"openstack/python-cinderclient","branch":"master","topic":"fix-typeshow-output","hashtags":[],"change_id":"Ia2e2633068ce5b5e6622474b145a1d4f074fd551","subject":"Fix output error for type-show command","status":"MERGED","created":"2016-06-06 06:16:21.000000000","updated":"2016-07-08 04:40:28.000000000","submitted":"2016-07-08 04:40:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4ef1cd5db8ac5f257aa00538859ccf6cd19caaa6","_number":325739,"virtual_id_number":325739,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":2,"date":"2016-07-08 04:40:28.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},{"value":0,"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2016-07-08 03:40:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},{"value":0,"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2016-07-08 03:36:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2016-07-08 03:40:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},{"value":0,"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"date":"2016-07-07 15:56:47.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},{"value":0,"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-07 12:20:14.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2016-06-07 13:03:40.000000000","updated_by":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"reviewer":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"state":"REVIEWER"},{"updated":"2016-06-08 02:35:39.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2016-06-15 15:31:17.000000000","updated_by":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"reviewer":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"state":"REVIEWER"},{"updated":"2016-07-05 12:06:47.000000000","updated_by":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"reviewer":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"state":"REVIEWER"},{"updated":"2016-07-06 08:47:57.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2016-07-07 10:03:48.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2016-07-07 15:56:47.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2016-07-08 03:36:19.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2016-07-08 03:40:13.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2016-07-08 04:40:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f76b23486224fe8c5145891c7f1dd0b0ff3639d8","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-06 06:16:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cb8bfc7e096e45e97b516dc616df3174ce17a66e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-06 07:16:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/325739/1/check/gate-python-cinderclient-docs/3b84881//doc/build/html/ : SUCCESS in 2m 21s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/325739/1/check/gate-python-cinderclient-pep8/76b5404/ : SUCCESS in 2m 16s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/325739/1/check/gate-python-cinderclient-python27/8b0389d/ : SUCCESS in 2m 24s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/325739/1/check/gate-python-cinderclient-python34/1e1902d/ : SUCCESS in 3m 19s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/325739/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/7201718/ : SUCCESS in 58m 12s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/325739/1/check/gate-python-cinderclient-pypy/03b3cf1/ : FAILURE in 2m 08s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/39/325739/1/check/gate-cinderclient-dsvm-functional/3ea761f/ : SUCCESS in 23m 58s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/39/325739/1/check/gate-python-cinderclient-pylint/35cd6ce/ : SUCCESS in 3m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f642fb353c40c0791b43f6432918f22e64b4801c","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-06-06 12:32:14.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e4973de403e6ae3a12d7f75b91cc34328bb7b1cf","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2016-06-06 13:16:01.000000000","message":"Patch Set 1: Code-Review-1\n\nThis should have a bug associated with it. The comments that show the output and how to reproduce should be in that bug, and the comment can just state something about removing the \u0027u\u0027 in the output.","accounts_in_message":[],"_revision_number":1},{"id":"88571eea0c48bf2dca8578e12bff2dd1be216a80","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-06-07 01:23:07.000000000","message":"Patch Set 1:\n\nHi, Huanxuan:\n    You can assign this bug report:\n     https://bugs.launchpad.net/python-cinderclient/+bug/1589461\nThanks","accounts_in_message":[],"_revision_number":1},{"id":"63fb64c5eda9856dcd8367e3f03ef25adf9a2759","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-07 06:04:26.000000000","message":"Patch Set 1:\n\n\u003e Hi, Huanxuan:\n \u003e You can assign this bug report:\n \u003e https://bugs.launchpad.net/python-cinderclient/+bug/1589461\n \u003e Thanks\n\nThank you Cao! I will do that.","accounts_in_message":[],"_revision_number":1},{"id":"cb2e35fec1f4eacc22be19bfad55f874a378be78","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-07 06:41:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7e2d2859ceb97d4c7380e9e50d1cda2301f10aca","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-07 07:08:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7b10b141f2d982742c0b57640a04c2a3daf44760","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-07 07:12:28.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"357237c9b8c051aa009ec2530316dc78418a998a","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-07 07:17:54.000000000","message":"Patch Set 3:\n\n\u003e This should have a bug associated with it. The comments that show\n \u003e the output and how to reproduce should be in that bug, and the\n \u003e comment can just state something about removing the \u0027u\u0027 in the\n \u003e output.\n\nThank you for reviewing. I have s\n\n \u003e This should have a bug associated with it. The comments that show\n \u003e the output and how to reproduce should be in that bug, and the\n \u003e comment can just state something about removing the \u0027u\u0027 in the\n \u003e output.\n\nThank you for reviewing! I have associated with the bug https://bugs.launchpad.net/python-cinderclient/+bug/1589461 which was reported by Cao and update the commit message :)","accounts_in_message":[],"_revision_number":3},{"id":"921fd7478a87683c0a968a08cc47b08e7dd950fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-07 07:57:03.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/325739/3/check/gate-python-cinderclient-docs/64abde6//doc/build/html/ : SUCCESS in 2m 51s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/325739/3/check/gate-python-cinderclient-pep8/5e47126/ : SUCCESS in 3m 17s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/325739/3/check/gate-python-cinderclient-python27/579e760/ : SUCCESS in 2m 48s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/325739/3/check/gate-python-cinderclient-python34/35142b2/ : SUCCESS in 2m 06s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/325739/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient/9de34e0/ : SUCCESS in 43m 00s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/325739/3/check/gate-python-cinderclient-pypy/9ec6d37/ : FAILURE in 1m 22s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/39/325739/3/check/gate-cinderclient-dsvm-functional/3532335/ : SUCCESS in 12m 20s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/39/325739/3/check/gate-python-cinderclient-pylint/65d0969/ : SUCCESS in 1m 35s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6bb789ad5153ffaf25de6dd5aa59f602d26a852c","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2016-06-07 12:20:14.000000000","message":"Patch Set 3: Code-Review+1\n\nTested and works. Thanks!","accounts_in_message":[],"_revision_number":3},{"id":"c46a846652565d49bad0daf4f35b3c46bb1b59a5","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-06-07 13:03:40.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"9c039a910b6e93be6514f55ad73885056b21b1b0","author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"date":"2016-06-15 15:31:17.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"de405def73c9a72b20006a98ef084f0b16f73b88","author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"date":"2016-07-05 12:04:54.000000000","message":"Patch Set 3: Code-Review+1\n\nlgtm","accounts_in_message":[],"_revision_number":3},{"id":"d24de82347f05e63d9fff2ec4890a19b564479ea","author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"date":"2016-07-05 12:06:47.000000000","message":"Patch Set 3: Code-Review-1\n\nLooks like unit test is missing.","accounts_in_message":[],"_revision_number":3},{"id":"c8ab6a845e66cd875c89043c45ac9a450a4d87d4","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2016-07-06 08:47:57.000000000","message":"Patch Set 3: Code-Review+2\n\nA unittest would be nice","accounts_in_message":[],"_revision_number":3},{"id":"15d2cfcb5553c688ffc90a0b1bafb207062d0a6e","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-07-07 02:44:30.000000000","message":"Patch Set 3:\n\n\u003e Looks like unit test is missing.\n\nThis patch just modify the output format, and we can see in the \u0027type-show\u0027 test that the \u0027extra_specs\u0027 is None. I don\u0027t think a unit test is necessary in this review.","accounts_in_message":[],"_revision_number":3},{"id":"b6ec1d0ecf77a66b7e8c9660f5e890934b0f39e7","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2016-07-07 09:32:43.000000000","message":"Patch Set 3:\n\n\u003e \u003e Looks like unit test is missing.\n \u003e \n \u003e This patch just modify the output format, and we can see in the\n \u003e \u0027type-show\u0027 test that the \u0027extra_specs\u0027 is None. I don\u0027t think a\n \u003e unit test is necessary in this review.\n\nThat\u0027s not a good reason.  There is a bug, and our unittests are not detecting it.  You change the code and all unittests pass, which means that we are clearly not checking that part of the code you are fixing, thus the reason why a test would be good.\n\nI\u0027m not pushing for it because it\u0027s a very simple fix, but it\u0027s good practice and I understand why it would be grounds for a downvote for some people.","accounts_in_message":[],"_revision_number":3},{"id":"5cfb520e8baa40c9933de317815d9820d06ff93a","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2016-07-07 10:03:42.000000000","message":"Patch Set 3:\n\nI think a unit test would give value. Just having the formatter exercised in a unit test run has value for preventing silly errors creeping in in future.","accounts_in_message":[],"_revision_number":3},{"id":"fb54d7a2466656c3cccdf1418a6b8d7c00781ef1","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2016-07-07 10:03:48.000000000","message":"Patch Set 3: Code-Review-1","accounts_in_message":[],"_revision_number":3},{"id":"0bb60605cc61cc98790513a99670b9b36b2bd5d1","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-07-07 14:34:17.000000000","message":"Patch Set 3:\n\nOK, I will update the unit test for this patch, thank you for reviewing :)","accounts_in_message":[],"_revision_number":3},{"id":"1d27f8c6b85f64396610d6599e8978e8610104d1","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-07-07 14:37:49.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4c2474063039dffebc7c56929a500cef37362487","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-07-07 14:49:20.000000000","message":"Patch Set 4:\n\nI added \u0027extra_specs\u0027: {u\u0027key\u0027: u\u0027value\u0027} in the fake, and we can see the extra \u0027u\u0027 was removed in the output of the test, the output is \u0027extra_specs\u0027: {\u0027key\u0027: \u0027value\u0027}\nBut I am not sure should we use assertEqual() or assertIn() to check the output of the command, I saw the other commands test not do this and seems like we cannot get the command output in the test?","accounts_in_message":[],"_revision_number":4},{"id":"9bab1397e1b17b7b5c99736ad55e79c8cb13eb3f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-07 16:03:42.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/325739/4/check/gate-python-cinderclient-docs/67bd62b//doc/build/html/ : SUCCESS in 5m 54s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/325739/4/check/gate-python-cinderclient-pep8/cf0170f/ : SUCCESS in 5m 21s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/325739/4/check/gate-python-cinderclient-python27/a43deab/ : SUCCESS in 3m 16s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/325739/4/check/gate-python-cinderclient-python34/9644cb7/ : SUCCESS in 5m 40s\n- gate-python-cinderclient-python35-nv http://logs.openstack.org/39/325739/4/check/gate-python-cinderclient-python35-nv/8c5b0cf/ : SUCCESS in 3m 33s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/325739/4/check/gate-tempest-dsvm-neutron-src-python-cinderclient/68aa92f/ : SUCCESS in 1h 10m 39s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/325739/4/check/gate-python-cinderclient-pypy/07ab0c9/ : SUCCESS in 12m 18s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/39/325739/4/check/gate-cinderclient-dsvm-functional/4af370e/ : SUCCESS in 24m 15s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/39/325739/4/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/199168a/ : FAILURE in 12m 58s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/39/325739/4/check/gate-python-cinderclient-pylint/cff50da/ : SUCCESS in 5m 04s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"f39232452c87bce850366061c0fd98340874277d","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-07-08 01:49:26.000000000","message":"Patch Set 4:\n\nActually we can say this bug is a missing problem of the patch https://review.openstack.org/#/c/281475","accounts_in_message":[],"_revision_number":4},{"id":"66ef53aa5eb5a3ab1d763da83499c4e61fed32c3","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2016-07-08 03:36:19.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"892766b0e0f4661ff19037be4574a22c56db82bf","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-07-08 03:40:13.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"a6d5843779686e221fa073ce5e88386dfbead94a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-08 03:40:23.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"21d8e195695349efbee07c3db99e3eb8c882fdb6","date":"2016-07-08 04:40:28.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"4c1ac6106de1c1c09c24ed46d41af6b8f24600d4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-08 04:40:28.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/325739/4/gate/gate-python-cinderclient-docs/19a8ed4//doc/build/html/ : SUCCESS in 2m 42s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/325739/4/gate/gate-python-cinderclient-pep8/185b983/ : SUCCESS in 3m 11s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/325739/4/gate/gate-python-cinderclient-python27/b4ec169/ : SUCCESS in 3m 06s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/325739/4/gate/gate-python-cinderclient-python34/cb7ee1d/ : SUCCESS in 2m 27s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/325739/4/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/3171134/ : SUCCESS in 59m 23s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"724901e3740fd6429a851f4dbceecbc117750c44","revisions":{"67c8845fc21b1fb6c1cd65e09c89a87a30a782d8":{"kind":"REWORK","_number":1,"created":"2016-06-06 06:16:21.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/39/325739/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/325739/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/1"}}},"commit":{"parents":[{"commit":"47cedfe9c35c0911eee1ec5fed38095664ff1e2f","subject":"Merge \"Make __repr__ print encryption_id for VolumeEncryptionType class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/47cedfe9c35c0911eee1ec5fed38095664ff1e2f"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-06 06:15:38.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-06 06:15:38.000000000","tz":480},"subject":"Fix output error for type-show command","message":"Fix output error for type-show command\n\nFor example, before this patch, the output\nof \"extra_specs\" in type-show command is this:\n| extra_specs | {u\u0027Alpha\u0027: u\u0027a\u0027} |\nThis patch fix it and change the output to this:\n| extra_specs | {\u0027Alpha\u0027: \u0027a\u0027} |\n\nChange-Id: Ia2e2633068ce5b5e6622474b145a1d4f074fd551\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/67c8845fc21b1fb6c1cd65e09c89a87a30a782d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/67c8845fc21b1fb6c1cd65e09c89a87a30a782d8"}]},"branch":"refs/heads/master"},"28ff801bc96c6094b65f728357ea2a746e3d0b9f":{"kind":"REWORK","_number":2,"created":"2016-06-07 07:08:14.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/39/325739/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/325739/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/2"}}},"commit":{"parents":[{"commit":"47cedfe9c35c0911eee1ec5fed38095664ff1e2f","subject":"Merge \"Make __repr__ print encryption_id for VolumeEncryptionType class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/47cedfe9c35c0911eee1ec5fed38095664ff1e2f"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-06 06:15:38.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-07 06:50:02.000000000","tz":480},"subject":"Fix output error for type-show command","message":"Fix output error for type-show command\n\nFor example, before this patch, the output of\n\"extra_specs\" in type-show command is this:\n| extra_specs | {u\u0027Alpha\u0027: u\u0027a\u0027} |\nBecuase the type of \"extra_specs\" is not a string\nand need to use unicode_key_value_to_string()\nmethod to change it to string.\nThis patch fix it and change the output to this:\n| extra_specs | {\u0027Alpha\u0027: \u0027a\u0027} |\n\nChange-Id: Ia2e2633068ce5b5e6622474b145a1d4f074fd551\nCloses-Bug: #1589461\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/28ff801bc96c6094b65f728357ea2a746e3d0b9f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/28ff801bc96c6094b65f728357ea2a746e3d0b9f"}]},"branch":"refs/heads/master"},"43a56d2bdb9976386a0dd12b604c4380ed8e17c5":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-06-07 07:12:28.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/39/325739/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/325739/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/3"}}},"commit":{"parents":[{"commit":"47cedfe9c35c0911eee1ec5fed38095664ff1e2f","subject":"Merge \"Make __repr__ print encryption_id for VolumeEncryptionType class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/47cedfe9c35c0911eee1ec5fed38095664ff1e2f"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-06 06:15:38.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-07 07:09:29.000000000","tz":480},"subject":"Fix output error for type-show command","message":"Fix output error for type-show command\n\nBefore this patch, the output of \"extra_specs\"\nin type-show command is this:\n| extra_specs | {u\u0027Alpha\u0027: u\u0027a\u0027} |\nBecuase the type of \"extra_specs\" is not a string\nand need to use unicode_key_value_to_string()\nmethod to change it to string.\n\nThis patch add formatters and call\nunicode_key_value_to_string() mothod for\n\"extra_specs\" and change the output to this:\n| extra_specs | {\u0027Alpha\u0027: \u0027a\u0027} |\n\nChange-Id: Ia2e2633068ce5b5e6622474b145a1d4f074fd551\nCloses-Bug: #1589461\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/43a56d2bdb9976386a0dd12b604c4380ed8e17c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/43a56d2bdb9976386a0dd12b604c4380ed8e17c5"}]},"branch":"refs/heads/master"},"724901e3740fd6429a851f4dbceecbc117750c44":{"kind":"REWORK","_number":4,"created":"2016-07-07 14:37:49.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/39/325739/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/325739/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/325739/4"}}},"commit":{"parents":[{"commit":"47cedfe9c35c0911eee1ec5fed38095664ff1e2f","subject":"Merge \"Make __repr__ print encryption_id for VolumeEncryptionType class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/47cedfe9c35c0911eee1ec5fed38095664ff1e2f"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-06 06:15:38.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-07-07 14:37:33.000000000","tz":480},"subject":"Fix output error for type-show command","message":"Fix output error for type-show command\n\nBefore this patch, the output of \"extra_specs\"\nin type-show command is this:\n| extra_specs | {u\u0027Alpha\u0027: u\u0027a\u0027} |\nBecuase the type of \"extra_specs\" is not a string\nand need to use unicode_key_value_to_string()\nmethod to change it to string.\n\nThis patch add formatters and call\nunicode_key_value_to_string() mothod for\n\"extra_specs\" and change the output to this:\n| extra_specs | {\u0027Alpha\u0027: \u0027a\u0027} |\n\nChange-Id: Ia2e2633068ce5b5e6622474b145a1d4f074fd551\nCloses-Bug: #1589461\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/724901e3740fd6429a851f4dbceecbc117750c44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/724901e3740fd6429a851f4dbceecbc117750c44"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}