)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"6aefef1e45a4aa871693434319fe3fcc3ee9f152","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    return metadata"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def _extract_connector(connector_args):"},{"line_number":146,"context_line":"    connector \u003d {}"},{"line_number":147,"context_line":"    for metadatum in connector_args:"},{"line_number":148,"context_line":"        # unset doesn\u0027t require a val, so we have the if/else"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_096453e3","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":39},"updated":"2016-06-16 00:59:17.000000000","message":"Ended up not needing/using this... will remove.","commit_id":"e6293f16c961c319bfa3287761c2ecf42251e23b"}],"cinderclient/v3/volumes.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"32710beb67aa99b2606795b94e43044742760caa","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        :param connector: connector dict from nova."},{"line_number":212,"context_line":"        :param instance_uuid: UUID of the Instance being attached to"},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        return self.manager.remove_attachment(self, connector)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class VolumeManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_954edf38","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":62},"updated":"2016-06-08 23:12:49.000000000","message":"Ooops, this branch is missing the get_attachments interface.  I\u0027ll get that fixed shortly.","commit_id":"065ccf3286e4254fcd6e036aefc42a2ce5468d37"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e04054a03e4dc3f9c2af0a5f2681f0fce5538c79","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        return self.manager.get_pools(detail)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def create_attachment(self, volume, connector, instance_uuid, mountpoint,"},{"line_number":219,"context_line":"                          no_connect\u003dFalse):"},{"line_number":220,"context_line":"        \"\"\"Create an attachment for the specified volume."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :param volume: The :class:`Volume` (or its ID)."}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_2b9a1015","line":219,"updated":"2016-09-28 18:44:45.000000000","message":"so this API requires an instance_uuid to be passed in, which is fine for Nova.  But for ironic attachments where an end user wants to attach a volume to the host, there is no instance_uuid.\n\nI\u0027m working on updating the brick_cinderclient_extension to use the new attach workflow.  Since the end user initiates the attach workflow using the cinderclient directly from the bare metal host, there is no instance_uuid, they only have the hostname.","commit_id":"9cf7b16c6c368a3ac7e6d8a2bdbe8410147689e7"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"22431e9b2a4a9edc52778f0a111e1e8c4aae787a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        return self.manager.get_pools(detail)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def create_attachment(self, volume, connector, instance_uuid, mountpoint,"},{"line_number":219,"context_line":"                          no_connect\u003dFalse):"},{"line_number":220,"context_line":"        \"\"\"Create an attachment for the specified volume."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :param volume: The :class:`Volume` (or its ID)."}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_4b6cff07","line":219,"in_reply_to":"3a98d1f4_2b9a1015","updated":"2016-10-03 15:04:34.000000000","message":"Yeah, I\u0027ve been hacking that to just a string and passing in an \"ID\" of whatever I\u0027m attaching to.  That way we still show in the volume-list/show what we\u0027re attached to with some form of identifier.\n\nFor bare-metal I was reading out the UUID of the root disk, seems that\u0027s not a fully valid V4 UUID based on the oslo lib checks, but I haven\u0027t dug into why.  Instead just figured we would make it a string for non-nova cases.","commit_id":"9cf7b16c6c368a3ac7e6d8a2bdbe8410147689e7"}]}