)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"189ac363bff023d8a8a349b4f97a98721b05fd97","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":293,"context_line":"    info.update(volume._info)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    if info[\u0027metadata\u0027] is not None:"},{"line_number":296,"context_line":"        data \u003d info[\u0027metadata\u0027]"},{"line_number":297,"context_line":"        if \u0027readonly\u0027 in data:"},{"line_number":298,"context_line":"            info[\u0027readonly\u0027] \u003d data[\u0027readonly\u0027]"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":301,"context_line":"    utils.print_dict(info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_2cae5285","line":298,"range":{"start_line":295,"start_character":4,"end_line":298,"end_character":47},"updated":"2016-07-25 16:59:32.000000000","message":"It would be easier to just use try ... except:\n\ntry:\n    info[\u0027readonly\u0027] \u003d info[\u0027metadata\u0027][\u0027readonly\u0027]\nexcept KeyError:\n    pass","commit_id":"551e4c927f150f4817687714c15d76ec572c3ccf"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"189ac363bff023d8a8a349b4f97a98721b05fd97","unresolved":false,"context_lines":[{"line_number":447,"context_line":"    volume \u003d cs.volumes.get(volume.id)"},{"line_number":448,"context_line":"    info.update(volume._info)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    if info[\u0027metadata\u0027] is not None:"},{"line_number":451,"context_line":"        data \u003d info[\u0027metadata\u0027]"},{"line_number":452,"context_line":"        if \u0027readonly\u0027 in data:"},{"line_number":453,"context_line":"            info[\u0027readonly\u0027] \u003d data[\u0027readonly\u0027]"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":456,"context_line":"    utils.print_dict(info)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_ecca7a4e","line":453,"range":{"start_line":450,"start_character":4,"end_line":453,"end_character":47},"updated":"2016-07-25 16:59:32.000000000","message":"same","commit_id":"551e4c927f150f4817687714c15d76ec572c3ccf"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"642d839436507af71b0788eaebf5dc1f3ce328e4","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    info.update(volume._info)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    try:"},{"line_number":303,"context_line":"        info[\u0027readonly\u0027] \u003d info[\u0027metadata\u0027][\u0027readonly\u0027]"},{"line_number":304,"context_line":"    except KeyError:"},{"line_number":305,"context_line":"        pass"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_0f47aa4b","line":303,"range":{"start_line":303,"start_character":41,"end_line":303,"end_character":45},"updated":"2016-08-29 12:46:10.000000000","message":"Why not just \ninfo[\u0027readonly\u0027] \u003d info[\u0027metadata\u0027].get(\u0027readonly\u0027) ?","commit_id":"66569fc70d842c09ad6e4f06a1199d721d9b31a7"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"c3814b882b0a47c9569beb43ebb67af1dbd01295","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    info.update(volume._info)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    try:"},{"line_number":303,"context_line":"        info[\u0027readonly\u0027] \u003d info[\u0027metadata\u0027][\u0027readonly\u0027]"},{"line_number":304,"context_line":"    except KeyError:"},{"line_number":305,"context_line":"        pass"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_760e263c","line":303,"range":{"start_line":303,"start_character":41,"end_line":303,"end_character":45},"in_reply_to":"fa7ab95a_0f47aa4b","updated":"2016-09-12 05:03:48.000000000","message":"The readonly key should not exist when metadata key does not have it.. so I needed an extra line..I have uploaded in pacthset 8","commit_id":"66569fc70d842c09ad6e4f06a1199d721d9b31a7"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"642d839436507af71b0788eaebf5dc1f3ce328e4","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    info.update(volume._info)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    try:"},{"line_number":458,"context_line":"        info[\u0027readonly\u0027] \u003d info[\u0027metadata\u0027][\u0027readonly\u0027]"},{"line_number":459,"context_line":"    except KeyError:"},{"line_number":460,"context_line":"        pass"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_6f6cb6d0","line":458,"range":{"start_line":458,"start_character":8,"end_line":458,"end_character":12},"updated":"2016-08-29 12:46:10.000000000","message":"ditto","commit_id":"66569fc70d842c09ad6e4f06a1199d721d9b31a7"}]}