)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"1bea45370691afb7c396b9cd41b7ea777867a2dc","unresolved":false,"context_lines":[{"line_number":2176,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":2177,"context_line":"    cs.volumes.update_readonly_flag(volume,"},{"line_number":2178,"context_line":"                                    strutils.bool_from_string(args.read_only,"},{"line_number":2179,"context_line":"                                                              strict\u003dTrue))"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"@utils.arg(\u0027volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027, help\u003d\u0027ID of the volume to update.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_45c79795","line":2179,"range":{"start_line":2179,"start_character":62,"end_line":2179,"end_character":75},"updated":"2016-06-27 10:56:09.000000000","message":"Actually, here the checking is not necessary as the read_only will be checked by argparse\u0027s \"choices\" before this checking.\nHowever, for consistency IMO it\u0027s better to fix it as well.","commit_id":"dcef9037ce5d280c0317c52dfe1cbce1c8f78654"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b6361911ed4a9d7e0afa7a8427af222735193fa2","unresolved":false,"context_lines":[{"line_number":2176,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":2177,"context_line":"    cs.volumes.update_readonly_flag(volume,"},{"line_number":2178,"context_line":"                                    strutils.bool_from_string(args.read_only,"},{"line_number":2179,"context_line":"                                                              strict\u003dTrue))"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"@utils.arg(\u0027volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027, help\u003d\u0027ID of the volume to update.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_8f635941","line":2179,"range":{"start_line":2179,"start_character":62,"end_line":2179,"end_character":75},"in_reply_to":"3aaa91ec_45c79795","updated":"2016-06-27 12:23:30.000000000","message":"I agree, it doesn\u0027t add much code and the consistency is good.","commit_id":"dcef9037ce5d280c0317c52dfe1cbce1c8f78654"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"1bea45370691afb7c396b9cd41b7ea777867a2dc","unresolved":false,"context_lines":[{"line_number":2190,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":2191,"context_line":"    cs.volumes.set_bootable(volume,"},{"line_number":2192,"context_line":"                            strutils.bool_from_string(args.bootable,"},{"line_number":2193,"context_line":"                                                      strict\u003dTrue))"},{"line_number":2194,"context_line":""},{"line_number":2195,"context_line":""},{"line_number":2196,"context_line":"@utils.arg(\u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_c5eb8711","line":2193,"range":{"start_line":2193,"start_character":54,"end_line":2193,"end_character":65},"updated":"2016-06-27 10:56:09.000000000","message":"ditto","commit_id":"dcef9037ce5d280c0317c52dfe1cbce1c8f78654"}]}