)]}'
{"id":"openstack%2Fpython-cinderclient~334299","triplet_id":"openstack%2Fpython-cinderclient~master~I896ddbb6ec4760bfd4d721db960138e2df0b86e1","project":"openstack/python-cinderclient","branch":"master","topic":"bool_strict_checking","hashtags":[],"change_id":"I896ddbb6ec4760bfd4d721db960138e2df0b86e1","subject":"Add strict Boolean checking","status":"MERGED","created":"2016-06-27 06:19:15.000000000","updated":"2016-06-27 17:05:59.000000000","submitted":"2016-06-27 17:05:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c1183da7d868858e615630406bb967d69145bd9","_number":334299,"virtual_id_number":334299,"owner":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":2,"date":"2016-06-27 17:05:59.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-27 15:54:59.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":2,"date":"2016-06-27 12:23:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-06-27 15:54:59.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-27 12:23:55.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2016-06-27 15:54:59.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2016-06-27 17:05:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"72f65bd0bb8ad741e69c208fbd4d0e8ad1fbafda","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-06-27 06:19:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9e1cff38dbf106e48c7797f7e08ecf567c911102","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-27 07:19:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/99/334299/1/check/gate-python-cinderclient-docs/5607e4e//doc/build/html/ : SUCCESS in 2m 29s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/99/334299/1/check/gate-python-cinderclient-pep8/d73959a/ : SUCCESS in 2m 00s\n- gate-python-cinderclient-python27 http://logs.openstack.org/99/334299/1/check/gate-python-cinderclient-python27/5702ee5/ : SUCCESS in 3m 07s\n- gate-python-cinderclient-python34 http://logs.openstack.org/99/334299/1/check/gate-python-cinderclient-python34/6bb470b/ : SUCCESS in 3m 17s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/99/334299/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/5e83ac7/ : SUCCESS in 56m 54s\n- gate-python-cinderclient-pypy http://logs.openstack.org/99/334299/1/check/gate-python-cinderclient-pypy/42417fd/ : FAILURE in 2m 48s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/99/334299/1/check/gate-cinderclient-dsvm-functional/6e0c65a/ : SUCCESS in 22m 32s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/99/334299/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/267a0dd/ : FAILURE in 24m 45s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/99/334299/1/check/gate-python-cinderclient-pylint/a330363/ : SUCCESS in 4m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"53097c405c5e4f5926bab773fd0a89ea5b4ca19e","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2016-06-27 10:08:45.000000000","message":"Patch Set 1: Code-Review+2\n\nA test or two would be nice.","accounts_in_message":[],"_revision_number":1},{"id":"3fa2b91871c78e2ea74c14c3f3edb91a9bebe836","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-06-27 10:48:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1bea45370691afb7c396b9cd41b7ea777867a2dc","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-06-27 10:56:09.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nHi, Gorka,\nThanks for your review.\nI added two cases. But for read_only/bootable, as the reason mentioned in my comments, I have\u0027t added cases to cover them.","accounts_in_message":[],"_revision_number":1},{"id":"fa84dc0faffec361997549cf0f0fc440d475182a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-27 12:04:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/99/334299/2/check/gate-python-cinderclient-docs/c195458//doc/build/html/ : SUCCESS in 2m 21s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/99/334299/2/check/gate-python-cinderclient-pep8/420ff66/ : SUCCESS in 3m 51s\n- gate-python-cinderclient-python27 http://logs.openstack.org/99/334299/2/check/gate-python-cinderclient-python27/ee804af/ : SUCCESS in 6m 38s\n- gate-python-cinderclient-python34 http://logs.openstack.org/99/334299/2/check/gate-python-cinderclient-python34/268ab07/ : SUCCESS in 3m 34s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/99/334299/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/35d712a/ : SUCCESS in 1h 02m 54s\n- gate-python-cinderclient-pypy http://logs.openstack.org/99/334299/2/check/gate-python-cinderclient-pypy/126b830/ : FAILURE in 3m 33s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/99/334299/2/check/gate-cinderclient-dsvm-functional/715161f/ : SUCCESS in 25m 10s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/99/334299/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/93eb8e6/ : FAILURE in 14m 13s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/99/334299/2/check/gate-python-cinderclient-pylint/15e12d6/ : SUCCESS in 4m 55s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b6361911ed4a9d7e0afa7a8427af222735193fa2","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2016-06-27 12:23:30.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nTh","accounts_in_message":[],"_revision_number":1},{"id":"23911aa5c7bed90913d18259a7ea16a0c9b03228","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2016-06-27 12:23:55.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks for adding the tests","accounts_in_message":[],"_revision_number":2},{"id":"ec8655c67c74a029e8838f8e405cb5140ef1afa7","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2016-06-27 15:54:59.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"538908d8d0d636969d7388045b32bd90f8fbf8b8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-27 15:55:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"fb10f5d219ec7f413daa779ece28325fd59159ef","date":"2016-06-27 17:05:59.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"6b6cb9f1137c6903026c5fa04de321b49a8ef4b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-27 17:05:59.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/99/334299/2/gate/gate-python-cinderclient-docs/026d6f8//doc/build/html/ : SUCCESS in 3m 57s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/99/334299/2/gate/gate-python-cinderclient-pep8/e0a2da7/ : SUCCESS in 4m 15s\n- gate-python-cinderclient-python27 http://logs.openstack.org/99/334299/2/gate/gate-python-cinderclient-python27/b0648ea/ : SUCCESS in 3m 57s\n- gate-python-cinderclient-python34 http://logs.openstack.org/99/334299/2/gate/gate-python-cinderclient-python34/0e67836/ : SUCCESS in 3m 04s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/99/334299/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/319c642/ : SUCCESS in 1h 07m 29s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e5e0a7ee49226e52228e326098bbffa7a61dfe4d","revisions":{"dcef9037ce5d280c0317c52dfe1cbce1c8f78654":{"kind":"REWORK","_number":1,"created":"2016-06-27 06:19:15.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/99/334299/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/99/334299/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/99/334299/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/99/334299/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/99/334299/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/99/334299/1"}}},"commit":{"parents":[{"commit":"6cadb738b8427cea68ccaeaa09aa0183211e4344","subject":"Merge \"Fix Capabilities.__repr__ to remove the undefined attribute\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6cadb738b8427cea68ccaeaa09aa0183211e4344"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2016-06-27 07:54:21.000000000","tz":-240},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2016-06-27 08:10:48.000000000","tz":-240},"subject":"Add strict Boolean checking","message":"Add strict Boolean checking\n\nBecause of lack of strict boolean checking, the unexpected\n\u0027False\u0027 value will always be send to server if invalid bool\nvalue is specifed.\nFor instance:\n  the parameter \u0027is-public\u0027 of cinder type-update,\n  the parameter \u0027force\u0027 of cinder qos-delete\nas so forth.\n\nThis patch tries to add a strict checking for them\nto prevent invalid bool value.\n\nChange-Id: I896ddbb6ec4760bfd4d721db960138e2df0b86e1\nCloses-Bug: #1596418\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/dcef9037ce5d280c0317c52dfe1cbce1c8f78654"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/dcef9037ce5d280c0317c52dfe1cbce1c8f78654"}]},"branch":"refs/heads/master"},"e5e0a7ee49226e52228e326098bbffa7a61dfe4d":{"kind":"REWORK","_number":2,"created":"2016-06-27 10:48:59.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/99/334299/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/99/334299/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/99/334299/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/99/334299/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/99/334299/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/99/334299/2"}}},"commit":{"parents":[{"commit":"6cadb738b8427cea68ccaeaa09aa0183211e4344","subject":"Merge \"Fix Capabilities.__repr__ to remove the undefined attribute\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6cadb738b8427cea68ccaeaa09aa0183211e4344"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2016-06-27 07:54:21.000000000","tz":-240},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2016-06-27 12:41:11.000000000","tz":-240},"subject":"Add strict Boolean checking","message":"Add strict Boolean checking\n\nBecause of lack of strict boolean checking, the unexpected\n\u0027False\u0027 value will always be send to server if invalid bool\nvalue is specifed.\nFor instance:\n  the parameter \u0027is-public\u0027 of cinder type-update,\n  the parameter \u0027force\u0027 of cinder qos-delete\nas so forth.\n\nThis patch tries to add a strict checking for them\nto prevent invalid bool value.\n\nChange-Id: I896ddbb6ec4760bfd4d721db960138e2df0b86e1\nCloses-Bug: #1596418\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e5e0a7ee49226e52228e326098bbffa7a61dfe4d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e5e0a7ee49226e52228e326098bbffa7a61dfe4d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}