)]}'
{"cinderclient/tests/unit/v1/test_types.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9789a8139b01d422881888eb02bc3b223021f203","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        t.unset_keys([\u0027k\u0027])"},{"line_number":43,"context_line":"        cs.assert_called(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_unsset_multiple_keys(self):"},{"line_number":46,"context_line":"        t \u003d cs.volume_types.get(1)"},{"line_number":47,"context_line":"        t.unset_keys([\u0027k\u0027, \u0027m\u0027])"},{"line_number":48,"context_line":"        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_57533b17","line":45,"range":{"start_line":45,"start_character":13,"end_line":45,"end_character":19},"updated":"2016-06-29 15:06:23.000000000","message":"unset*","commit_id":"62f8dd1e4c032134e1cb614963e2d793c7b55f59"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"0493a2976b6a5a94cba8d243bf31b703504d05f4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        t.unset_keys([\u0027k\u0027])"},{"line_number":43,"context_line":"        cs.assert_called(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_unsset_multiple_keys(self):"},{"line_number":46,"context_line":"        t \u003d cs.volume_types.get(1)"},{"line_number":47,"context_line":"        t.unset_keys([\u0027k\u0027, \u0027m\u0027])"},{"line_number":48,"context_line":"        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3ae47dde","line":45,"range":{"start_line":45,"start_character":13,"end_line":45,"end_character":19},"in_reply_to":"3aaa91ec_57533b17","updated":"2016-06-30 01:39:04.000000000","message":"Uh, my fault, thank you","commit_id":"62f8dd1e4c032134e1cb614963e2d793c7b55f59"}],"cinderclient/tests/unit/v2/test_types.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9789a8139b01d422881888eb02bc3b223021f203","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        cs.assert_called(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"},{"line_number":94,"context_line":"        self._assert_request_id(t)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_unsset_multiple_keys(self):"},{"line_number":97,"context_line":"        t \u003d cs.volume_types.get(1)"},{"line_number":98,"context_line":"        t.unset_keys([\u0027k\u0027, \u0027m\u0027])"},{"line_number":99,"context_line":"        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f742273d","line":96,"range":{"start_line":96,"start_character":13,"end_line":96,"end_character":19},"updated":"2016-06-29 15:06:23.000000000","message":"unset*","commit_id":"62f8dd1e4c032134e1cb614963e2d793c7b55f59"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"0493a2976b6a5a94cba8d243bf31b703504d05f4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        cs.assert_called(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"},{"line_number":94,"context_line":"        self._assert_request_id(t)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_unsset_multiple_keys(self):"},{"line_number":97,"context_line":"        t \u003d cs.volume_types.get(1)"},{"line_number":98,"context_line":"        t.unset_keys([\u0027k\u0027, \u0027m\u0027])"},{"line_number":99,"context_line":"        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_7ad28501","line":96,"range":{"start_line":96,"start_character":13,"end_line":96,"end_character":19},"in_reply_to":"3aaa91ec_f742273d","updated":"2016-06-30 01:39:04.000000000","message":"Done","commit_id":"62f8dd1e4c032134e1cb614963e2d793c7b55f59"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"dd268c95bf260d30e64d354fa4516a62301f9212","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        t.unset_keys([\u0027k\u0027, \u0027m\u0027])"},{"line_number":99,"context_line":"        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"},{"line_number":100,"context_line":"        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/m\u0027)"},{"line_number":101,"context_line":"        self._assert_request_id(t)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_delete(self):"},{"line_number":104,"context_line":"        t \u003d cs.volume_types.delete(1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_de5fdfe2","line":101,"range":{"start_line":101,"start_character":13,"end_line":101,"end_character":31},"updated":"2016-07-01 09:45:30.000000000","message":"This request_id is returned by get() function in line 97.\nNow, unset_keys return request_id itself.\nSo I think this test should be:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n    def test_unset_multiple_keys(self):\n        t \u003d cs.volume_types.get(1)\n        res \u003d t.unset_keys([\u0027k\u0027, \u0027m\u0027])\n        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)\n        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/m\u0027)\n        self._assert_request_id(res)\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nI think we should also update the previous test.","commit_id":"c6fe2eae73351c69f96589be9dfa6a6714adda75"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"fb3c6979a7ee9d67b9a905a3af0b763c6105f515","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        t.unset_keys([\u0027k\u0027, \u0027m\u0027])"},{"line_number":99,"context_line":"        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"},{"line_number":100,"context_line":"        cs.assert_called_anytime(\u0027DELETE\u0027, \u0027/types/1/extra_specs/m\u0027)"},{"line_number":101,"context_line":"        self._assert_request_id(t)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_delete(self):"},{"line_number":104,"context_line":"        t \u003d cs.volume_types.delete(1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_b8425066","line":101,"range":{"start_line":101,"start_character":13,"end_line":101,"end_character":31},"in_reply_to":"3aaa91ec_de5fdfe2","updated":"2016-07-06 06:59:58.000000000","message":"exactly! thank you, now response of unset_keys() is ListWithMeta class, that contain multiple request ids, I have to make _assert_request_id() supporting to assert multiple request ids.","commit_id":"c6fe2eae73351c69f96589be9dfa6a6714adda75"}],"cinderclient/v1/volume_types.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"dd268c95bf260d30e64d354fa4516a62301f9212","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                base.getid(self), k))"},{"line_number":74,"context_line":"            response_list.append(resp)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        return common_base.ListWithMeta([], response_list)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class VolumeTypeManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1e1e875e","line":76,"range":{"start_line":76,"start_character":7,"end_line":76,"end_character":58},"updated":"2016-07-01 09:45:30.000000000","message":"It\u0027s not necessary to return request_id in v1 api.","commit_id":"c6fe2eae73351c69f96589be9dfa6a6714adda75"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8a696adc24fd0a3fa3063de7751580a172fba67e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                base.getid(self), k))"},{"line_number":74,"context_line":"            response_list.append(resp)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        return common_base.ListWithMeta([], response_list)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class VolumeTypeManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_134a67ac","line":76,"range":{"start_line":76,"start_character":7,"end_line":76,"end_character":58},"in_reply_to":"3aaa91ec_1e1e875e","updated":"2016-07-06 07:02:29.000000000","message":"Done","commit_id":"c6fe2eae73351c69f96589be9dfa6a6714adda75"}]}