)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"a112c62021e85be19663132b36df32ad347d2127","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                                                 force\u003dargs.force)"},{"line_number":363,"context_line":"            print(\"Request to delete volume %s has been accepted.\" % (volume))"},{"line_number":364,"context_line":"        except Exception as e:"},{"line_number":365,"context_line":"            failure_count +\u003d 1"},{"line_number":366,"context_line":"            print(\"Delete for volume %s failed: %s\" % (volume, e))"},{"line_number":367,"context_line":"    if failure_count \u003d\u003d len(args.volume):"},{"line_number":368,"context_line":"        raise exceptions.CommandError(\"Unable to delete any of the specified \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_a0295f39","line":365,"range":{"start_line":365,"start_character":12,"end_line":365,"end_character":25},"updated":"2017-01-04 23:35:01.000000000","message":"would importing traceback and traceback.print_exc() be helpful here to log the exception?\nNote: If the exception can be specific, then it is better to raise that, rather than the generic Exception","commit_id":"67ae4f8e6b6ff8c6d8000bd0987766bbb0d1bc9a"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"a112c62021e85be19663132b36df32ad347d2127","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            failure_count +\u003d 1"},{"line_number":366,"context_line":"            print(\"Delete for volume %s failed: %s\" % (volume, e))"},{"line_number":367,"context_line":"    if failure_count \u003d\u003d len(args.volume):"},{"line_number":368,"context_line":"        raise exceptions.CommandError(\"Unable to delete any of the specified \""},{"line_number":369,"context_line":"                                      \"volumes.\")"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_00022bb4","line":368,"range":{"start_line":368,"start_character":13,"end_line":368,"end_character":37},"updated":"2017-01-04 23:35:01.000000000","message":"Raising another exception here, wouldn\u0027t we loose the traceback for the first one","commit_id":"67ae4f8e6b6ff8c6d8000bd0987766bbb0d1bc9a"}]}
