)]}'
{"cinderclient/tests/functional/base.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"91e45a05651d8457467422585cd719d6e50c605e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self.fail(\"%s %s not deleted after %d seconds.\""},{"line_number":158,"context_line":"                      % (object_name, object_id, timeout))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def object_create(self, object_name, params\u003d\u0027\u0027):"},{"line_number":161,"context_line":"        \"\"\"Create an object."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param object_name: object name"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_2946e67a","line":160,"updated":"2016-07-12 16:39:08.000000000","message":"Why do we need this change?","commit_id":"95bcb4a01bc110bef7aec9efded1dc4e14b29d97"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"1421f6a999a7ed940243c4aaadde8963f5d17ddd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self.fail(\"%s %s not deleted after %d seconds.\""},{"line_number":158,"context_line":"                      % (object_name, object_id, timeout))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def object_create(self, object_name, params\u003d\u0027\u0027):"},{"line_number":161,"context_line":"        \"\"\"Create an object."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param object_name: object name"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_d1440048","line":160,"in_reply_to":"1aa78d24_2946e67a","updated":"2016-07-13 10:30:19.000000000","message":"I believe don\u0027t need \u003d)","commit_id":"95bcb4a01bc110bef7aec9efded1dc4e14b29d97"}],"cinderclient/tests/functional/test_volume_create_cli.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"91e45a05651d8457467422585cd719d6e50c605e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed, ex_text,"},{"line_number":28,"context_line":"                              self.object_create, \u0027volume\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_volume_create_with_incorrect_parameters_01(self):"},{"line_number":31,"context_line":"        \"\"\"Create and a volume with incorrect volume size \u003d -1\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        ex_text \u003d (r\u0027Invalid volume size provided for create request\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_a9a4964a","line":30,"updated":"2016-07-12 16:39:08.000000000","message":"Please, use ddt library here","commit_id":"95bcb4a01bc110bef7aec9efded1dc4e14b29d97"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"1421f6a999a7ed940243c4aaadde8963f5d17ddd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed, ex_text,"},{"line_number":28,"context_line":"                              self.object_create, \u0027volume\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_volume_create_with_incorrect_parameters_01(self):"},{"line_number":31,"context_line":"        \"\"\"Create and a volume with incorrect volume size \u003d -1\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        ex_text \u003d (r\u0027Invalid volume size provided for create request\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c6a3a841","line":30,"in_reply_to":"1aa78d24_a9a4964a","updated":"2016-07-13 10:30:19.000000000","message":"Done","commit_id":"95bcb4a01bc110bef7aec9efded1dc4e14b29d97"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"77fd379243f2f194d91b1e9d45339893d735aa75","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        (\u0027999999999\u0027, r\u0027VolumeSizeExceedsAvailableQuota\u0027)"},{"line_number":31,"context_line":"    )"},{"line_number":32,"context_line":"    @ddt.unpack"},{"line_number":33,"context_line":"    def test_volume_create_with_incorrect_parameters(self, value, ex_text):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        six.assertRaisesRegex(self, exceptions.CommandFailed, ex_text,"},{"line_number":36,"context_line":"                              self.object_create, \u0027volume\u0027, params\u003dvalue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_a3a9ee92","line":33,"updated":"2016-07-14 09:55:38.000000000","message":"nit: parameters \u003d\u003e size","commit_id":"a79a494eabb657868b994f73c0f24cd1b225c888"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"08a1403c551711e3006cd952edc0cbc84c73fa70","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class CinderVolumeNegativeTests(base.ClientTestBase):"},{"line_number":23,"context_line":"    \"\"\"Check of cinder volume create commands.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @ddt.data("},{"line_number":26,"context_line":"        (\u0027\u0027, (r\u0027Size is a required parameter\u0027)),"},{"line_number":27,"context_line":"        (\u0027-1\u0027, (r\u0027Invalid volume size provided for create request\u0027)),"},{"line_number":28,"context_line":"        (\u00270\u0027, (r\u0027Invalid input received\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_189e68b8","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"updated":"2016-07-14 11:19:44.000000000","message":"also good to add some floating point type value","commit_id":"ff749f8c415b91abbf0a523ac2ae02cab890d918"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"ec85b02b5b2e0bc1a45693fe2995b5e1116876df","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class CinderVolumeNegativeTests(base.ClientTestBase):"},{"line_number":23,"context_line":"    \"\"\"Check of cinder volume create commands.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @ddt.data("},{"line_number":26,"context_line":"        (\u0027\u0027, (r\u0027Size is a required parameter\u0027)),"},{"line_number":27,"context_line":"        (\u0027-1\u0027, (r\u0027Invalid volume size provided for create request\u0027)),"},{"line_number":28,"context_line":"        (\u00270\u0027, (r\u0027Invalid input received\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_de5c9af2","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"1aa78d24_189e68b8","updated":"2016-07-15 07:44:20.000000000","message":"Add new patch:\nhttps://review.openstack.org/#/c/342652/","commit_id":"ff749f8c415b91abbf0a523ac2ae02cab890d918"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"94bf5945cdf2cba24ae8214ea481e7820deef92b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class CinderVolumeNegativeTests(base.ClientTestBase):"},{"line_number":23,"context_line":"    \"\"\"Check of cinder volume create commands.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @ddt.data("},{"line_number":26,"context_line":"        (\u0027\u0027, (r\u0027Size is a required parameter\u0027)),"},{"line_number":27,"context_line":"        (\u0027-1\u0027, (r\u0027Invalid volume size provided for create request\u0027)),"},{"line_number":28,"context_line":"        (\u00270\u0027, (r\u0027Invalid input received\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_2cf2ef06","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"1aa78d24_189e68b8","updated":"2016-07-14 20:08:08.000000000","message":"Yes, Might as well test floating point.","commit_id":"ff749f8c415b91abbf0a523ac2ae02cab890d918"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"ec85b02b5b2e0bc1a45693fe2995b5e1116876df","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class CinderVolumeNegativeTests(base.ClientTestBase):"},{"line_number":23,"context_line":"    \"\"\"Check of cinder volume create commands.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @ddt.data("},{"line_number":26,"context_line":"        (\u0027\u0027, (r\u0027Size is a required parameter\u0027)),"},{"line_number":27,"context_line":"        (\u0027-1\u0027, (r\u0027Invalid volume size provided for create request\u0027)),"},{"line_number":28,"context_line":"        (\u00270\u0027, (r\u0027Invalid input received\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_7e4f6634","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"1aa78d24_2cf2ef06","updated":"2016-07-15 07:44:20.000000000","message":"Add new patch:\nhttps://review.openstack.org/#/c/342652/","commit_id":"ff749f8c415b91abbf0a523ac2ae02cab890d918"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"dadb40e4ef02a9d88ec68a183c2183b5d2bb8c77","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class CinderVolumeNegativeTests(base.ClientTestBase):"},{"line_number":23,"context_line":"    \"\"\"Check of cinder volume create commands.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @ddt.data("},{"line_number":26,"context_line":"        (\u0027\u0027, (r\u0027Size is a required parameter\u0027)),"},{"line_number":27,"context_line":"        (\u0027-1\u0027, (r\u0027Invalid volume size provided for create request\u0027)),"},{"line_number":28,"context_line":"        (\u00270\u0027, (r\u0027Invalid input received\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_b6460a79","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"1aa78d24_34833fab","updated":"2016-07-15 12:40:18.000000000","message":"Done","commit_id":"ff749f8c415b91abbf0a523ac2ae02cab890d918"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9faba7c11a604e196e95438ba1b155b8fa23b9d3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class CinderVolumeNegativeTests(base.ClientTestBase):"},{"line_number":23,"context_line":"    \"\"\"Check of cinder volume create commands.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @ddt.data("},{"line_number":26,"context_line":"        (\u0027\u0027, (r\u0027Size is a required parameter\u0027)),"},{"line_number":27,"context_line":"        (\u0027-1\u0027, (r\u0027Invalid volume size provided for create request\u0027)),"},{"line_number":28,"context_line":"        (\u00270\u0027, (r\u0027Invalid input received\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_34833fab","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"1aa78d24_de5c9af2","updated":"2016-07-15 08:51:46.000000000","message":"Sergiy, please, merge these patches into the one","commit_id":"ff749f8c415b91abbf0a523ac2ae02cab890d918"}]}
