)]}'
{"id":"openstack%2Fpython-cinderclient~351767","triplet_id":"openstack%2Fpython-cinderclient~master~I7497c5dc940c1e726507117cadbad232d8c1d80d","project":"openstack/python-cinderclient","branch":"master","topic":"improve_api_version","hashtags":[],"change_id":"I7497c5dc940c1e726507117cadbad232d8c1d80d","subject":"Make APIVersion\u0027s null check more pythonic","status":"MERGED","created":"2016-08-05 14:20:25.000000000","updated":"2016-08-30 14:24:35.000000000","submitted":"2016-08-30 14:24:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"64e9cd750330fd7302de9a81d81558647d081c64","_number":351767,"virtual_id_number":351767,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":2,"date":"2016-08-30 14:24:35.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"all":[{"value":2,"date":"2016-08-29 12:26:30.000000000","_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2016-08-29 12:31:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-30 13:11:55.000000000","_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"all":[{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-08-30 13:11:58.000000000","_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-28 18:19:02.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2016-08-29 12:26:30.000000000","updated_by":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"reviewer":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"state":"REVIEWER"},{"updated":"2016-08-29 12:31:42.000000000","updated_by":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"reviewer":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"state":"REVIEWER"},{"updated":"2016-08-30 13:11:58.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2016-08-30 14:24:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"79183330ba6604c1d92553054ce172c293cf425e","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2016-08-05 14:20:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e00d18de0861c5648708cc31dad9c9bf8871ac1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-05 16:18:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/67/351767/1/check/gate-python-cinderclient-docs-ubuntu-xenial/cd4d8b6//doc/build/html/ : SUCCESS in 4m 08s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/67/351767/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/358a2b1/ : SUCCESS in 4m 39s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/67/351767/1/check/gate-python-cinderclient-python27-ubuntu-xenial/e87c518/ : SUCCESS in 3m 52s\n- gate-python-cinderclient-python34 http://logs.openstack.org/67/351767/1/check/gate-python-cinderclient-python34/8cbd7f8/ : SUCCESS in 3m 47s\n- gate-python-cinderclient-python35-nv http://logs.openstack.org/67/351767/1/check/gate-python-cinderclient-python35-nv/39f3967/ : SUCCESS in 6m 54s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/67/351767/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/84130d3/ : SUCCESS in 1h 27m 17s\n- gate-python-cinderclient-pypy http://logs.openstack.org/67/351767/1/check/gate-python-cinderclient-pypy/916d0bb/ : SUCCESS in 4m 52s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/67/351767/1/check/gate-cinderclient-dsvm-functional/40040e7/ : SUCCESS in 33m 04s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/67/351767/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/dd9fa9f/ : SUCCESS in 32m 27s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/67/351767/1/check/gate-python-cinderclient-pylint/f1a7988/ : SUCCESS in 3m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"25afee77f0cc4513a4fef2a91612cc7c97e586af","author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"date":"2016-08-10 14:24:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6e37e4bd012b8a20f32aeb935df60684c4fee04b","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2016-08-15 22:51:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"da83ef0b95fbf492ac22b8ebff94c53b68604e7b","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-08-28 18:19:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6ed5d4346b4b5533ed45805ad0225dcf5eb95e38","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-28 18:19:13.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4a7a673ee1ba0b9f8c55b06fc49f79082d37c8c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-28 19:28:07.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/67/351767/1/gate/gate-python-cinderclient-docs-ubuntu-xenial/7dea4e2//doc/build/html/ : SUCCESS in 3m 52s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/67/351767/1/gate/gate-python-cinderclient-pep8-ubuntu-xenial/eafc0e2/ : SUCCESS in 4m 22s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/67/351767/1/gate/gate-python-cinderclient-python27-ubuntu-xenial/040db77/ : FAILURE in 2m 28s\n- gate-python-cinderclient-python34 http://logs.openstack.org/67/351767/1/gate/gate-python-cinderclient-python34/9160d65/ : FAILURE in 3m 31s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/67/351767/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/5de4447/ : SUCCESS in 1h 08m 51s","accounts_in_message":[],"_revision_number":1},{"id":"1b0d467c293b511c3b4be57fd60d50e5f8518eeb","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2016-08-29 09:42:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8657c2743862b56854c8684cbcc9ec9705370293","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2016-08-29 09:43:16.000000000","message":"Patch Set 2:\n\nNew merged code introduced some code that was using is_null method that was being removed by this patch, so a new patch set was required.","accounts_in_message":[],"_revision_number":2},{"id":"d20cde7a6ab1fcab30968ef981fc17dea4cba1cd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 10:43:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/67/351767/2/check/gate-python-cinderclient-docs-ubuntu-xenial/ed9dd8b//doc/build/html/ : SUCCESS in 3m 46s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/67/351767/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/2375b39/ : SUCCESS in 3m 26s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/67/351767/2/check/gate-python-cinderclient-python27-ubuntu-xenial/6cb7005/ : SUCCESS in 2m 41s\n- gate-python-cinderclient-python34 http://logs.openstack.org/67/351767/2/check/gate-python-cinderclient-python34/5c39b20/ : SUCCESS in 3m 00s\n- gate-python-cinderclient-python35-nv http://logs.openstack.org/67/351767/2/check/gate-python-cinderclient-python35-nv/afc5bbe/ : SUCCESS in 2m 50s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/67/351767/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/ad6867f/ : SUCCESS in 59m 11s\n- gate-python-cinderclient-pypy http://logs.openstack.org/67/351767/2/check/gate-python-cinderclient-pypy/626a584/ : SUCCESS in 2m 50s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/67/351767/2/check/gate-cinderclient-dsvm-functional/82f85dc/ : SUCCESS in 37m 19s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/67/351767/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/bf5129f/ : SUCCESS in 13m 02s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/67/351767/2/check/gate-python-cinderclient-pylint/f2af112/ : SUCCESS in 3m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"065a16069eb9076153c6c723d674262ff723d411","author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"date":"2016-08-29 12:26:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"447586bb2e5254d95a31a609bddf8a130575eb9d","author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"date":"2016-08-29 12:31:42.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"05fcf850cf3eac01bde4ed9782b7fea4ad5d7988","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2016-08-30 13:11:55.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d2384e1f653cea64af7e3b7c5ea06ae5c26d7ef3","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2016-08-30 13:11:58.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7773f5501f19b9474c2eb7a454e0044a381af645","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-30 13:15:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"079354d7f5d5bd645c2c6ae31c9ba97ba40ed31d","date":"2016-08-30 14:24:35.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"ebcf284d8de19ecef03739bb2b504e39ff5653b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-30 14:24:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/67/351767/2/gate/gate-python-cinderclient-docs-ubuntu-xenial/e331058//doc/build/html/ : SUCCESS in 2m 35s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/67/351767/2/gate/gate-python-cinderclient-pep8-ubuntu-xenial/0b859fb/ : SUCCESS in 3m 04s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/67/351767/2/gate/gate-python-cinderclient-python27-ubuntu-xenial/80883fb/ : SUCCESS in 2m 43s\n- gate-python-cinderclient-python34 http://logs.openstack.org/67/351767/2/gate/gate-python-cinderclient-python34/38be91f/ : SUCCESS in 2m 53s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/67/351767/2/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/6b1821e/ : SUCCESS in 1h 05m 24s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8b5a772e36fb7b7fae42a956bc844e792bec2035","revisions":{"cf512e202439f0b94c8e333ba495416110408805":{"kind":"REWORK","_number":1,"created":"2016-08-05 14:20:25.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/67/351767/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/67/351767/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/351767/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/351767/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/351767/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/67/351767/1"}}},"commit":{"parents":[{"commit":"cb24088fea21049d9b0b039d5a6d695db310bcdb","subject":"Merge \"Changed backup-restore to accept backup name\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cb24088fea21049d9b0b039d5a6d695db310bcdb"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2016-08-05 12:45:28.000000000","tz":120},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2016-08-05 14:10:18.000000000","tz":120},"subject":"Make APIVersion\u0027s null check more pythonic","message":"Make APIVersion\u0027s null check more pythonic\n\nOur current APIVersion object has an is_null method to check when the\nversion instance is null (major\u003d0 and minor\u003d0).\n\nWhile this works it is not very pythonic, since you have to write\nexpressions such as:\n\n if not min_version and not max_version:\n     return True\n elif ((min_version and max_version) and\n       max_version.is_null() and min_version.is_null()):\n     return True\n\nThis patch removes the is_null method and instead implements the truth\nvalue testing to simplify expressions and make code more pythonic.\n\nSo previous code would just look like:\n\n if not min_version and not max_version:\n     return True\n\nBecause this will work with min_version being None or being an\nAPIVersion instance with major\u003d0 and minor\u003d0.\n\nChange-Id: I7497c5dc940c1e726507117cadbad232d8c1d80d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cf512e202439f0b94c8e333ba495416110408805"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cf512e202439f0b94c8e333ba495416110408805"}]},"branch":"refs/heads/master"},"8b5a772e36fb7b7fae42a956bc844e792bec2035":{"kind":"REWORK","_number":2,"created":"2016-08-29 09:42:05.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/67/351767/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/67/351767/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/351767/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/351767/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/351767/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/67/351767/2"}}},"commit":{"parents":[{"commit":"8db4ca1d90c714c49a88a05e9cc008b3bd9f2245","subject":"Merge \"Update the home-page with developer documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8db4ca1d90c714c49a88a05e9cc008b3bd9f2245"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2016-08-05 12:45:28.000000000","tz":120},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2016-08-29 09:41:57.000000000","tz":120},"subject":"Make APIVersion\u0027s null check more pythonic","message":"Make APIVersion\u0027s null check more pythonic\n\nOur current APIVersion object has an is_null method to check when the\nversion instance is null (major\u003d0 and minor\u003d0).\n\nWhile this works it is not very pythonic, since you have to write\nexpressions such as:\n\n if not min_version and not max_version:\n     return True\n elif ((min_version and max_version) and\n       max_version.is_null() and min_version.is_null()):\n     return True\n\nThis patch removes the is_null method and instead implements the truth\nvalue testing to simplify expressions and make code more pythonic.\n\nSo previous code would just look like:\n\n if not min_version and not max_version:\n     return True\n\nBecause this will work with min_version being None or being an\nAPIVersion instance with major\u003d0 and minor\u003d0.\n\nChange-Id: I7497c5dc940c1e726507117cadbad232d8c1d80d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8b5a772e36fb7b7fae42a956bc844e792bec2035"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8b5a772e36fb7b7fae42a956bc844e792bec2035"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
