)]}'
{"id":"openstack%2Fpython-cinderclient~373636","triplet_id":"openstack%2Fpython-cinderclient~master~Ic3b218eecb5738769dd2c18b6029dc70210d3989","project":"openstack/python-cinderclient","branch":"master","topic":"magic","hashtags":[],"change_id":"Ic3b218eecb5738769dd2c18b6029dc70210d3989","subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","status":"MERGED","created":"2016-09-21 04:18:32.000000000","updated":"2016-10-05 23:35:34.000000000","submitted":"2016-10-05 23:35:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d9e8b5ab1f5f03e16ac757f4e6757250c6457783","_number":373636,"virtual_id_number":373636,"owner":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-10-05 23:35:34.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-10-05 14:13:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":2,"date":"2016-10-05 21:25:36.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":1,"date":"2016-10-05 21:25:36.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-05 14:13:04.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2016-10-05 21:25:36.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2016-10-05 23:35:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5b5cecffb481f4f01043a600dddd3a079a37f77c","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-09-21 04:18:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fece961bf37257f56d4cb5209ec51e2165b6d4e6","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-09-21 04:19:28.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"08110c97d123b10136ee672f621d170ea15b7105","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-09-21 04:51:27.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"df7ac3054cf8e13828fd3ee0f8c86adf9cebf79e","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-09-21 05:02:29.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0a2da3adfdfe643b392b9e0c476c3294a3696d7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 06:16:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/36/373636/2/check/gate-python-cinderclient-docs-ubuntu-xenial/b17c0f1//doc/build/html/ : SUCCESS in 3m 05s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/36/373636/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/b0fc0da/ : SUCCESS in 2m 33s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/36/373636/2/check/gate-python-cinderclient-python27-ubuntu-xenial/d260f13/ : SUCCESS in 3m 03s\n- gate-python-cinderclient-python34 http://logs.openstack.org/36/373636/2/check/gate-python-cinderclient-python34/d099bcb/ : SUCCESS in 2m 21s\n- gate-python-cinderclient-python35-nv http://logs.openstack.org/36/373636/2/check/gate-python-cinderclient-python35-nv/0f9e54c/ : SUCCESS in 2m 54s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/36/373636/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/1581c9b/ : SUCCESS in 1h 14m 04s\n- gate-python-cinderclient-pypy http://logs.openstack.org/36/373636/2/check/gate-python-cinderclient-pypy/68e37b2/ : SUCCESS in 4m 29s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/36/373636/2/check/gate-cinderclient-dsvm-functional/cf46f27/ : SUCCESS in 14m 03s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/36/373636/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/3323d84/ : SUCCESS in 12m 56s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/36/373636/2/check/gate-python-cinderclient-pylint/7ae3c41/ : SUCCESS in 2m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"bc31cc57f64d9756f86a4d4ae19f39813e24e959","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-09-30 09:28:48.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"b60049e92cd89c82c6fa7d425084d43bcc7517a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-30 10:19:36.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/36/373636/3/check/gate-python-cinderclient-docs-ubuntu-xenial/dc01bbc//doc/build/html/ : SUCCESS in 3m 14s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/36/373636/3/check/gate-python-cinderclient-pep8-ubuntu-xenial/b252676/ : SUCCESS in 3m 14s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/36/373636/3/check/gate-python-cinderclient-python27-ubuntu-xenial/8e2b5b3/ : SUCCESS in 5m 16s\n- gate-python-cinderclient-python34 http://logs.openstack.org/36/373636/3/check/gate-python-cinderclient-python34/e2d2a3c/ : SUCCESS in 3m 36s\n- gate-python-cinderclient-python35-nv http://logs.openstack.org/36/373636/3/check/gate-python-cinderclient-python35-nv/dcf7ee4/ : SUCCESS in 3m 54s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/36/373636/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient/aa5b781/ : SUCCESS in 43m 38s\n- gate-python-cinderclient-pypy http://logs.openstack.org/36/373636/3/check/gate-python-cinderclient-pypy/9a6b690/ : SUCCESS in 4m 28s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/36/373636/3/check/gate-cinderclient-dsvm-functional/e905620/ : SUCCESS in 13m 30s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/36/373636/3/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/57805dc/ : SUCCESS in 18m 38s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/36/373636/3/check/gate-python-cinderclient-pylint/6f5048d/ : SUCCESS in 2m 18s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6c91d6b95b790f1724f476f85b0843c452531c6f","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2016-10-05 14:13:04.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"efbcb6ad51de5343e6c8c45c03cbeb51b7056e5c","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2016-10-05 21:25:36.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"6b1ba8aaa372f3f6c0b56306a414ab8d9fe2f855","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 21:25:46.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"0572a0d19c2286a37e4728f05f0a286380427452","date":"2016-10-05 23:35:34.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"bfa373e31e8df24925ecb212dc4568e9a70b1173","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 23:35:34.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/36/373636/3/gate/gate-python-cinderclient-docs-ubuntu-xenial/ce80f19//doc/build/html/ : SUCCESS in 2m 20s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/36/373636/3/gate/gate-python-cinderclient-pep8-ubuntu-xenial/239e544/ : SUCCESS in 2m 22s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/36/373636/3/gate/gate-python-cinderclient-python27-ubuntu-xenial/a424316/ : SUCCESS in 2m 29s\n- gate-python-cinderclient-python34 http://logs.openstack.org/36/373636/3/gate/gate-python-cinderclient-python34/4ab1330/ : SUCCESS in 2m 32s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/36/373636/3/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/09db9ad/ : SUCCESS in 42m 06s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"cc736ad6265ec8534ea6393270361aae2bc1f153","revisions":{"32fdb0a61b8535d5a096e8f31fd0da1759a312bb":{"kind":"REWORK","_number":1,"created":"2016-09-21 04:18:32.000000000","uploader":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"ref":"refs/changes/36/373636/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/36/373636/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/1"}}},"commit":{"parents":[{"commit":"e15d8e7f0920cb7cd5719d2861dea886bd6f9cb0","subject":"Deleting volume metadata keys with a single request","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e15d8e7f0920cb7cd5719d2861dea886bd6f9cb0"}]}],"author":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-09-21 04:13:22.000000000","tz":480},"committer":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-09-21 04:13:22.000000000","tz":480},"subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","message":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027\n\nThey magically allow things to pass.Any usage should be replaced with the\nMock class and explicit attributes should be set on it.\n\nChange-Id: Ic3b218eecb5738769dd2c18b6029dc70210d3989\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/32fdb0a61b8535d5a096e8f31fd0da1759a312bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/32fdb0a61b8535d5a096e8f31fd0da1759a312bb"}]},"branch":"refs/heads/master"},"30a1f27b8c796bb2b78d4be3ca71d0b1a83bd940":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-09-21 05:02:29.000000000","uploader":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"ref":"refs/changes/36/373636/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/36/373636/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/2"}}},"commit":{"parents":[{"commit":"e15d8e7f0920cb7cd5719d2861dea886bd6f9cb0","subject":"Deleting volume metadata keys with a single request","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e15d8e7f0920cb7cd5719d2861dea886bd6f9cb0"}]}],"author":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-09-21 04:13:22.000000000","tz":480},"committer":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-09-21 04:58:44.000000000","tz":480},"subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","message":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027\n\nIn magicmock,there just have a mock_add_spec function,in this code,there have\nnot called this method so i think it can be removed and call mock directly.\n\nChange-Id: Ic3b218eecb5738769dd2c18b6029dc70210d3989\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/30a1f27b8c796bb2b78d4be3ca71d0b1a83bd940"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/30a1f27b8c796bb2b78d4be3ca71d0b1a83bd940"}]},"branch":"refs/heads/master"},"cc736ad6265ec8534ea6393270361aae2bc1f153":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-09-30 09:28:48.000000000","uploader":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"ref":"refs/changes/36/373636/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/36/373636/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/36/373636/3"}}},"commit":{"parents":[{"commit":"0834b2b58bd566a8acaa40b4235bcf38be00b725","subject":"Merge \"Import module instead of object\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0834b2b58bd566a8acaa40b4235bcf38be00b725"}]}],"author":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-09-21 04:13:22.000000000","tz":480},"committer":{"name":"xianming.mao","email":"xianming.mao@easystack.cn","date":"2016-09-30 09:28:48.000000000","tz":0},"subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","message":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027\n\nIn magicmock,there just have a mock_add_spec function,in this code,there have\nnot called this method so i think it can be removed and call mock directly.\n\nChange-Id: Ic3b218eecb5738769dd2c18b6029dc70210d3989\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cc736ad6265ec8534ea6393270361aae2bc1f153"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/cc736ad6265ec8534ea6393270361aae2bc1f153"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}