)]}'
{"id":"openstack%2Fpython-cinderclient~379255","triplet_id":"openstack%2Fpython-cinderclient~master~I3a3ae90cc6011d1aa0cc39db4329d9bc08801904","project":"openstack/python-cinderclient","branch":"master","topic":"opt/build-query-param","hashtags":[],"change_id":"I3a3ae90cc6011d1aa0cc39db4329d9bc08801904","subject":"Optimize: add build_query_param method to clean code","status":"MERGED","created":"2016-09-29 08:07:48.000000000","updated":"2016-11-07 15:41:00.000000000","submitted":"2016-11-07 15:41:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5a6d303ded5ffaa0d1e71ef93811ca489ab6f108","_number":379255,"virtual_id_number":379255,"owner":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":2,"date":"2016-11-07 15:40:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2016-11-07 14:44:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2016-11-07 12:44:20.000000000","_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":1,"date":"2016-11-07 12:38:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2016-11-07 14:44:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-06 09:57:03.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2016-11-07 12:38:00.000000000","updated_by":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"reviewer":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"state":"REVIEWER"},{"updated":"2016-11-07 12:44:20.000000000","updated_by":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"reviewer":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"state":"REVIEWER"},{"updated":"2016-11-07 14:44:24.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2016-11-07 15:40:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"545527687086e49faeaa116f703945f125495afb","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2016-09-29 08:07:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"398fbbf6886ac1cc775d616b041a35d5fb059853","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-29 09:10:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/55/379255/1/check/gate-python-cinderclient-docs-ubuntu-xenial/6c19914//doc/build/html/ : SUCCESS in 2m 49s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/55/379255/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/fe13be8/ : SUCCESS in 2m 28s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/55/379255/1/check/gate-python-cinderclient-python27-ubuntu-xenial/4418bae/ : SUCCESS in 2m 33s\n- gate-python-cinderclient-python34 http://logs.openstack.org/55/379255/1/check/gate-python-cinderclient-python34/75a98e6/ : SUCCESS in 2m 34s\n- gate-python-cinderclient-python35-nv http://logs.openstack.org/55/379255/1/check/gate-python-cinderclient-python35-nv/9c2e894/ : SUCCESS in 4m 03s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/55/379255/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/2859c51/ : SUCCESS in 1h 02m 33s\n- gate-python-cinderclient-pypy http://logs.openstack.org/55/379255/1/check/gate-python-cinderclient-pypy/db95c94/ : SUCCESS in 2m 47s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/55/379255/1/check/gate-cinderclient-dsvm-functional/486f8da/ : FAILURE in 13m 49s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/55/379255/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/317502e/ : SUCCESS in 13m 31s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/55/379255/1/check/gate-python-cinderclient-pylint/e374949/ : SUCCESS in 2m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"786aa19692373f56d5f0c249dfe94556db0a1d5a","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2016-10-10 10:29:23.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nComment inline.\n\nAlso, since the code:\n    if search_opts is None:\n        search_opts \u003d {}\nis common to every case, couldn\u0027t this be pulled into the utility function too?","accounts_in_message":[],"_revision_number":1},{"id":"ee533c851a76e97d43f4e66faf2636fac614676f","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2016-10-10 11:06:03.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e Comment inline.\n \u003e \n \u003e Also, since the code:\n \u003e if search_opts is None:\n \u003e search_opts \u003d {}\n \u003e is common to every case, couldn\u0027t this be pulled into the utility\n \u003e function too?\n\nhey @DucanT,please take a look at this [1](line 202) there is a case that search_opts is handled before the util\u0027s operation,so maybe it\u0027s better to do this check outside, and the difference between the two way isn\u0027t that much,so I would like to revert the change if you insist\n\n[1] https://review.openstack.org/#/c/379255/1/cinderclient/v1/volumes.py","accounts_in_message":[],"_revision_number":1},{"id":"d0bede32e0742dc0bbb8043f3db289b49af7fc32","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2016-10-19 04:32:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d2af35e3afa749643e6bc72e1bd3554aa6ee5524","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-19 05:13:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/55/379255/2/check/gate-python-cinderclient-docs-ubuntu-xenial/976efe2//doc/build/html/ : SUCCESS in 3m 12s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/55/379255/2/check/gate-python-cinderclient-pep8-ubuntu-xenial/f20e736/ : SUCCESS in 3m 19s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/55/379255/2/check/gate-python-cinderclient-python27-ubuntu-xenial/6bf5fb3/ : SUCCESS in 3m 44s\n- gate-python-cinderclient-python34 http://logs.openstack.org/55/379255/2/check/gate-python-cinderclient-python34/a05583b/ : SUCCESS in 5m 10s\n- gate-python-cinderclient-python35-nv http://logs.openstack.org/55/379255/2/check/gate-python-cinderclient-python35-nv/7302c40/ : SUCCESS in 3m 27s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/55/379255/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/18b4869/ : SUCCESS in 40m 50s\n- gate-python-cinderclient-pypy http://logs.openstack.org/55/379255/2/check/gate-python-cinderclient-pypy/7892a40/ : SUCCESS in 4m 11s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/55/379255/2/check/gate-cinderclient-dsvm-functional/34c99b8/ : SUCCESS in 20m 35s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/55/379255/2/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/fb57d88/ : SUCCESS in 13m 28s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/55/379255/2/check/gate-python-cinderclient-pylint/310b09b/ : SUCCESS in 4m 31s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ae01ed1c2ac3251b7f73078132db6e64d506c39c","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2016-10-19 07:12:01.000000000","message":"Patch Set 2:\n\n@Duncan Thomas hey,\nplease check the latest PS, I had moved the None check sentence into the util methond, thanks~","accounts_in_message":[],"_revision_number":2},{"id":"4f62f42d56a904897b920bbc8eaafb1349bae19d","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-10-26 07:19:20.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"61ffd223660ac3683ac3e6e90468a0e223a85df3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-04 15:11:19.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"817bc411fc2ffc009ecb6b215ffe61dae5094e45","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2016-11-06 09:57:03.000000000","message":"Patch Set 2: Code-Review+2\n\nNeeds rebasing, but otherwise looks good to me","accounts_in_message":[],"_revision_number":2},{"id":"bb724dc46969f6e8217b67a8af8621a0e0219ac1","author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"date":"2016-11-07 01:27:55.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0b3838ea1db25adee470e71c1df0c61177d8416e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-07 02:11:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/55/379255/3/check/gate-python-cinderclient-docs-ubuntu-xenial/f5dcdb6//doc/build/html/ : SUCCESS in 1m 54s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/55/379255/3/check/gate-python-cinderclient-pep8-ubuntu-xenial/89af13e/ : SUCCESS in 2m 42s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/55/379255/3/check/gate-python-cinderclient-python27-ubuntu-xenial/d244d74/ : SUCCESS in 2m 05s\n- gate-python-cinderclient-python34 http://logs.openstack.org/55/379255/3/check/gate-python-cinderclient-python34/6ca01e9/ : SUCCESS in 2m 13s\n- gate-python-cinderclient-python35-nv http://logs.openstack.org/55/379255/3/check/gate-python-cinderclient-python35-nv/ec6e6e6/ : SUCCESS in 2m 11s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/55/379255/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient/f48ba44/ : SUCCESS in 43m 28s\n- gate-python-cinderclient-pypy http://logs.openstack.org/55/379255/3/check/gate-python-cinderclient-pypy/e58521f/ : SUCCESS in 2m 19s (non-voting)\n- gate-cinderclient-dsvm-functional http://logs.openstack.org/55/379255/3/check/gate-cinderclient-dsvm-functional/6ec50f2/ : FAILURE in 14m 55s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/55/379255/3/check/gate-cinderclient-dsvm-functional-identity-v3-only-nv/377c65d/ : FAILURE in 14m 43s (non-voting)\n- gate-python-cinderclient-pylint http://logs.openstack.org/55/379255/3/check/gate-python-cinderclient-pylint/c0727c8/ : SUCCESS in 1m 46s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"e0c6a059e1bcc993bece23a60dee45c5c339032b","author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"date":"2016-11-07 12:38:00.000000000","message":"Patch Set 3: Code-Review+1\n\nIt looks nice","accounts_in_message":[],"_revision_number":3},{"id":"a78c6891c5f0d4335e2c16865b7ac0d3fc110ca7","author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"date":"2016-11-07 12:44:20.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"99e39e6b873fad7dd46c4e07832c804d69335434","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-11-07 14:44:24.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"2f7d5c048a9a2a49b18b47cdf4daf99c15f50df8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-07 14:44:34.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"a531429a4867744872a5ce242762ae3006b1ea64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-07 15:40:59.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/55/379255/3/gate/gate-python-cinderclient-docs-ubuntu-xenial/0da540f//doc/build/html/ : SUCCESS in 2m 08s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/55/379255/3/gate/gate-python-cinderclient-pep8-ubuntu-xenial/20eec52/ : SUCCESS in 2m 11s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/55/379255/3/gate/gate-python-cinderclient-python27-ubuntu-xenial/2456dd3/ : SUCCESS in 2m 39s\n- gate-python-cinderclient-python34 http://logs.openstack.org/55/379255/3/gate/gate-python-cinderclient-python34/434d8b6/ : SUCCESS in 2m 18s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/55/379255/3/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/a55e35a/ : SUCCESS in 56m 22s","accounts_in_message":[],"_revision_number":3},{"id":"f122c2bb88e495bea7fab87b8754aefc4bcb5499","date":"2016-11-07 15:41:00.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d8ca399aba604c2fb518eabaadf846433700eb30","revisions":{"bf1c2e104414bab4572e4d96bf55c09976f4ef4f":{"kind":"REWORK","_number":1,"created":"2016-09-29 08:07:48.000000000","uploader":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"ref":"refs/changes/55/379255/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/55/379255/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/1"}}},"commit":{"parents":[{"commit":"8221a2ee946c4bb1699d0cd03e5010ad510e4a15","subject":"Merge \"AttributeError when print service object\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8221a2ee946c4bb1699d0cd03e5010ad510e4a15"}]}],"author":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2016-09-29 08:00:10.000000000","tz":480},"committer":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2016-09-29 08:07:40.000000000","tz":480},"subject":"Optimize: add build_query_param method to clean code","message":"Optimize: add build_query_param method to clean code\n\nCurrently the client build query params in respective method\nthis patch intends to use \u0027utils.build_query_param\u0027 to make\nthe code clean.\n\nChange-Id: I3a3ae90cc6011d1aa0cc39db4329d9bc08801904\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/bf1c2e104414bab4572e4d96bf55c09976f4ef4f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/bf1c2e104414bab4572e4d96bf55c09976f4ef4f"}]},"branch":"refs/heads/master"},"15690dfa3a0332f916d8d60b8fcc29fd94a1492a":{"kind":"REWORK","_number":2,"created":"2016-10-19 04:32:57.000000000","uploader":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"ref":"refs/changes/55/379255/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/55/379255/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/2"}}},"commit":{"parents":[{"commit":"8221a2ee946c4bb1699d0cd03e5010ad510e4a15","subject":"Merge \"AttributeError when print service object\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8221a2ee946c4bb1699d0cd03e5010ad510e4a15"}]}],"author":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2016-09-29 08:00:10.000000000","tz":480},"committer":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2016-10-19 04:32:01.000000000","tz":480},"subject":"Optimize: add build_query_param method to clean code","message":"Optimize: add build_query_param method to clean code\n\nCurrently the client build query params in respective method\nthis patch intends to use \u0027utils.build_query_param\u0027 to make\nthe code clean.\n\nChange-Id: I3a3ae90cc6011d1aa0cc39db4329d9bc08801904\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/15690dfa3a0332f916d8d60b8fcc29fd94a1492a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/15690dfa3a0332f916d8d60b8fcc29fd94a1492a"}]},"branch":"refs/heads/master"},"d8ca399aba604c2fb518eabaadf846433700eb30":{"kind":"REWORK","_number":3,"created":"2016-11-07 01:27:55.000000000","uploader":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"ref":"refs/changes/55/379255/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/55/379255/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/55/379255/3"}}},"commit":{"parents":[{"commit":"a01a3e1b7f6dd0919ffa15a4d54b84f0ac1e7915","subject":"Move old oslo-incubator code out of openstack/common","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a01a3e1b7f6dd0919ffa15a4d54b84f0ac1e7915"}]}],"author":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2016-09-29 08:00:10.000000000","tz":480},"committer":{"name":"TommyLike","email":"tommylikehu@gmail.com","date":"2016-11-07 01:26:52.000000000","tz":480},"subject":"Optimize: add build_query_param method to clean code","message":"Optimize: add build_query_param method to clean code\n\nCurrently the client build query params in respective method\nthis patch intends to use \u0027utils.build_query_param\u0027 to make\nthe code clean.\n\nChange-Id: I3a3ae90cc6011d1aa0cc39db4329d9bc08801904\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d8ca399aba604c2fb518eabaadf846433700eb30"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d8ca399aba604c2fb518eabaadf846433700eb30"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
