)]}'
{"cinderclient/shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5225058c17b2e419c150a4d1b6316f15cbda4b30","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        streamhandler \u003d logging.StreamHandler()"},{"line_number":530,"context_line":"        streamformat \u003d \"%(levelname)s (%(module)s:%(lineno)d) %(message)s\""},{"line_number":531,"context_line":"        streamhandler.setFormatter(logging.Formatter(streamformat))"},{"line_number":532,"context_line":"        logger.setLevel(logging.WARNING)"},{"line_number":533,"context_line":"        logger.addHandler(streamhandler)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        self.client_logger \u003d logging.getLogger(client.__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c849a2d2","line":532,"range":{"start_line":532,"start_character":24,"end_line":532,"end_character":39},"updated":"2016-10-11 10:39:10.000000000","message":"-1: The problem why we are not seeing the traceback is here, we are not properly setting the logging level, this should be:\n\n logger.setLevel(logging.DEBUG if debug else logging.WARNING)","commit_id":"1c3622f7bccd4cbf558d54500d8026936a45194a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fc4afc41d5e82f923ab9c4ca07d4771e890e4b3","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        streamhandler \u003d logging.StreamHandler()"},{"line_number":530,"context_line":"        streamformat \u003d \"%(levelname)s (%(module)s:%(lineno)d) %(message)s\""},{"line_number":531,"context_line":"        streamhandler.setFormatter(logging.Formatter(streamformat))"},{"line_number":532,"context_line":"        logger.setLevel(logging.WARNING)"},{"line_number":533,"context_line":"        logger.addHandler(streamhandler)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        self.client_logger \u003d logging.getLogger(client.__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d36ce79e","line":532,"range":{"start_line":532,"start_character":24,"end_line":532,"end_character":39},"in_reply_to":"fa6399be_c849a2d2","updated":"2016-10-11 15:17:48.000000000","message":"This is also a lot better because it works with --debug.  :)\n\nDone.","commit_id":"1c3622f7bccd4cbf558d54500d8026936a45194a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cf8cd897800d2acaf82c4a1973c63c99ed45c576","unresolved":false,"context_lines":[{"line_number":961,"context_line":"            try:"},{"line_number":962,"context_line":"                import traceback"},{"line_number":963,"context_line":"                traceback.print_exc()"},{"line_number":964,"context_line":"            except ImportError:"},{"line_number":965,"context_line":"                pass"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        logger.debug(e, exc_info\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_b4229150","line":964,"updated":"2016-10-06 21:05:26.000000000","message":"traceback is built into the standard python lib, so the ImportError handling is probably unnecessary.","commit_id":"1c3622f7bccd4cbf558d54500d8026936a45194a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5225058c17b2e419c150a4d1b6316f15cbda4b30","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            except ImportError:"},{"line_number":965,"context_line":"                pass"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        logger.debug(e, exc_info\u003d1)"},{"line_number":968,"context_line":"        print(\"ERROR: %s\" % six.text_type(e), file\u003dsys.stderr)"},{"line_number":969,"context_line":"        sys.exit(1)"},{"line_number":970,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_28177ea4","line":967,"updated":"2016-10-11 10:39:10.000000000","message":"We are already logging the exception here, so there\u0027s no need to use the traceback library.","commit_id":"1c3622f7bccd4cbf558d54500d8026936a45194a"}]}
