)]}'
{"cinderclient/api_versions.py":[{"author":{"_account_id":22227,"name":"Justin A Wilson","email":"justin.wilson@intel.com","username":"waj334"},"change_message_id":"cb1f8bb2970f5548f0f313aaa25ca83dd6a4ea35","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    valid_version \u003d requested_version"},{"line_number":290,"context_line":"    if not requested_version.matches(server_start_version, server_end_version):"},{"line_number":291,"context_line":"        if server_end_version \u003c\u003d requested_version:"},{"line_number":292,"context_line":"            if (MIN_VERSION \u003c\u003d server_end_version and"},{"line_number":293,"context_line":"                    server_end_version \u003c\u003d MAX_VERSION):"},{"line_number":294,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":295,"context_line":"                        \"not supported. Downgrading requested version \""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_84ec9990","line":292,"updated":"2016-12-14 18:19:34.000000000","message":"I get a TypeError here. I changed it to APIVersion(MIN_VERSION) and it worked.","commit_id":"9ffbf4d56da5e0569343f55945dccdb72e10dfdb"},{"author":{"_account_id":22227,"name":"Justin A Wilson","email":"justin.wilson@intel.com","username":"waj334"},"change_message_id":"cb1f8bb2970f5548f0f313aaa25ca83dd6a4ea35","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    :param server_end_version:"},{"line_number":320,"context_line":"    :return:"},{"line_number":321,"context_line":"    \"\"\""},{"line_number":322,"context_line":"    if MIN_VERSION \u003e server_end_version:"},{"line_number":323,"context_line":"        raise exceptions.UnsupportedVersion("},{"line_number":324,"context_line":"            _(\"Server\u0027s version is too old. The client\u0027s valid version range \""},{"line_number":325,"context_line":"              \"is \u0027%(client_min)s\u0027 to \u0027%(client_max)s\u0027. The server valid \""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_64e85db5","line":322,"updated":"2016-12-14 18:19:34.000000000","message":"Same as above. Change this to APIVersion(MIN_VERSION) to avoid a type exception.","commit_id":"9ffbf4d56da5e0569343f55945dccdb72e10dfdb"},{"author":{"_account_id":22227,"name":"Justin A Wilson","email":"justin.wilson@intel.com","username":"waj334"},"change_message_id":"cb1f8bb2970f5548f0f313aaa25ca83dd6a4ea35","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                  \u0027client_max\u0027: MAX_VERSION,"},{"line_number":329,"context_line":"                  \u0027server_min\u0027: server_start_version.get_string(),"},{"line_number":330,"context_line":"                  \u0027server_max\u0027: server_end_version.get_string()})"},{"line_number":331,"context_line":"    elif MAX_VERSION \u003c server_start_version:"},{"line_number":332,"context_line":"        raise exceptions.UnsupportedVersion("},{"line_number":333,"context_line":"            _(\"Server\u0027s version is too new. The client\u0027s valid version range \""},{"line_number":334,"context_line":"              \"is \u0027%(client_min)s\u0027 to \u0027%(client_max)s\u0027. The server valid \""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_04d8891c","line":331,"updated":"2016-12-14 18:19:34.000000000","message":"same as above","commit_id":"9ffbf4d56da5e0569343f55945dccdb72e10dfdb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7873b1dbf3730d7b3f2dda7ac0091afda7487b59","unresolved":false,"context_lines":[{"line_number":30,"context_line":"DEPRECATED_VERSIONS \u003d {\"1\": \"2\"}"},{"line_number":31,"context_line":"DEPRECATED_VERSION \u003d \"2.0\""},{"line_number":32,"context_line":"MAX_VERSION \u003d \"3.15\""},{"line_number":33,"context_line":"MIN_VERSION \u003d \"3.0\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_SUBSTITUTIONS \u003d {}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_203a54ce","line":33,"updated":"2016-12-21 21:41:45.000000000","message":"what happens when someone uses a new cinderclient with an older cinder?   The log below is going to say it requires a minimum version of 3.0","commit_id":"fcb0cf55ee70dd6bfab920708c141f90e382d2e0"}],"cinderclient/client.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"65fdefba061c27e52756aeaf50fb12fad7bdb63c","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        return base_url"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def _cs_request_base_url(self, url, method, **kwargs):"},{"line_number":431,"context_line":"        base_url \u003d self._get_base_url(**kwargs)"},{"line_number":432,"context_line":"        return self._cs_request("},{"line_number":433,"context_line":"            base_url + url,"},{"line_number":434,"context_line":"            method,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_e67f00a9","line":431,"range":{"start_line":431,"start_character":19,"end_line":431,"end_character":47},"updated":"2017-03-09 14:24:03.000000000","message":"-1 Due to _get_base_url method accept only self as input parameter i think this call will trigger TypeError","commit_id":"b6a5baaa9c9d2307ca9a50c5003394e26c8d2e02"}],"cinderclient/tests/unit/test_api_versions.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"65fdefba061c27e52756aeaf50fb12fad7bdb63c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        mock_apiversion.assert_called_once_with(version)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"class DiscoverVersionTestCase(utils.TestCase):"},{"line_number":190,"context_line":"    def setUp(self):"},{"line_number":191,"context_line":"        super(DiscoverVersionTestCase, self).setUp()"},{"line_number":192,"context_line":"        self.orig_max \u003d api_versions.MAX_VERSION"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_11ba8c0a","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":46},"updated":"2017-03-09 14:24:03.000000000","message":"-1\nIt seems that this class wants to be covered by @ddt.dtt decorator :)","commit_id":"b6a5baaa9c9d2307ca9a50c5003394e26c8d2e02"}]}