)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22025,"name":"James Conroy","email":"jayryanconroy@gmail.com","username":"jayconroy"},"change_message_id":"95d780249ddcee61199a0449a6674202f2b103ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jon Bernard \u003cjobernar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-25 16:02:12 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove cinder credentials command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This function has been broken for some time, this patch replaces it with"},{"line_number":10,"context_line":"a helpful message.  This function can be removed in the next release."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_c19fd8b2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2016-10-26 08:23:05.000000000","message":"Change title to \"Deprecate \u0027cinder credentials\u0027 command\", I do not think it should be removed yet.","commit_id":"bb1dd8a310f8b181d026e5c349a0d5adf3e67261"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":22025,"name":"James Conroy","email":"jayryanconroy@gmail.com","username":"jayconroy"},"change_message_id":"95d780249ddcee61199a0449a6674202f2b103ef","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"def do_credentials(cs, args):"},{"line_number":1246,"context_line":"    \"\"\"Shows user credentials returned from auth.\"\"\""},{"line_number":1247,"context_line":"    catalog \u003d cs.client.service_catalog.catalog"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    # formatters defines field to be converted from unicode to string"},{"line_number":1250,"context_line":"    utils.print_dict(catalog[\u0027user\u0027], \"User Credentials\","},{"line_number":1251,"context_line":"                     formatters\u003d[\u0027domain\u0027, \u0027roles\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_61be0c01","side":"PARENT","line":1248,"updated":"2016-10-26 08:23:05.000000000","message":"I don\u0027t think you should remove the code yet, it could still be fixed. Warn the user that the command is deprecated and to use the openstack client instead.","commit_id":"e30cc559429c8156620ee7ac1ba9ce0bfd736141"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"ea9154ae9fb83b7bb87f0f18084a075cf3205465","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"def do_credentials(cs, args):"},{"line_number":1246,"context_line":"    \"\"\"Shows user credentials returned from auth.\"\"\""},{"line_number":1247,"context_line":"    catalog \u003d cs.client.service_catalog.catalog"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    # formatters defines field to be converted from unicode to string"},{"line_number":1250,"context_line":"    utils.print_dict(catalog[\u0027user\u0027], \"User Credentials\","},{"line_number":1251,"context_line":"                     formatters\u003d[\u0027domain\u0027, \u0027roles\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_4690d7ec","side":"PARENT","line":1248,"in_reply_to":"ba5da102_61be0c01","updated":"2016-10-31 16:30:39.000000000","message":"I considered this, the conlusion I reached was that since this function has been broken for over a year that it\u0027s effectively already been \"deprecated\".  If there is consensus around making it work again so that we can properly deprecate it, I\u0027m happy to make the change.","commit_id":"e30cc559429c8156620ee7ac1ba9ce0bfd736141"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"714200fc03210d5949d651f27757fe19eb5dcee1","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"def do_credentials(cs, args):"},{"line_number":1246,"context_line":"    \"\"\"Shows user credentials returned from auth.\"\"\""},{"line_number":1247,"context_line":"    warnings.warn("},{"line_number":1248,"context_line":"        \"``cinder credentials`` is deprecated, use ``openstack client`` \""},{"line_number":1249,"context_line":"        \"instead. The ``cinder credentials`` command has been broken for \""},{"line_number":1250,"context_line":"        \"some time and should no longer be used.\")"},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"_quota_resources \u003d [\u0027volumes\u0027, \u0027snapshots\u0027, \u0027gigabytes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_9eb53dd2","line":1250,"range":{"start_line":1248,"start_character":7,"end_line":1250,"end_character":50},"updated":"2016-10-26 07:57:21.000000000","message":"I think this kind of prompt message is of little friendly.","commit_id":"bb1dd8a310f8b181d026e5c349a0d5adf3e67261"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"ea9154ae9fb83b7bb87f0f18084a075cf3205465","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"    warnings.warn("},{"line_number":1248,"context_line":"        \"``cinder credentials`` is deprecated, use ``openstack client`` \""},{"line_number":1249,"context_line":"        \"instead. The ``cinder credentials`` command has been broken for \""},{"line_number":1250,"context_line":"        \"some time and should no longer be used.\")"},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"_quota_resources \u003d [\u0027volumes\u0027, \u0027snapshots\u0027, \u0027gigabytes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_a627f362","line":1250,"in_reply_to":"ba5da102_9eb53dd2","updated":"2016-10-31 16:30:39.000000000","message":"I agree, will update.","commit_id":"bb1dd8a310f8b181d026e5c349a0d5adf3e67261"}],"releasenotes/notes/deprecate-credentials-e92b68e3bda80057.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fd10ba0eae7f59899c842bc1010dfe373e2a53ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - cinder credentials is deprecated. Please use openstack token issue"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a74a57a_057bb07b","line":3,"updated":"2016-11-29 11:52:14.000000000","message":"We can\u0027t really state it is deprecated since it is actually being removed here.\n\nI agree it is a little tricky. To follow policy, we really should have a deprecation period before actually removing the code. But as you point out, it has been broken for some time, so obviously no one is using it. It would not make a lot of sense to fix it just to keep it around a few more months to delete it.\n\nI think this should be updated to be in a different section. Looking through the sections, I would say either in the Fixes or the Other sections. I\u0027m leaning a little towards Other, as this is kind of unique, and having it there will make it visible. It should probably state something like \"the cinder credentials command has not worked for several releases. The preferred alternative is to us the openstack token issue command, therefore the cinder credentials command has been removed.\"","commit_id":"bb1dd8a310f8b181d026e5c349a0d5adf3e67261"}]}