)]}'
{"cinderclient/client.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"b52a18ff4a3c40738d102fe6206a52016f3ebca6","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            string_parts.append(header)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if \u0027data\u0027 in kwargs:"},{"line_number":280,"context_line":"            if \"password\" in kwargs[\u0027data\u0027]:"},{"line_number":281,"context_line":"                data \u003d strutils.mask_password(kwargs[\u0027data\u0027])"},{"line_number":282,"context_line":"            else:"},{"line_number":283,"context_line":"                data \u003d kwargs[\u0027data\u0027]"},{"line_number":284,"context_line":"            string_parts.append(\" -d \u0027%s\u0027\" % (data))"},{"line_number":285,"context_line":"        self._logger.debug(\"\\nREQ: %s\\n\" % \"\".join(string_parts))"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_3655c81c","line":283,"range":{"start_line":280,"start_character":12,"end_line":283,"end_character":37},"updated":"2016-11-09 11:08:08.000000000","message":"Can you also fix this? We should not only mask here if password is in the string. mask_password() can mask many more sensitive keys like \u0027token, secret\u0027, etc","commit_id":"0bc18991f1b7f5d86217f621a2d0c0a01db3dd03"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"209089424a9f2588df3a747cbd62e8eca04cdc45","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            string_parts.append(header)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if \u0027data\u0027 in kwargs:"},{"line_number":280,"context_line":"            if \"password\" in kwargs[\u0027data\u0027]:"},{"line_number":281,"context_line":"                data \u003d strutils.mask_password(kwargs[\u0027data\u0027])"},{"line_number":282,"context_line":"            else:"},{"line_number":283,"context_line":"                data \u003d kwargs[\u0027data\u0027]"},{"line_number":284,"context_line":"            string_parts.append(\" -d \u0027%s\u0027\" % (data))"},{"line_number":285,"context_line":"        self._logger.debug(\"\\nREQ: %s\\n\" % \"\".join(string_parts))"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_6f3cbee2","line":283,"range":{"start_line":280,"start_character":12,"end_line":283,"end_character":37},"in_reply_to":"9a629dbe_3655c81c","updated":"2016-11-09 14:04:39.000000000","message":"Yeah, I noticed that too but was on the fence about doing it in a separate change. I\u0027ll update it here though.","commit_id":"0bc18991f1b7f5d86217f621a2d0c0a01db3dd03"}],"cinderclient/tests/unit/test_client.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"141ab1a0283b058fb5d8695cdb81c2cb8066040b","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        cs.http_log_resp(resp)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        output \u003d self.logger.output.split(\u0027\\n\u0027)"},{"line_number":314,"context_line":"        self.assertIn(\u0027CHAP\u0027, output[1], output)"},{"line_number":315,"context_line":"        self.assertNotIn(auth_password, output[1], output)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_403b7238","line":314,"updated":"2016-11-08 19:39:57.000000000","message":"Why not assert that \"***\" is present?","commit_id":"b5cb92844e1d3d69551ca3499f84abae17497f00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8a9cc41607e74c41d8a61a742afa174977299368","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        cs.http_log_resp(resp)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        output \u003d self.logger.output.split(\u0027\\n\u0027)"},{"line_number":314,"context_line":"        self.assertIn(\u0027CHAP\u0027, output[1], output)"},{"line_number":315,"context_line":"        self.assertNotIn(auth_password, output[1], output)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_a17d26e9","line":314,"in_reply_to":"9a629dbe_403b7238","updated":"2016-11-09 01:56:21.000000000","message":"This is to make sure I\u0027m checking the right thing. Before I had this check, the test was passing but for the wrong reason, because I was using output[2] which was \u0027\u0027 so \"kk4qD6CpKFLyz9JD\" not in \u0027\u0027 was passing, but a false positive. I just threw that other one in there to make sure I\u0027m looking at the right string. I could change it to *** if that\u0027s wanted/needed.","commit_id":"b5cb92844e1d3d69551ca3499f84abae17497f00"}]}