)]}'
{"id":"openstack%2Fpython-cinderclient~413423","triplet_id":"openstack%2Fpython-cinderclient~master~If33ec39eb176c14086132d3099c6ec577f956ded","project":"openstack/python-cinderclient","branch":"master","topic":"python3.0_1","hashtags":[],"change_id":"If33ec39eb176c14086132d3099c6ec577f956ded","subject":"Python3 common patterns","status":"MERGED","created":"2016-12-21 06:00:09.000000000","updated":"2017-01-24 12:43:10.000000000","submitted":"2017-01-24 12:43:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d25f447f424ed3d9814a1cd7ce88de4b9a45291c","_number":413423,"virtual_id_number":413423,"owner":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":2,"date":"2017-01-24 12:43:10.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-01-23 22:54:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2017-01-10 08:55:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},{"value":2,"date":"2017-01-24 11:25:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},{"value":1,"date":"2017-01-24 11:25:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-27 15:05:57.000000000","updated_by":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"reviewer":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"state":"REVIEWER"},{"updated":"2017-01-23 22:54:35.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-01-24 11:25:57.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2017-01-24 12:43:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"08bde39d0087d4f8845ee052b6d2f52172e53896","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-12-21 06:00:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3106e6aaf5e53fab97a5a7fe7bbced23dade1cb6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-21 06:55:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/23/413423/1/check/gate-python-cinderclient-docs-ubuntu-xenial/0617918//doc/build/html/ : SUCCESS in 3m 50s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/23/413423/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/2b5cd18/ : SUCCESS in 3m 34s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/23/413423/1/check/gate-python-cinderclient-python27-ubuntu-xenial/4ed47e3/ : SUCCESS in 3m 15s\n- gate-python-cinderclient-python35 http://logs.openstack.org/23/413423/1/check/gate-python-cinderclient-python35/1a30376/ : SUCCESS in 2m 57s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/23/413423/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/4259b25/ : SUCCESS in 54m 37s\n- gate-python-cinderclient-pypy http://logs.openstack.org/23/413423/1/check/gate-python-cinderclient-pypy/cb17341/ : SUCCESS in 2m 20s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/23/413423/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/46acb3a/ : SUCCESS in 19m 31s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/23/413423/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/849e140/ : SUCCESS in 19m 30s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/23/413423/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/2896591/ : SUCCESS in 2m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6501d25f5bde59c87bf082625f37abb93b5dccb6","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-12-22 08:41:25.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"24659fd74ffa118e49d1820c47a34394af2b71b9","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-12-22 08:42:32.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"4eab9fe5c9742c9a4ccce11d7ef5cf82fedc8a5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-22 09:36:59.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/23/413423/3/check/gate-python-cinderclient-docs-ubuntu-xenial/8897a0f//doc/build/html/ : SUCCESS in 3m 39s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-pep8-ubuntu-xenial/dee7128/ : SUCCESS in 2m 22s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-python27-ubuntu-xenial/5c43200/ : SUCCESS in 2m 24s\n- gate-python-cinderclient-python35 http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-python35/42ffcae/ : SUCCESS in 2m 20s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/23/413423/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/a339a05/ : FAILURE in 54m 15s\n- gate-python-cinderclient-pypy http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-pypy/135f9b9/ : SUCCESS in 2m 32s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/23/413423/3/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/78fa1c9/ : SUCCESS in 29m 00s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/23/413423/3/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/ed5a8c4/ : SUCCESS in 28m 14s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-pylint-ubuntu-xenial/8bf7593/ : SUCCESS in 3m 36s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f32faeec066891d83b4108b8760ae18224d548b4","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2016-12-22 10:28:11.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"45b3bc0ffa46c8d9cb32045fff891f1d3f745700","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-22 11:49:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/23/413423/3/check/gate-python-cinderclient-docs-ubuntu-xenial/24b7d11//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-pep8-ubuntu-xenial/4dbb2a2/ : SUCCESS in 2m 37s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-python27-ubuntu-xenial/4f7dd5c/ : SUCCESS in 5m 15s\n- gate-python-cinderclient-python35 http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-python35/2c79d31/ : SUCCESS in 5m 08s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/23/413423/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/2fc3738/ : SUCCESS in 1h 13m 19s\n- gate-python-cinderclient-pypy http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-pypy/3f57db4/ : SUCCESS in 5m 13s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/23/413423/3/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/bf7a280/ : SUCCESS in 35m 27s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/23/413423/3/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/e7c64d5/ : SUCCESS in 19m 59s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/23/413423/3/check/gate-python-cinderclient-pylint-ubuntu-xenial/b81c80b/ : SUCCESS in 2m 22s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"3b9460f4dc459b30f7f5ec46f07064c95274ae41","author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"date":"2016-12-27 15:05:57.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"1f7997c8b7c3577cbd7d99c6d8962833b57e0d42","author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"date":"2017-01-10 08:55:30.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"c3c1e8417a3b3ac101d338d7daa3b34fce20d2eb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-10 10:23:59.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/23/413423/4/check/gate-python-cinderclient-docs-ubuntu-xenial/cc74bdc//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/23/413423/4/check/gate-python-cinderclient-pep8-ubuntu-xenial/4e73a4a/ : SUCCESS in 2m 31s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/23/413423/4/check/gate-python-cinderclient-python27-ubuntu-xenial/f0eef67/ : SUCCESS in 2m 31s\n- gate-python-cinderclient-python35 http://logs.openstack.org/23/413423/4/check/gate-python-cinderclient-python35/5451605/ : SUCCESS in 3m 09s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/23/413423/4/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/cbc0030/ : SUCCESS in 1h 26m 23s\n- gate-python-cinderclient-pypy http://logs.openstack.org/23/413423/4/check/gate-python-cinderclient-pypy/4825077/ : SUCCESS in 3m 50s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/23/413423/4/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/6e4853e/ : SUCCESS in 28m 05s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/23/413423/4/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/4fc815e/ : SUCCESS in 27m 40s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/23/413423/4/check/gate-python-cinderclient-pylint-ubuntu-xenial/52b99c9/ : SUCCESS in 3m 42s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"28d9e056de920f3538dc1169b09e2d0b5b3e15ff","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-01-23 22:54:35.000000000","message":"Patch Set 4: Code-Review+2\n\nEverything including pypy is happy with it, so looks good to me.","accounts_in_message":[],"_revision_number":4},{"id":"1c9f75e0162687506c951156cd303c2366518260","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2017-01-24 11:25:57.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"ff85482b750c3afc79f913ca8973e272c49ce31b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 11:26:07.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"29b7fab7dd05f10f2af3bb9ac8698198266a4ac3","date":"2017-01-24 12:43:10.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"18f121245d0f817679c66d348cc1a83392bb21aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 12:43:10.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/23/413423/4/gate/gate-python-cinderclient-docs-ubuntu-xenial/70bf7d6//doc/build/html/ : SUCCESS in 2m 56s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/23/413423/4/gate/gate-python-cinderclient-pep8-ubuntu-xenial/5e7cc48/ : SUCCESS in 4m 10s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/23/413423/4/gate/gate-python-cinderclient-python27-ubuntu-xenial/baeedc2/ : SUCCESS in 3m 55s\n- gate-python-cinderclient-python35 http://logs.openstack.org/23/413423/4/gate/gate-python-cinderclient-python35/cf6f048/ : SUCCESS in 4m 23s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/23/413423/4/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/e29ba33/ : SUCCESS in 1h 15m 16s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"44507540f6904e2ae5bba8283723de2f6748810b","revisions":{"d48b75111da6202c9b367b484c5ea9c218ac00d1":{"kind":"REWORK","_number":1,"created":"2016-12-21 06:00:09.000000000","uploader":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"ref":"refs/changes/23/413423/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/413423/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/1"}}},"commit":{"parents":[{"commit":"82b4550c811295c8659f62cdd5fdcb329921fe54","subject":"Merge \"Add Constraints support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/82b4550c811295c8659f62cdd5fdcb329921fe54"}]}],"author":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-12-21 05:58:23.000000000","tz":480},"committer":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-12-21 05:58:23.000000000","tz":480},"subject":"Python3 common patterns","message":"Python3 common patterns\n\nModify some codes in order to lead them meet the python3 common pattern.\nReference:https://wiki.openstack.org/wiki/Python3#Common patterns\n\nChange-Id: If33ec39eb176c14086132d3099c6ec577f956ded\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d48b75111da6202c9b367b484c5ea9c218ac00d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d48b75111da6202c9b367b484c5ea9c218ac00d1"}]},"branch":"refs/heads/master"},"50b2ac543c50d159d387a2fba3c21d0fded24eaa":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-12-22 08:41:25.000000000","uploader":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"ref":"refs/changes/23/413423/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/413423/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/2"}}},"commit":{"parents":[{"commit":"82b4550c811295c8659f62cdd5fdcb329921fe54","subject":"Merge \"Add Constraints support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/82b4550c811295c8659f62cdd5fdcb329921fe54"}]}],"author":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-12-21 05:58:23.000000000","tz":480},"committer":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-12-22 08:36:42.000000000","tz":480},"subject":"Modify some codes in order to lead them meet the python3 common pattern. Look through the following patterns of Cinder,       map() and filter() if a list is needed on Python 3:           Replace map(func, data) with [func(item) for item in data]           Replace filter(lambda obj: test(obj), data) with              [obj for obj in data if test(obj)]       Replace exceptions.OSError with OSError and          remove \"import exceptions\"       Replace iterator.next() with next(iterator)       Replace basestring with six.string_types       Replace unicode with six.text_type       Replace (str, unicode) with six.string_types       Replace \"for key in dict.iterkeys()\" with \"for key in dict\"       Replace dict.iteritems() with dict.items()       Replace dict.itervalues() with dict.values() I found that only \"filter(lambda obj: test(obj), data)\" and \"map(func, data)\"need to modify. The other items are not be founded in Cinder.","message":"Modify some codes in order to lead them meet the python3 common pattern.\nLook through the following patterns of Cinder,\n      map() and filter() if a list is needed on Python 3:\n          Replace map(func, data) with [func(item) for item in data]\n          Replace filter(lambda obj: test(obj), data) with\n             [obj for obj in data if test(obj)]\n      Replace exceptions.OSError with OSError and\n         remove \"import exceptions\"\n      Replace iterator.next() with next(iterator)\n      Replace basestring with six.string_types\n      Replace unicode with six.text_type\n      Replace (str, unicode) with six.string_types\n      Replace \"for key in dict.iterkeys()\" with \"for key in dict\"\n      Replace dict.iteritems() with dict.items()\n      Replace dict.itervalues() with dict.values()\nI found that only \"filter(lambda obj: test(obj), data)\" and\n\"map(func, data)\"need to modify.\nThe other items are not be founded in Cinder.\n\nReference:https://wiki.openstack.org/wiki/Python3#Common_patterns\n\nChange-Id: If33ec39eb176c14086132d3099c6ec577f956ded\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/50b2ac543c50d159d387a2fba3c21d0fded24eaa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/50b2ac543c50d159d387a2fba3c21d0fded24eaa"}]},"branch":"refs/heads/master"},"959b92e846995ed4962e249bbcf6655bec6f15d4":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-12-22 08:42:32.000000000","uploader":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"ref":"refs/changes/23/413423/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/413423/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/3"}}},"commit":{"parents":[{"commit":"82b4550c811295c8659f62cdd5fdcb329921fe54","subject":"Merge \"Add Constraints support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/82b4550c811295c8659f62cdd5fdcb329921fe54"}]}],"author":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-12-21 05:58:23.000000000","tz":480},"committer":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-12-22 08:41:46.000000000","tz":480},"subject":"Python3 common patterns","message":"Python3 common patterns\n\nModify some codes in order to lead them meet the python3 common pattern.\nLook through the following patterns of Cinder,\n      map() and filter() if a list is needed on Python 3:\n          Replace map(func, data) with [func(item) for item in data]\n          Replace filter(lambda obj: test(obj), data) with\n             [obj for obj in data if test(obj)]\n      Replace exceptions.OSError with OSError and\n         remove \"import exceptions\"\n      Replace iterator.next() with next(iterator)\n      Replace basestring with six.string_types\n      Replace unicode with six.text_type\n      Replace (str, unicode) with six.string_types\n      Replace \"for key in dict.iterkeys()\" with \"for key in dict\"\n      Replace dict.iteritems() with dict.items()\n      Replace dict.itervalues() with dict.values()\nI found that only \"filter(lambda obj: test(obj), data)\" and\n\"map(func, data)\"need to modify.\nThe other items are not be founded in Cinder.\n\nReference:https://wiki.openstack.org/wiki/Python3#Common_patterns\n\nChange-Id: If33ec39eb176c14086132d3099c6ec577f956ded\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/959b92e846995ed4962e249bbcf6655bec6f15d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/959b92e846995ed4962e249bbcf6655bec6f15d4"}]},"branch":"refs/heads/master"},"44507540f6904e2ae5bba8283723de2f6748810b":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2017-01-10 08:55:30.000000000","uploader":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"ref":"refs/changes/23/413423/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/413423/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/413423/4"}}},"commit":{"parents":[{"commit":"4eb63b8ef278de2e82e3b4957b95ba6fd9032e4f","subject":"Merge \"Minor refactoring for nested try-block\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4eb63b8ef278de2e82e3b4957b95ba6fd9032e4f"}]}],"author":{"name":"xianming mao","email":"xianming.mao@easystack.cn","date":"2016-12-21 05:58:23.000000000","tz":480},"committer":{"name":"xianming.mao","email":"xianming.mao@easystack.cn","date":"2017-01-10 08:55:30.000000000","tz":0},"subject":"Python3 common patterns","message":"Python3 common patterns\n\nModify some codes in order to lead them meet the python3 common pattern.\nLook through the following patterns of Cinder,\n      map() and filter() if a list is needed on Python 3:\n          Replace map(func, data) with [func(item) for item in data]\n          Replace filter(lambda obj: test(obj), data) with\n             [obj for obj in data if test(obj)]\n      Replace exceptions.OSError with OSError and\n         remove \"import exceptions\"\n      Replace iterator.next() with next(iterator)\n      Replace basestring with six.string_types\n      Replace unicode with six.text_type\n      Replace (str, unicode) with six.string_types\n      Replace \"for key in dict.iterkeys()\" with \"for key in dict\"\n      Replace dict.iteritems() with dict.items()\n      Replace dict.itervalues() with dict.values()\nI found that only \"filter(lambda obj: test(obj), data)\" and\n\"map(func, data)\"need to modify.\nThe other items are not be founded in Cinder.\n\nReference:https://wiki.openstack.org/wiki/Python3#Common_patterns\n\nChange-Id: If33ec39eb176c14086132d3099c6ec577f956ded\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/44507540f6904e2ae5bba8283723de2f6748810b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/44507540f6904e2ae5bba8283723de2f6748810b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}