)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f1b31ca2201a7b784ead42884487a2a24f0d4045","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-12-27 13:53:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix adding non-ascii attrs to Resource objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0493845dafc5dad836e899b9c22d563023c1dab0"},{"line_number":10,"context_line":"Closes-Bug: #1652605"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a3c09a3_17d11efc","line":8,"updated":"2017-01-12 22:03:57.000000000","message":"If you do an update, please add a brief description of the bug here so it\u0027s easy to tell what was being fixed.","commit_id":"2bf46360abefed98188d8873ad5a84534fd60e21"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d97be8991d2989f61dd08b7e099177d9df81b827","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix adding non-ascii attrs to Resource objects error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to these lines of code [0] we don\u0027t have an opportunity"},{"line_number":10,"context_line":"to add attributes with non-ascii symbols to Resource objects,"},{"line_number":11,"context_line":"but information about it will be in _info dict."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a3c09a3_6ce865b5","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":30},"updated":"2017-01-16 15:42:14.000000000","message":"nit: It\u0027s a bad idea writing references to github since they will be soon be invalid.","commit_id":"a38e52962cf6f752c5891e7edf7e5ad891a14c67"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d97be8991d2989f61dd08b7e099177d9df81b827","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Because we don\u0027t have such an attr, here [1] it will be added"},{"line_number":15,"context_line":"None value instead of real value [2]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch fix this problem."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[0] - https://github.com/openstack/python-cinderclient/blob/master/cinderclient/apiclient/base.py#L498-L499"},{"line_number":20,"context_line":"[1] - https://github.com/openstack/python-cinderclient/blob/master/cinderclient/shell_utils.py#L179"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a3c09a3_ecf3759c","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":14},"updated":"2017-01-16 15:42:14.000000000","message":"nit: fixes","commit_id":"a38e52962cf6f752c5891e7edf7e5ad891a14c67"}],"cinderclient/tests/unit/test_base.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"582097f0ddb57c3e0f2c42616cc71b676c4b5a00","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                \u0027id\u0027: \u0027admin\u0027}"},{"line_number":53,"context_line":"        res \u003d base.Resource(None, info)"},{"line_number":54,"context_line":"        expected \u003d (\"\u003cResource gigabytes_тест\u003d-1, id\u003dadmin, volumes_тест\u003d-1\u003e\")"},{"line_number":55,"context_line":"        self.assertEqual(expected, repr(res))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_getid(self):"},{"line_number":58,"context_line":"        self.assertEqual(4, base.getid(4))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_fbcdf45d","line":55,"updated":"2017-01-16 14:08:48.000000000","message":"-1: Relying on the repr of the class doesn\u0027t seem like a good idea, I think we should be checking that the attribute actually exists instead.","commit_id":"2bf46360abefed98188d8873ad5a84534fd60e21"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d97be8991d2989f61dd08b7e099177d9df81b827","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        res \u003d base.Resource(None, info)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        for key, value in info.items():"},{"line_number":57,"context_line":"            self.assertEqual(value, getattr(res, key, None))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_getid(self):"},{"line_number":60,"context_line":"        self.assertEqual(4, base.getid(4))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_cc9f994e","line":57,"range":{"start_line":57,"start_character":54,"end_line":57,"end_character":58},"updated":"2017-01-16 15:42:14.000000000","message":"nit: We should not pass a default, that way it will raise an exception if the key doesn\u0027t exists.  It isn\u0027t a big issue since this is a test and none of the values are None.","commit_id":"a38e52962cf6f752c5891e7edf7e5ad891a14c67"}]}