)]}'
{"cinderclient/client.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2fcd6a403e6c44abb77c68c8822b12c96bb3bf68","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_server_version(url):"},{"line_number":76,"context_line":"    \"\"\"Queries the server via the naked endpoint and parses the version"},{"line_number":77,"context_line":"    info that is returned."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    :param url: url of the cinder server"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_9fd79cbe","line":76,"updated":"2017-01-26 19:32:58.000000000","message":"Nit if you care. Or not. Docstring should be one line and end with a period. Then expanded description after a blank line.","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"2f56a9d735160f609450aebf9061bc8357dcbe1b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_server_version(url):"},{"line_number":76,"context_line":"    \"\"\"Queries the server via the naked endpoint and parses the version"},{"line_number":77,"context_line":"    info that is returned."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    :param url: url of the cinder server"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_1a2ada7e","line":76,"in_reply_to":"3a461143_9fd79cbe","updated":"2017-01-26 19:38:44.000000000","message":"I\u0027m a very caring person. I\u0027ll fix.","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ddb11a7dec569e0dbcba8259d5498b98aa1e0104","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \"\"\"Queries the server via the naked endpoint and parses the version"},{"line_number":77,"context_line":"    info that is returned."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    :param url: url of the cinder server"},{"line_number":80,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":81,"context_line":"              the server"},{"line_number":82,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_ff826051","line":79,"updated":"2017-01-26 19:15:48.000000000","message":"can you clarify this?  What cinder server?  The cinder API Service? for example.....","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"6815a9728e92f156906526396e6624bd7d6386d7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \"\"\"Queries the server via the naked endpoint and parses the version"},{"line_number":77,"context_line":"    info that is returned."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    :param url: url of the cinder server"},{"line_number":80,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":81,"context_line":"              the server"},{"line_number":82,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_bfe618b2","line":79,"in_reply_to":"3a461143_7ff91080","updated":"2017-01-26 19:33:46.000000000","message":"endpoint please","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"2f56a9d735160f609450aebf9061bc8357dcbe1b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \"\"\"Queries the server via the naked endpoint and parses the version"},{"line_number":77,"context_line":"    info that is returned."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    :param url: url of the cinder server"},{"line_number":80,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":81,"context_line":"              the server"},{"line_number":82,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_5a2462ae","line":79,"in_reply_to":"3a461143_bfe618b2","updated":"2017-01-26 19:38:44.000000000","message":"Will do","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"86db788a514ff72d132f159badcd0d6b2be3aca5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \"\"\"Queries the server via the naked endpoint and parses the version"},{"line_number":77,"context_line":"    info that is returned."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    :param url: url of the cinder server"},{"line_number":80,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":81,"context_line":"              the server"},{"line_number":82,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_7ff91080","line":79,"in_reply_to":"3a461143_ff826051","updated":"2017-01-26 19:27:32.000000000","message":"yup, that should be the Cinder API server.\nOr perhaps better to state:\nThe Cinder endpoint.","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2fcd6a403e6c44abb77c68c8822b12c96bb3bf68","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    logger \u003d logging.getLogger(__name__)"},{"line_number":85,"context_line":"    try:"},{"line_number":86,"context_line":"        scheme, netloc, path, query, frag \u003d urlparse.urlsplit(url)"},{"line_number":87,"context_line":"        response \u003d requests.get(\u0027http://\u0027 + netloc)"},{"line_number":88,"context_line":"        data \u003d json.loads(response.text)"},{"line_number":89,"context_line":"        versions \u003d data[\u0027versions\u0027]"},{"line_number":90,"context_line":"        for version in versions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_1f99ec1f","line":87,"range":{"start_line":87,"start_character":36,"end_line":87,"end_character":37},"updated":"2017-01-26 19:32:58.000000000","message":"Do we need to care about https?","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"2f56a9d735160f609450aebf9061bc8357dcbe1b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    logger \u003d logging.getLogger(__name__)"},{"line_number":85,"context_line":"    try:"},{"line_number":86,"context_line":"        scheme, netloc, path, query, frag \u003d urlparse.urlsplit(url)"},{"line_number":87,"context_line":"        response \u003d requests.get(\u0027http://\u0027 + netloc)"},{"line_number":88,"context_line":"        data \u003d json.loads(response.text)"},{"line_number":89,"context_line":"        versions \u003d data[\u0027versions\u0027]"},{"line_number":90,"context_line":"        for version in versions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_da3052eb","line":87,"range":{"start_line":87,"start_character":36,"end_line":87,"end_character":37},"in_reply_to":"3a461143_1f99ec1f","updated":"2017-01-26 19:38:44.000000000","message":"yeah. That\u0027s actually in the scheme, so i should be using that.","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2fcd6a403e6c44abb77c68c8822b12c96bb3bf68","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                return (api_versions.APIVersion(version[\u0027min_version\u0027]),"},{"line_number":93,"context_line":"                        api_versions.APIVersion(version[\u0027version\u0027]))"},{"line_number":94,"context_line":"    except exceptions.ClientException as e:"},{"line_number":95,"context_line":"        msg \u003d (_(\"Error in server version query:%s\\n\""},{"line_number":96,"context_line":"                 \"Returning APIVersion 2.0\") % six.text_type(e.message))"},{"line_number":97,"context_line":"        logger.warning(msg)"},{"line_number":98,"context_line":"        return api_versions.APIVersion(\"2.0\"), api_versions.APIVersion(\"2.0\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_bfab781c","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":17},"updated":"2017-01-26 19:32:58.000000000","message":"Looks like this is only used in the log warning call. Should be _LW() then and can just be moved in to the log call.","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"2f56a9d735160f609450aebf9061bc8357dcbe1b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                return (api_versions.APIVersion(version[\u0027min_version\u0027]),"},{"line_number":93,"context_line":"                        api_versions.APIVersion(version[\u0027version\u0027]))"},{"line_number":94,"context_line":"    except exceptions.ClientException as e:"},{"line_number":95,"context_line":"        msg \u003d (_(\"Error in server version query:%s\\n\""},{"line_number":96,"context_line":"                 \"Returning APIVersion 2.0\") % six.text_type(e.message))"},{"line_number":97,"context_line":"        logger.warning(msg)"},{"line_number":98,"context_line":"        return api_versions.APIVersion(\"2.0\"), api_versions.APIVersion(\"2.0\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_fa4d0e73","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":17},"in_reply_to":"3a461143_bfab781c","updated":"2017-01-26 19:38:44.000000000","message":"Will do.","commit_id":"b70deafdeb217153d41d155c7f8ee5f5565bf7e2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4223b8d8e3064dc0255d897da8ad6d9a0c131a3c","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_server_version(url):"},{"line_number":76,"context_line":"    \"\"\"Queries the server via the naked endpoint and parses the version"},{"line_number":77,"context_line":"    info that is returned."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    :param url: url of the cinder API server"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_1acbba1f","line":76,"updated":"2017-01-26 19:50:47.000000000","message":"So you don\u0027t really care? :P","commit_id":"adb62ec9109c00b88551cf8e1de8d1174b5632ef"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8742495b2c7e7ad78c4f8420ffad977e527da749","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_server_version(url):"},{"line_number":76,"context_line":"    \"\"\"Queries the server via the naked endpoint and parses the version"},{"line_number":77,"context_line":"    info that is returned."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    :param url: url of the cinder API server"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_559d1358","line":76,"in_reply_to":"3a461143_1acbba1f","updated":"2017-01-26 20:08:54.000000000","message":"crap","commit_id":"adb62ec9109c00b88551cf8e1de8d1174b5632ef"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4223b8d8e3064dc0255d897da8ad6d9a0c131a3c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                return (api_versions.APIVersion(version[\u0027min_version\u0027]),"},{"line_number":93,"context_line":"                        api_versions.APIVersion(version[\u0027version\u0027]))"},{"line_number":94,"context_line":"    except exceptions.ClientException as e:"},{"line_number":95,"context_line":"        msg \u003d (_(\"Error in server version query:%s\\n\""},{"line_number":96,"context_line":"                 \"Returning APIVersion 2.0\") % six.text_type(e.message))"},{"line_number":97,"context_line":"        logger.warning(msg)"},{"line_number":98,"context_line":"        return api_versions.APIVersion(\"2.0\"), api_versions.APIVersion(\"2.0\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_7a559e4e","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":17},"updated":"2017-01-26 19:50:47.000000000","message":"Missed the _LW() bit.","commit_id":"adb62ec9109c00b88551cf8e1de8d1174b5632ef"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8742495b2c7e7ad78c4f8420ffad977e527da749","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                return (api_versions.APIVersion(version[\u0027min_version\u0027]),"},{"line_number":93,"context_line":"                        api_versions.APIVersion(version[\u0027version\u0027]))"},{"line_number":94,"context_line":"    except exceptions.ClientException as e:"},{"line_number":95,"context_line":"        msg \u003d (_(\"Error in server version query:%s\\n\""},{"line_number":96,"context_line":"                 \"Returning APIVersion 2.0\") % six.text_type(e.message))"},{"line_number":97,"context_line":"        logger.warning(msg)"},{"line_number":98,"context_line":"        return api_versions.APIVersion(\"2.0\"), api_versions.APIVersion(\"2.0\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_55b433d0","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":17},"in_reply_to":"3a461143_7a559e4e","updated":"2017-01-26 20:08:54.000000000","message":"crap","commit_id":"adb62ec9109c00b88551cf8e1de8d1174b5632ef"}]}