)]}'
{"id":"openstack%2Fpython-cinderclient~430308","triplet_id":"openstack%2Fpython-cinderclient~master~Ib5f86d1f0846e292457813c893b73c6999e554a5","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1596829","hashtags":[],"change_id":"Ib5f86d1f0846e292457813c893b73c6999e554a5","subject":"Handle log message interpolation by the logger","status":"MERGED","created":"2017-02-07 15:22:29.000000000","updated":"2017-02-09 18:12:09.000000000","submitted":"2017-02-09 18:12:09.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"40dc026f003db844f0119ceea76633440cc2194e","_number":430308,"virtual_id_number":430308,"owner":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":2,"date":"2017-02-09 18:12:09.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"recommended":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"all":[{"value":1,"date":"2017-02-07 23:26:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-02-07 16:24:08.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"value":2,"date":"2017-02-07 16:25:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2017-02-09 17:09:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":2,"date":"2017-02-07 16:18:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"all":[{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2017-02-09 17:09:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-07 16:18:03.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2017-02-07 16:24:08.000000000","updated_by":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"reviewer":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"state":"REVIEWER"},{"updated":"2017-02-07 16:25:33.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2017-02-07 23:26:31.000000000","updated_by":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"reviewer":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"state":"REVIEWER"},{"updated":"2017-02-09 17:09:20.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2017-02-09 18:12:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"41de4e8e0eb97f93371ff1ef023048b27da84439","author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"date":"2017-02-07 15:22:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1616df8c24016c7f656aee54d24ceb5a06eb95a6","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2017-02-07 16:18:03.000000000","message":"Patch Set 1: Code-Review+2\n\nGood catch.  Thanks for proposing this.","accounts_in_message":[],"_revision_number":1},{"id":"188e6a993999e53b11d039436d61ba7e13adf6c8","author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"date":"2017-02-07 16:24:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"af19e93093c19f0f1f83476c072a53a89bec6d19","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2017-02-07 16:25:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"df654904e33de340c9b38848ab003cc86b7686b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-07 16:46:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/08/430308/1/check/gate-python-cinderclient-docs-ubuntu-xenial/0dcdb01//doc/build/html/ : SUCCESS in 2m 24s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/08/430308/1/check/gate-python-cinderclient-pep8-ubuntu-xenial/ae9976c/ : SUCCESS in 4m 59s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/08/430308/1/check/gate-python-cinderclient-python27-ubuntu-xenial/cef438f/ : SUCCESS in 2m 40s\n- gate-python-cinderclient-python35 http://logs.openstack.org/08/430308/1/check/gate-python-cinderclient-python35/f86e387/ : SUCCESS in 3m 57s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/08/430308/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/1cff9d2/ : SUCCESS in 1h 22m 55s\n- gate-python-cinderclient-pypy http://logs.openstack.org/08/430308/1/check/gate-python-cinderclient-pypy/f5f94f1/ : SUCCESS in 5m 21s (non-voting)\n- gate-cinderclient-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/08/430308/1/check/gate-cinderclient-dsvm-functional-ubuntu-xenial-nv/67fe6ab/ : SUCCESS in 29m 31s (non-voting)\n- gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/08/430308/1/check/gate-cinderclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/10b0b7f/ : SUCCESS in 18m 01s (non-voting)\n- gate-python-cinderclient-pylint-ubuntu-xenial http://logs.openstack.org/08/430308/1/check/gate-python-cinderclient-pylint-ubuntu-xenial/2fcfe06/ : SUCCESS in 2m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9a31538c3b61e0c58f28d6815d79bb532d804645","author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"date":"2017-02-07 23:26:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6fe2966f646d17a79ffcea32133d39aa20aa694d","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2017-02-09 17:09:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"28b9cda99baddcea545f3f28ad66755686aae128","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-09 17:09:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"dbc94d2b647ac4ad4674c10868cb9456d63845ab","date":"2017-02-09 18:12:09.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"f870760de54928819287bfc4cf141102b254990e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-09 18:12:09.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-docs-ubuntu-xenial http://docs-draft.openstack.org/08/430308/1/gate/gate-python-cinderclient-docs-ubuntu-xenial/80ee59c//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-cinderclient-pep8-ubuntu-xenial http://logs.openstack.org/08/430308/1/gate/gate-python-cinderclient-pep8-ubuntu-xenial/0cbf967/ : SUCCESS in 4m 56s\n- gate-python-cinderclient-python27-ubuntu-xenial http://logs.openstack.org/08/430308/1/gate/gate-python-cinderclient-python27-ubuntu-xenial/138aef6/ : SUCCESS in 3m 50s\n- gate-python-cinderclient-python35 http://logs.openstack.org/08/430308/1/gate/gate-python-cinderclient-python35/0cc4111/ : SUCCESS in 2m 16s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial http://logs.openstack.org/08/430308/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient-ubuntu-xenial/a9ceb97/ : SUCCESS in 1h 01m 30s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"84346b5dba784bfeb3a53ae83d400ba264263cf6","revisions":{"84346b5dba784bfeb3a53ae83d400ba264263cf6":{"kind":"REWORK","_number":1,"created":"2017-02-07 15:22:29.000000000","uploader":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"ref":"refs/changes/08/430308/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/08/430308/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/08/430308/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/08/430308/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/08/430308/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/08/430308/1"}}},"commit":{"parents":[{"commit":"d10b467af4e2aabbd7935ebbe0eeacce2ce533e3","subject":"static method to get_highest_client_server_version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d10b467af4e2aabbd7935ebbe0eeacce2ce533e3"}]}],"author":{"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","date":"2017-02-07 15:21:21.000000000","tz":60},"committer":{"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","date":"2017-02-07 15:22:27.000000000","tz":60},"subject":"Handle log message interpolation by the logger","message":"Handle log message interpolation by the logger\n\nAccording to OpenStack Guideline[1], logged string message should be\ninterpolated by the logger.\n\n[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages\n\nChange-Id: Ib5f86d1f0846e292457813c893b73c6999e554a5\nCloses-Bug: #1596829\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/84346b5dba784bfeb3a53ae83d400ba264263cf6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/84346b5dba784bfeb3a53ae83d400ba264263cf6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}