)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"219b0a3bf0b513709dc5e00c56cb1dcbcc702337","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-01 06:28:11 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix sort_Key error in cinder manageable list help note"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I211554c4cb1abd7d582fdd90ee2295996d6f02b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a25e98e_db1fb759","line":8,"updated":"2017-03-13 20:35:05.000000000","message":"Please explain what this change does.","commit_id":"d0977c7e5f201bb44f4ccce6975d2d4d998cefd2"},{"author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"change_message_id":"c060b2f85b663567b78dfb4068913dba8db2c626","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-01 06:28:11 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix sort_Key error in cinder manageable list help note"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I211554c4cb1abd7d582fdd90ee2295996d6f02b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a1ff146_03e54136","line":8,"in_reply_to":"3a1ff146_a83c4c30","updated":"2017-03-15 11:21:39.000000000","message":"Yeah,you are right. The manageable-list command just support size and reference sort-key indeed. In your patch, you just simply modify SORT_KEY_VALUES to remove keys not supported by  manageable-list. But SORT_KEY_VALUES is use by other commands, such as cidner list. Your fix method impact other commands, so I don\u0027t think it\u0027s a good fix.","commit_id":"d0977c7e5f201bb44f4ccce6975d2d4d998cefd2"},{"author":{"_account_id":24941,"name":"Prerna Dembla","email":"prernadembla05@gmail.com","username":"PrernaDembla"},"change_message_id":"c3e72a05914bed7c762786502261ed1e413f47c2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-01 06:28:11 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix sort_Key error in cinder manageable list help note"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I211554c4cb1abd7d582fdd90ee2295996d6f02b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a1ff146_a83c4c30","line":8,"in_reply_to":"7a25e98e_db1fb759","updated":"2017-03-15 11:09:07.000000000","message":"Cinder manageable-list is used to list all manageable volumes on a cinder host. Sorting can be applied on volume list by using --sort\u003ckey\u003e as argument. Valid key are id, status, size, availability_zone, name, bootable, created_at and reference as mentioned in cinder help manageable-list and cinder cli documentation.\n\nIt only supports \"reference\" and \"size\" here. When key used are size and reference, then this give expected result and list get sorted on the basis of size or reference.\n\nwhen key used are name, status, availability_zone, name, bootable or created_at then HTTP 400 error is raised and invalid key passed message is displayed.\n\nSo, sort key parameter is valid only for size and reference.","commit_id":"d0977c7e5f201bb44f4ccce6975d2d4d998cefd2"}],"cinderclient/base.py":[{"author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"change_message_id":"7af451e25f035db28e85f8c2862e42acdff1471a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Valid sort directions and client sort keys"},{"line_number":35,"context_line":"SORT_DIR_VALUES \u003d (\u0027asc\u0027, \u0027desc\u0027)"},{"line_number":36,"context_line":"SORT_KEY_VALUES \u003d (\u0027size\u0027, \u0027reference\u0027)"},{"line_number":37,"context_line":"# Mapping of client keys to actual sort keys"},{"line_number":38,"context_line":"SORT_KEY_MAPPINGS \u003d {\u0027name\u0027: \u0027display_name\u0027}"},{"line_number":39,"context_line":"# Additional sort keys for resources"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_f15556c6","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":39},"updated":"2017-03-15 07:55:49.000000000","message":"Hi, I think just modifing the SORT_KEY_VALUES is not a very good solution. Because the SORT_KEY_VALUES is used by other commands, and they may support sort keys besides size and reference. My patch is :   https://review.openstack.org/#/c/445774/  I think it\u0027s a better solution. If you like, I can add you as co-author in my patch.","commit_id":"d0977c7e5f201bb44f4ccce6975d2d4d998cefd2"}]}