)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e4ecbb8a228575f324ebbd33aad3c1e331aa1d5f","unresolved":false,"context_lines":[{"line_number":752,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":753,"context_line":"           type\u003dint,"},{"line_number":754,"context_line":"           const\u003d1,"},{"line_number":755,"context_line":"           default\u003d0,"},{"line_number":756,"context_line":"           help\u003d\u0027Shows details for all tenants. Admin only.\u0027)"},{"line_number":757,"context_line":"def do_group_list(cs, args):"},{"line_number":758,"context_line":"    \"\"\"Lists all groups.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_0e0a028a","line":755,"updated":"2017-03-13 12:07:29.000000000","message":"-1: setting default value should be done here\n\n default\u003dutils.env(\u0027ALL_TENANTS\u0027, default\u003d0)","commit_id":"15413e23142b53ad77c11cce73e663cf02ac45ac"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"dc84d3d700b57f20f35d172e9a2ceb851a136736","unresolved":false,"context_lines":[{"line_number":756,"context_line":"           help\u003d\u0027Shows details for all tenants. Admin only.\u0027)"},{"line_number":757,"context_line":"def do_group_list(cs, args):"},{"line_number":758,"context_line":"    \"\"\"Lists all groups.\"\"\""},{"line_number":759,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":760,"context_line":"    search_opts \u003d {\u0027all_tenants\u0027: all_tenants}"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    groups \u003d cs.groups.list(search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_191c6ec0","line":759,"range":{"start_line":759,"start_character":22,"end_line":759,"end_character":70},"updated":"2017-03-09 16:07:23.000000000","message":"-1 I think, we need to use parameter from args with higher priority.\nAlso this int converting is not safe. If env\u0027s ALL_TENANTS will be set in different to 0|1 value, this will trigger ValueError exception.","commit_id":"15413e23142b53ad77c11cce73e663cf02ac45ac"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"689187b7f918147581bf172999a04a7ea5bc61a2","unresolved":false,"context_lines":[{"line_number":756,"context_line":"           help\u003d\u0027Shows details for all tenants. Admin only.\u0027)"},{"line_number":757,"context_line":"def do_group_list(cs, args):"},{"line_number":758,"context_line":"    \"\"\"Lists all groups.\"\"\""},{"line_number":759,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":760,"context_line":"    search_opts \u003d {\u0027all_tenants\u0027: all_tenants}"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    groups \u003d cs.groups.list(search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_cef62a5c","line":759,"range":{"start_line":759,"start_character":22,"end_line":759,"end_character":70},"in_reply_to":"9a30ddce_0e1842d2","updated":"2017-03-13 12:11:43.000000000","message":"Yeah, the idea sounds reasonable for me, but there are some action (volume、snapshot、group_snapshot) did in this way as well. Shall we fix them all in a follow patch? Because maybe some guys don\u0027t like the idea.","commit_id":"15413e23142b53ad77c11cce73e663cf02ac45ac"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e4ecbb8a228575f324ebbd33aad3c1e331aa1d5f","unresolved":false,"context_lines":[{"line_number":756,"context_line":"           help\u003d\u0027Shows details for all tenants. Admin only.\u0027)"},{"line_number":757,"context_line":"def do_group_list(cs, args):"},{"line_number":758,"context_line":"    \"\"\"Lists all groups.\"\"\""},{"line_number":759,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":760,"context_line":"    search_opts \u003d {\u0027all_tenants\u0027: all_tenants}"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    groups \u003d cs.groups.list(search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_0e1842d2","line":759,"range":{"start_line":759,"start_character":22,"end_line":759,"end_character":70},"in_reply_to":"9a30ddce_191c6ec0","updated":"2017-03-13 12:07:29.000000000","message":"I agree parameter has always higher priority, and doing it via the default parameter to arg does it correctly.","commit_id":"15413e23142b53ad77c11cce73e663cf02ac45ac"}]}